Skip to contentSkip to conversation

list_move in prune_icache_sb

DISCUSSION Christoph Hellwig 1 participant 1 message Sep 2, 2011 VFS

lore
Share & tools
lore
#0 lore raw
	/*
	 * we are inverting the sb->s_inode_lru_lock/inode->i_lock here,
	 * so use a trylock. If we fail to get the lock, just move the
	 * inode to the back of the list so we don't spin on it.
	 */
	if (!spin_trylock(&inode->i_lock)) {
		list_move(&inode->i_lru, &sb->s_inode_lru);
		continue;
	}

was introduced in "fs: Lock the inode LRU list separately". But list_move moves to the front of the list, where the item already is, making this a no-op. Should probably be a list_move_tail.