Skip to contentSkip to conversation

ASoC: codecs: Remove unused mutex

PATCH In review Axel Lin 2 participants 4 messages Sep 4, 2011

Subsystems (3)
Sound ASoC Wolfson microelectronics drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: codecs: Remove unused mutex

Signed-off-by Axel Lin <[email protected]>
Cc Arnaud Patard <[email protected]>
Cc Mark Brown <[email protected]>
---
 sound/soc/codecs/alc5623.c |    2 --
 sound/soc/codecs/wm9090.c  |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
sound/soc/codecs/alc5623.c +0 -2
index eecffb5..0517315 100644
@@ -41,7 +41,6 @@ MODULE_PARM_DESC(caps_charge, "ALC5623 cap charge time (msecs)");
 struct alc5623_priv {
 	enum snd_soc_control_type control_type;
 	void *control_data;
-	struct mutex mutex;
 	u8 id;
 	unsigned int sysclk;
 	u16 reg_cache[ALC5623_VENDOR_ID2+2];

@@ -1052,7 +1051,6 @@ static int alc5623_i2c_probe(struct i2c_client *client,
 	i2c_set_clientdata(client, alc5623);
 	alc5623->control_data = client;
 	alc5623->control_type = SND_SOC_I2C;
-	mutex_init(&alc5623->mutex);
 
 	ret =  snd_soc_register_codec(&client->dev,
 		&soc_codec_device_alc5623, &alc5623_dai, 1);
sound/soc/codecs/wm9090.c +0 -2
index 4de1220..f2f3077 100644
@@ -139,7 +139,6 @@ static const u16 wm9090_reg_defaults[] = {
 
 /* This struct is used to save the context */
 struct wm9090_priv {
-	struct mutex mutex;
 	struct wm9090_platform_data pdata;
 	void *control_data;
 };

@@ -663,7 +662,6 @@ static int wm9090_i2c_probe(struct i2c_client *i2c,
 
 	i2c_set_clientdata(i2c, wm9090);
 	wm9090->control_data = i2c;
-	mutex_init(&wm9090->mutex);
 
 	ret =  snd_soc_register_codec(&i2c->dev,
 			&soc_codec_dev_wm9090,  NULL, 0);
Signature · 1 line
1.7.4.1
author
#2 lore raw

2011/9/4 Mark Brown <[email protected]>:

Quoted 11 lines · Axel Lin
Quoted 6 lines
Signed-off-by Axel Lin <[email protected]>
Cc Arnaud Patard <[email protected]>
Cc Mark Brown <[email protected]>

---
 sound/soc/codecs/alc5623.c |    2 --
 sound/soc/codecs/wm9090.c  |    2 --

This has already been done for wm9090, can you resubmit with just the alc5623 change please?

Ok. A new patch "ASoC: alc5623: Remove unused mutex" is on the way.

Thanks,
Axel

#3 lore raw
Quoted 6 lines · Axel Lin

2011/9/4 Mark Brown <[email protected]>:

Quoted 2 lines

This has already been done for wm9090, can you resubmit with just the alc5623 change please?

Ok. A new patch "ASoC: alc5623: Remove unused mutex" is on the way.

Thanks. The patch has been sitting there for a little while but it's not on kernel.org due to the lockdown after the compromise - until we can start pushing updates again there's a risk of overlaps like this.