Skip to contentSkip to conversation

lib/sha1.c: quite sparse noise about symbol not declared

PATCH In review H Hartley Sweeten 3 participants 3 messages Sep 9, 2011 – Sep 22, 2011

Subsystems (2)
Library code Crypto API
lore
Share & tools
lore

H Hartley Sweeten

author
#0 lore raw

PATCH 1/1 lib/sha1.c: quite sparse noise about symbol not declared

Include <linux/cryptohash.h> to pickup the declarations for sha_transform and sha_init to quite the sparse noise:

warning: symbol 'sha_transform' was not declared. Should it be static?
warning: symbol 'sha_init' was not declared. Should it be static?

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Mandeep Singh Baines <[email protected]>

---

lib/sha1.c +1 -0
index f33271d..1de509a 100644
@@ -8,6 +8,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/bitops.h>
+#include <linux/cryptohash.h>
 #include <asm/unaligned.h>
 
 /*
Acked-by Mandeep Singh Baines on v1 1/1
#1 lore raw

+cc linux-crypto, herbert, davem, torvalds

Quoted 9 lines · H Hartley Sweeten

Include <linux/cryptohash.h> to pickup the declarations for sha_transform and sha_init to quite the sparse noise:

warning: symbol 'sha_transform' was not declared. Should it be static?
warning: symbol 'sha_init' was not declared. Should it be static?

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Mandeep Singh Baines <[email protected]>
Acked-by Mandeep Singh Baines <[email protected]>

Thanks.

Quoted 14 lines

---

lib/sha1.c +1 -0
index f33271d..1de509a 100644
@@ -8,6 +8,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/bitops.h>
+#include <linux/cryptohash.h>
 #include <asm/unaligned.h>
 
 /*
#2 lore raw
Quoted 6 lines · On Tue, Sep 13, 2011 at 02:58:51PM -0700, [email protected] wrote:

+cc linux-crypto, herbert, davem, torvalds

Quoted 3 lines · H Hartley Sweeten

Include <linux/cryptohash.h> to pickup the declarations for sha_transform and sha_init to quite the sparse noise:

Quoted 8 lines
Quoted 6 lines

warning: symbol 'sha_transform' was not declared. Should it be static?
warning: symbol 'sha_init' was not declared. Should it be static?

Signed-off-by H Hartley Sweeten <[email protected]>
Cc Mandeep Singh Baines <[email protected]>
Acked-by Mandeep Singh Baines <[email protected]>

Patch applied. Thanks!

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt