Skip to contentSkip to conversation

KS8695: move TIMER_ definitions before code use

PATCH New Greg Ungerer 2 participants 4 messages Sep 9, 2011 – Sep 10, 2011 Arm (32-bit)

lore
Share & tools
lore

Greg Ungerer

author
#0 lore raw

PATCH 1/1 KS8695: move TIMER_ definitions before code use

Move the TIMER_ definitions before they are used in KS8695 timer.c code. Fixes:

timer.c: In function ?timer_init?:
timer.c:37: error: ?TIMER_COUNT? undeclared (first use in this function) timer.c:37: error: (Each undeclared identifier is reported only once timer.c:37: error: for each function it appears in.) timer.c:38: error: ?TIMER_PULSE? undeclared (first use in this function)

Signed-off-by Greg Ungerer <[email protected]>
---
 arch/arm/cpu/arm920t/ks8695/timer.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)
arch/arm/cpu/arm920t/ks8695/timer.c +8 -8
index 234fe91..0852502 100644
@@ -24,6 +24,14 @@
 #include <asm/arch/platform.h>
 
 /*
+ * Initial timer set constants. Nothing complicated, just set for a 1ms
+ * tick.
+ */
+#define	TIMER_INTERVAL	(TICKS_PER_uSEC * mSEC_1)
+#define	TIMER_COUNT	(TIMER_INTERVAL / 2)
+#define	TIMER_PULSE	TIMER_COUNT
+
+/*
  * Handy KS8695 register access functions.
  */
 #define	ks8695_read(a)    *((volatile ulong *) (KS8695_IO_BASE + (a)))

@@ -42,14 +50,6 @@ int timer_init (void)
 	return 0;
 }
 
-/*
- * Initial timer set constants. Nothing complicated, just set for a 1ms
- * tick.
- */
-#define	TIMER_INTERVAL	(TICKS_PER_uSEC * mSEC_1)
-#define	TIMER_COUNT	(TIMER_INTERVAL / 2)
-#define	TIMER_PULSE	TIMER_COUNT
-
 ulong get_timer_masked(void)
 {
 	/* Check for timer wrap */
Signature · 1 line
1.7.4.1
Applied
#1 lore raw

PATCH 1/1 KS8695: move TIMER_ definitions before code use

Dear Greg Ungerer,

Quoted 9 lines · In message <[email protected]> you…

Move the TIMER_ definitions before they are used in KS8695 timer.c code. Fixes:

timer.c: In function `timer_init?:
timer.c:37: error: TIMER_COUNT? undeclared (first use in this function) timer.c:37: error: (Each undeclared identifier is reported only once timer.c:37: error: for each function it appears in.) timer.c:38: error: TIMER_PULSE? undeclared (first use in this function)

Quoted 4 lines
Signed-off-by Greg Ungerer <[email protected]>
---
 arch/arm/cpu/arm920t/ks8695/timer.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The value of marriage is not that adults produce children, but  that
children produce adults."                            - Peter De Vries
#2 lore raw

PATCH 1/1 KS8695: move TIMER_ definitions before code use

In reply to Greg Ungerer

Dear Greg,

Quoted 2 lines · In message <[email protected]> you…

Move the TIMER_ definitions before they are used in KS8695 timer.c code. Fixes:

Could you please also fix the remaining warnings:

Configuring for cm4008 board...
eth.c:546:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI cm4008.c: In function 'env_flash_cmdline':
cm4008.c:67: warning: pointer targets in passing argument 2 of 'setenv' differ in signedness
text data bss dec hex filename
116840 2512 37480 156832 264a0 /work/wd/tmp-arm/u-boot

Configuring for cm41xx board...
eth.c:546:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI cm41xx.c: In function 'env_flash_cmdline':
cm41xx.c:67: warning: pointer targets in passing argument 2 of 'setenv' differ in signedness
text data bss dec hex filename
116856 2512 37464 156832 264a0 /work/wd/tmp-arm/u-boot

Thanks in advance.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4
author
#3 lore raw

PATCH 1/1 KS8695: move TIMER_ definitions before code use

Hi Wolfgang,

Quoted 7 lines · Wolfgang Denk

Dear Greg,

Quoted 2 lines · In message<[email protected]> you…

Move the TIMER_ definitions before they are used in KS8695 timer.c code. Fixes:

Could you please also fix the remaining warnings:

Sure thing. Patches coming soon.

Regards
Greg

Quoted 23 lines

Configuring for cm4008 board...
eth.c:546:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI cm4008.c: In function 'env_flash_cmdline':
cm4008.c:67: warning: pointer targets in passing argument 2 of 'setenv' differ in signedness
text data bss dec hex filename
116840 2512 37480 156832 264a0 /work/wd/tmp-arm/u-boot

Configuring for cm41xx board...
eth.c:546:2: warning: #warning Ethernet driver is deprecated. Please update to use CONFIG_NET_MULTI cm41xx.c: In function 'env_flash_cmdline':
cm41xx.c:67: warning: pointer targets in passing argument 2 of 'setenv' differ in signedness
text data bss dec hex filename
116856 2512 37464 156832 264a0 /work/wd/tmp-arm/u-boot

Thanks in advance.

Best regards,

Wolfgang Denk