Skip to contentSkip to conversation

xf86-video-intel: 6 commits - configure.ac src/sna/gen5_render.c src/sna/Makefile.am src/sna/sna_accel.c src/sna/sna_driver.c src/sna/sna.h src/sna/sna_trapezoids.c

DISCUSSION Julien Cristau 1 participant 2 messages Sep 12, 2011 – Sep 15, 2011 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Chris,

Quoted 19 lines · Chris Wilson

commit 2e1bf7e1b44db16d0c322f17535fc6a6fa07353b

Author: Chris Wilson <[email protected]>
Date:   Fri Sep 9 12:36:32 2011 +0100

sna: Record git-tree used for compilation

Hopefully, I have all the dependencies correct for auto-updating and should continue to work with tarballs...

The next step is to perhaps include it in the usual version number, perhaps as patch level?

configure.ac +0 -0
index fbd46a7..089fbdb 100644

configure.ac m4_ifndef([XORG_DRIVER_CHECK_EXT], · line 64

Quoted 6 lines
configure.ac +3 -0
@@ -59,6 +59,14 @@ m4_ifndef([XORG_DRIVER_CHECK_EXT],
 LT_PREREQ([2.2])
 LT_INIT([disable-static])
 
+# Are we in a git checkout?
+dot_git=no
+if test -e .git; then

$srcdir/.git? (and more in the Makefile.am, $(top_builddir) doesn't really make sense there)

configure.ac m4_ifndef([XORG_DRIVER_CHECK_EXT], · line 72

Quoted 8 lines
configure.ac +5 -0
+	AC_DEFINE(HAVE_DOT_GIT, 1, [Are we in a git checkout?])
+	dot_git=yes
+fi
+AM_CONDITIONAL(HAVE_DOT_GIT, test x$dot_git = xyes)
+
 PKG_CHECK_MODULES(GEN4ASM, [intel-gen4asm >= 1.2], [gen4asm=yes], [gen4asm=no])
 AM_CONDITIONAL(HAVE_GEN4ASM, test x$gen4asm = xyes)
 

Can I please get a way to opt out of this? I build from a git tree, but my .git isn't really something I want to put in my (or other people's) X logs. Doesn't matter a whole lot as long as I'm not building sna, but...

Cheers,
Julien

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 9 lines · Chris Wilson
Quoted 3 lines · Julien Cristau

Can I please get a way to opt out of this? I build from a git tree, but my .git isn't really something I want to put in my (or other people's) X logs. Doesn't matter a whole lot as long as I'm not building sna, but...

Ok, sure. My thoughts were that it would only be useful to people building their own drivers, in which case having a confirmation that they are running the right one is invaluable. Outside of that context, the git id is indeed meaningless. Thanks for the feedback,

Right, in that context having the revision show up in the log for confirmation makes perfect sense. Maybe something like the server's --with-builderstring that would default to git describe but could be overridden at configure time?

Cheers,
Julien