Skip to contentSkip to conversation

mkconfig: start deprecating Makefile config targets

PATCH Superseded Mike Frysinger 3 participants 8 messages Sep 18, 2011 – Oct 5, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mkconfig: start deprecating Makefile config targets

Now that we've got boards.cfg and most people have converted over, start warning people who have yet to so we can phase board configs completely out of the Makefile.

---
 mkconfig |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
mkconfig +9 -0
index ecb6d4e..6a60849 100755
@@ -29,6 +29,15 @@ if [ \( $# -eq 2 \) -a \( "$1" = "-A" \) ] ; then
 	set ${line}
 	# add default board name if needed
 	[ $# = 3 ] && set ${line} ${1}
+elif [ "${MAKEFLAGS+set}${MAKELEVEL+set}" = "setset" ] ; then
+	# only warn when using a config target in the Makefile
+	cat <<-EOF
+
+	warning: Please migrate to boards.cfg.  Failure to do so will
+	         mean removal of your board board in the next release.
+
+	EOF
+	sleep 5
 fi
 
 while [ $# -gt 0 ] ; do
Signature · 1 line
1.7.6
#1 lore raw

PATCH 1/1 mkconfig: start deprecating Makefile config targets

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Frysinger <[email protected]> writes:

Mike> Now that we've got boards.cfg and most people have converted over, Mike> start warning people who have yet to so we can phase board configs Mike> completely out of the Makefile.

Mike> Signed-off-by: Mike Frysinger <[email protected]> Mike> ---

 Mike>  mkconfig |    9 +++++++++

Mike> 1 files changed, 9 insertions(+), 0 deletions(-)

Mike> diff --git a/mkconfig b/mkconfig
Mike> index ecb6d4e..6a60849 100755
Mike> --- a/mkconfig
Mike> +++ b/mkconfig
Mike> @@ -29,6 +29,15 @@ if [ \( $# -eq 2 \) -a \( "$1" = "-A" \) ] ; then

 Mike>  	set ${line}
 Mike>  	# add default board name if needed
 Mike>  	[ $# = 3 ] && set ${line} ${1}

Mike> +elif [ "${MAKEFLAGS+set}${MAKELEVEL+set}" = "setset" ] ; then
Mike> + # only warn when using a config target in the Makefile
Mike> + cat <<-EOF
Mike> +
Mike> + warning: Please migrate to boards.cfg. Failure to do so will
Mike> + mean removal of your board board in the next release.

s/board board/board/

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH v2 1/1 mkconfig: start deprecating Makefile config targets

In reply to Mike Frysinger

Now that we've got boards.cfg and most people have converted over, start warning people who have yet to so we can phase board configs completely out of the Makefile.

---
v2
- fix typo in warning msg

 mkconfig |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
mkconfig +9 -0
index ecb6d4e..438530b 100755
@@ -29,6 +29,15 @@ if [ \( $# -eq 2 \) -a \( "$1" = "-A" \) ] ; then
 	set ${line}
 	# add default board name if needed
 	[ $# = 3 ] && set ${line} ${1}
+elif [ "${MAKEFLAGS+set}${MAKELEVEL+set}" = "setset" ] ; then
+	# only warn when using a config target in the Makefile
+	cat <<-EOF
+
+	warning: Please migrate to boards.cfg.  Failure to do so will
+	         mean removal of your board in the next release.
+
+	EOF
+	sleep 5
 fi
 
 while [ $# -gt 0 ] ; do
Signature · 1 line
1.7.6
#3 lore raw

PATCH v2 1/1 mkconfig: start deprecating Makefile config targets

Dear Mike Frysinger,

Quoted 11 lines · In message <[email protected]> you wrote:

Now that we've got boards.cfg and most people have converted over, start warning people who have yet to so we can phase board configs completely out of the Makefile.

---
v2
- fix typo in warning msg

 mkconfig |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

Please update doc/feature-removal-schedule.txt as well.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A little knowledge is a dangerous thing."                - Doug Gwyn
#4 lore raw

PATCH v2 1/1 mkconfig: start deprecating Makefile config targets

Quoted 9 lines · On Monday, September 19, 2011 10:14:46 Wolfgang Denk wrote:
Quoted 8 lines · Mike Frysinger

Now that we've got boards.cfg and most people have converted over, start warning people who have yet to so we can phase board configs completely out of the Makefile.

---
v2

Quoted 6 lines
Quoted 4 lines

- fix typo in warning msg

 mkconfig |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

Please update doc/feature-removal-schedule.txt as well.

i didnt have a schedule in mind ... just start scaring people :)

any target you have in mind ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110919/9d1e9436/attachment.pgp

#5 lore raw

PATCH v2 1/1 mkconfig: start deprecating Makefile config targets

Dear Mike Frysinger,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 2 lines

Please update doc/feature-removal-schedule.txt as well.

i didnt have a schedule in mind ... just start scaring people :)

any target you have in mind ?

Next release? Second next release?

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you think the problem is bad now, just wait until we've solved it.
                                                        Epstein's Law
#6 lore raw

PATCH v3 1/1 mkconfig: start deprecating Makefile config targets

In reply to Mike Frysinger

Now that we've got boards.cfg and most people have converted over, start warning people who have yet to so we can phase board configs completely out of the Makefile.

---
v3
- add an actual target for board removal

 doc/feature-removal-schedule.txt |   16 ++++++++++++++++
 mkconfig                         |    9 +++++++++
 2 files changed, 25 insertions(+), 0 deletions(-)
doc/feature-removal-schedule.txt +16 -0
index 180ead5..13d7d9a 100644
@@ -7,6 +7,22 @@ file.
 
 ---------------------------
 
+What:	boards with xxx_config targets in top level Makefile
+When:	Release v2012.03
+
+Why:	We have a boards.cfg file which the vast majority of boards have
+	converted over to.  Boards that still manually run mkconfig in the
+	top level Makefile are either dead, or the maintainer doesn't care,
+	or they are doing something weird/wrong that should be fixed in a
+	different way, or they need to extend boards.cfg syntax (unlikely).
+
+	In any case, if no one cares about these boards to figure out how
+	to make boards.cfg work, then we'll just punt them.
+
+Who:	Mike Frysinger <[email protected]>
+
+---------------------------
+
 What:	CONFIG_NET_MULTI option
 When:	Release 2009-11
 
mkconfig +9 -0
index ecb6d4e..438530b 100755
@@ -29,6 +29,15 @@ if [ \( $# -eq 2 \) -a \( "$1" = "-A" \) ] ; then
 	set ${line}
 	# add default board name if needed
 	[ $# = 3 ] && set ${line} ${1}
+elif [ "${MAKEFLAGS+set}${MAKELEVEL+set}" = "setset" ] ; then
+	# only warn when using a config target in the Makefile
+	cat <<-EOF
+
+	warning: Please migrate to boards.cfg.  Failure to do so will
+	         mean removal of your board in the next release.
+
+	EOF
+	sleep 5
 fi
 
 while [ $# -gt 0 ] ; do
Signature · 1 line
1.7.6.1
#7 lore raw

PATCH v3 1/1 mkconfig: start deprecating Makefile config targets

Dear Mike Frysinger,

Quoted 4 lines · In message <[email protected]> you wrote:

Now that we've got boards.cfg and most people have converted over, start warning people who have yet to so we can phase board configs completely out of the Makefile.

Quoted 8 lines

---
v3
- add an actual target for board removal

 doc/feature-removal-schedule.txt |   16 ++++++++++++++++
 mkconfig                         |    9 +++++++++
 2 files changed, 25 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
But it's real. And if it's real it can be affected ... we may not  be
able  to break it, but, I'll bet you credits to Navy Beans we can put
a dent in it.
	-- deSalle, "Catspaw", stardate 3018.2