Fix incorrect array size of phy settings for 405EX

PATCH New Weirich 3 participants 4 messages Sep 8, 2011 – Sep 19, 2011 PowerPC

Share & tools

Weirich

2011-09-08 16:27 UTC #0 lore raw

PATCH 1/1 Fix incorrect array size of phy settings for 405EX

Hello,

I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member, but should have two. So I propose this very simple patch.

Best regards,
Bernhard Weirich

Signed-off-by Bernhard Weirich <[email protected]>

arch/powerpc/include/asm/u-boot.h +1 -1

@@ -132,7 +132,7 @@
     defined(CONFIG_460EX) || defined(CONFIG_460GT)
 	int		bi_phynum[4];           /* Determines phy mapping */
 	int		bi_phymode[4];          /* Determines phy mode */
-#elif defined(CONFIG_405EP) || defined(CONFIG_440)
+#elif defined(CONFIG_405EP) || defined(CONFIG_440) || defined(CONFIG_405EX)
 	int		bi_phynum[2];           /* Determines phy mapping */
 	int		bi_phymode[2];          /* Determines phy mode */
 #else

Wolfgang Denk

2011-09-09 06:51 UTC #1 lore raw

PATCH 1/1 Fix incorrect array size of phy settings for 405EX

Dear "Weirich, Bernhard",

Quoted 12 lines · In message <[email protected]> you…

Hello,
I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member, but should have two. So I propose this very simple patch.
Best regards,
Bernhard Weirich
Signed-off-by Bernhard Weirich <[email protected]>

arch/powerpc/include/asm/u-boot.h line 135

Quoted 5 lines

arch/powerpc/include/asm/u-boot.h +1 -1

@@ -132,7 +132,7 @@
     defined(CONFIG_460EX) || defined(CONFIG_460GT)
 	int		bi_phynum[4];           /* Determines phy mapping */
 	int		bi_phymode[4];          /* Determines phy mode */
-#elif defined(CONFIG_405EP) || defined(CONFIG_440)
+#elif defined(CONFIG_405EP) || defined(CONFIG_440) || defined(CONFIG_405EX)

Please keep list sorted, and move the "Best regards," part out of the commit message.

Thanks.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you want strict real-time behavior, run in the real  time  schedu-
ling class.  But there are no seatbelts or airbags;  main(){for(;;);}
can hard hang your system.                          -- Bart Smaalders

Stefan Roese

2011-09-09 07:05 UTC #2 lore raw

PATCH 1/1 Fix incorrect array size of phy settings for 405EX

Hi Bernhard,

Quoted 10 lines · On Friday 09 September 2011 08:51:26 Wolfgang Denk wrote:

Quoted 10 lines
Hello,
I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member, but should have two. So I propose this very simple patch.
Best regards,
Bernhard Weirich
Signed-off-by Bernhard Weirich <[email protected]>
--- u-boot-v2010.12-rc3-orig/arch/powerpc/include/asm/u-boot.h

2010-12-20

Quoted 4 lines

Quoted 4 lines
10:58:41.000000000 +0100 +++
u-boot-v2010.12-rc3/arch/powerpc/include/asm/u-boot.h 2011-09-08
18:25:57.136700984 +0200 @@ -132,7 +132,7 @@

Quoted 8 lines

     defined(CONFIG_460EX) || defined(CONFIG_460GT)

arch/powerpc/include/asm/u-boot.h +1 -1

 	int		bi_phynum[4];           /* Determines phy mapping */
 	int		bi_phymode[4];          /* Determines phy mode */
 
-#elif defined(CONFIG_405EP) || defined(CONFIG_440)
+#elif defined(CONFIG_405EP) || defined(CONFIG_440) ||

defined(CONFIG_405EX)

Thanks for catching this.

Quoted 2 lines

Please keep list sorted, and move the "Best regards," part out of the commit message.

Yes. And please add a "Signed-off-by: .." line instead. I suggest you take a look at other patches submitted to the list to see how a "proper" commit text is composed.

Thanks.

Best regards,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

Stefan Roese

Applied

2011-09-19 11:58 UTC #3 lore raw

PATCH 1/1 Fix incorrect array size of phy settings for 405EX

In reply to Weirich

Hi Bernhard,

Quoted 9 lines · Bernhard

Hello,
I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member, but should have two. So I propose this very simple patch.
Best regards,
Bernhard Weirich
Signed-off-by Bernhard Weirich <[email protected]>

Applied, after manually fixing all the formal issues with this patch (commit message tweaked, line too long). Additionally the requested change from Wolfgang (list sorted) has been made.

Thanks.

Best regards,
Stefan