suspend: off by one in pm_suspend()
Subsystems (3)
PATCH 1/1 suspend: off by one in pm_suspend()
In enter_state() we use "state" as an offset for the pm_states[] array. The pm_states[] array only has PM_SUSPEND_MAX elements so this test is off by one.
Signed-off-by Dan Carpenter <[email protected]>
kernel/power/suspend.c +1 -1
@@ -321,7 +321,7 @@ int enter_state(suspend_state_t state)int pm_suspend (suspend_state_t state) {int ret; -if (state >PM_SUSPEND_ON && state <=PM_SUSPEND_MAX ) { +if (state >PM_SUSPEND_ON && state <PM_SUSPEND_MAX ) { ret =enter_state (state);if (ret) { suspend_stats.fail++;
Rafael J. Wysocki
AppliedQuoted 5 lines · Dan Carpenter
In
enter_state()we use "state" as an offset for the pm_states[] array. The pm_states[] array only hasPM_SUSPEND_MAXelements so this test is off by one.Signed-off-by Dan Carpenter <[email protected]>
Applied to linux-pm/linux-next, will be pushed for 3.2.
Thanks,
Rafael
Quoted 15 lines
kernel/power/suspend.c +1
-1@@ -321,7 +321,7 @@ int enter_state(suspend_state_t state)int pm_suspend (suspend_state_t state) {int ret; -if (state >PM_SUSPEND_ON && state <=PM_SUSPEND_MAX ) { +if (state >PM_SUSPEND_ON && state <PM_SUSPEND_MAX ) { ret =enter_state (state);if (ret) { suspend_stats.fail++;