Skip to contentSkip to conversation

xen_biovec_phys_mergeable not exported

DISCUSSION Matthew Wilcox 3 participants 3 messages Sep 20, 2011 – Sep 21, 2011

lore
Share & tools
lore
#0 lore raw

In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN is defined, it references xen_biovec_phys_mergeable() which is not EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing to be calling from a module that implements a bio-based block driver, so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to the Xen code when I submit the driver.

Does anyone have a different opinion on this?

Signature · 4 lines
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
#1 lore raw
Quoted 9 lines · Matthew Wilcox

In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN is defined, it references xen_biovec_phys_mergeable() which is not EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing to be calling from a module that implements a bio-based block driver, so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to the Xen code when I submit the driver.

Does anyone have a different opinion on this?

Yep, lets just export it for now. Long term, that functionality will be moving back into the block layer when we unify the queuing models.

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 8 lines · Jens Axboe
Quoted 7 lines · Matthew Wilcox

In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN is defined, it references xen_biovec_phys_mergeable() which is not EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing to be calling from a module that implements a bio-based block driver, so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to the Xen code when I submit the driver.

I am OK with that.

Quoted 14 lines
Quoted 2 lines

Does anyone have a different opinion on this?

Yep, lets just export it for now. Long term, that functionality will be moving back into the block layer when we unify the queuing models.

Signature · 7 lines
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/