index 6bdc67d..eead840 100644
@@ -357,7 +357,7 @@ struct swap_cgroup_ctrl {
 	spinlock_t	lock;
 };
 
-struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
+static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
 
 struct swap_cgroup {
 	unsigned short		id;

Balbir Singh

Acked-by on v1 1/1

2011-09-23 05:52 UTC #1 lore raw

Quoted 18 lines · H Hartley Sweeten

Quite the sparse noise:
warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static?
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Paul Menage <[email protected]>
Cc Li Zefan <[email protected]>
Cc Balbir Singh <[email protected]>
Cc Daisuke Nishimura <[email protected]>
Cc KAMEZAWA Hiroyuki <[email protected]>
---
mm/page_cgroup.c +0 -0
index 6bdc67d..eead840 100644

mm/page_cgroup.c struct swap_cgroup_ctrl { · line 360

Quoted 5 lines

mm/page_cgroup.c +1 -1

@@ -357,7 +357,7 @@ struct swap_cgroup_ctrl {
        spinlock_t      lock;
  };
 
-struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
+static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];

Seems reasonable

Acked-by Balbir Singh <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>

KAMEZAWA Hiroyuki

Acked-by on v1 1/1

2011-09-26 09:13 UTC #2 lore raw

In reply to H Hartley Sweeten

Quoted 11 lines · On Thu, 22 Sep 2011 18:15:08 -0700 H Hartley Sweeten…

Quite the sparse noise:
warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static?
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Paul Menage <[email protected]>
Cc Li Zefan <[email protected]>
Cc Balbir Singh <[email protected]>
Cc Daisuke Nishimura <[email protected]>
Cc KAMEZAWA Hiroyuki <[email protected]>

Thank you.

Acked-by KAMEZAWA hiroyuki <[email protected]>