btrfs/extent_map.c: quiet sparse noise

PATCH In review H Hartley Sweeten 2 participants 2 messages Sep 23, 2011 Btrfs file system

lore

Share & tools

lore

H Hartley Sweeten

author

2011-09-23 01:45 UTC #0 lore raw

PATCH 1/1 btrfs/extent_map.c: quiet sparse noise

Quiet the sparse noise:

warning: symbol '__lookup_extent_mapping' was not declared. Should it be static?

Signed-off-by H Hartley Sweeten <[email protected]>

Cc Chris Mason <[email protected]>

[email protected]
[email protected]

---

fs/btrfs/extent_map.c +1 -1

index 7c97b33..48004fe 100644
@@ -282,7 +282,7 @@ static u64 range_end(u64 start, u64 len)
 	return start + len;
 }
 
-struct extent_map *__lookup_extent_mapping(struct extent_map_tree *tree,
+static struct extent_map *__lookup_extent_mapping(struct extent_map_tree *tree,
 					   u64 start, u64 len, int strict)
 {
 	struct extent_map *em;

[email protected]

2011-09-23 18:58 UTC #1 lore raw

Quoted 3 lines · H Hartley Sweeten

Quiet the sparse noise:
warning: symbol '__lookup_extent_mapping' was not declared. Should it be static?

Patch itself is correct, changelog is bad. You're not quieting sparse noise, you're making a declaration static because it doesn't need external visibility.