Skip to contentSkip to conversation

Question regarding wanrouter module

DISCUSSION Holger Hans Peter Freyther 2 participants 2 messages Sep 23, 2011

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi all,

at some point the Sangoma wanrouter and device drivers were merged in the kernel. Somewhere in 2006 (8db60bcf3021921e2d10d158641792d640e52fe8) the drivers were removed as Sangoma wanted to maintain them themselves. Later some of the functionality got removed (ce0ecd594d78710422599918a608). In the kernel it appears that cycx_x25.c and isdn_x25iface.c make use of the wanrouter.

Fast forward to today, Sangoma provides a wanrouter.ko as well (they didn't bother to change the symbol names or module name). I wonder if there are any plans to improve the situation, e.g. rename the kernel module, change symbols, or if there would be objections to trying to add functionality to the kernel wanrouter.ko again?

cheers
holger

#1 lore raw

Holger Hans Peter Freyther <[email protected]> :
[...]

Quoted 5 lines

Fast forward to today, Sangoma provides a wanrouter.ko as well (they didn't bother to change the symbol names or module name). I wonder if there are any plans to improve the situation, e.g. rename the kernel module, change symbols, or if there would be objections to trying to add functionality to the kernel wanrouter.ko again ?

There are objections to adding.

The kernel wanrouter code is almost empty. Afaiu it mostly contains a wan setup API.

Is there a reason why the added functionalities could not go through the generic hdlc kernel code (see drivers/net/wan/hdlc*) ?

Signature · 1 line
Ueimor