ceph/mds_client.c: quiet sparse noise

PATCH New H Hartley Sweeten 1 participant 1 message Sep 23, 2011 Ceph client

lore

Share & tools

lore

H Hartley Sweeten

author

2011-09-23 20:22 UTC #0 lore raw

PATCH 1/1 ceph/mds_client.c: quiet sparse noise

Quiet the following sparse noise:

warning: symbol 'get_nonsnap_parent' was not declared. Should it be static?
warning: symbol 'done_closing_sessions' was not declared. Should it be static?

Local functions don't need external visability. Make them static.

Signed-off-by H Hartley Sweeten <[email protected]>

Cc Sage Weil <[email protected]>

---

fs/ceph/mds_client.c +2 -2

index 2712e8f..9ec5d1e 100644
@@ -619,7 +619,7 @@ static void __unregister_request(struct ceph_mds_client *mdsc,
  *
  * Called under mdsc->mutex.
  */
-struct dentry *get_nonsnap_parent(struct dentry *dentry)
+static struct dentry *get_nonsnap_parent(struct dentry *dentry)
 {
 	/*
 	 * we don't need to worry about protecting the d_parent access

@@ -3154,7 +3154,7 @@ void ceph_mdsc_sync(struct ceph_mds_client *mdsc)
 /*
  * true if all sessions are closed, or we force unmount
  */
-bool done_closing_sessions(struct ceph_mds_client *mdsc)
+static bool done_closing_sessions(struct ceph_mds_client *mdsc)
 {
 	int i, n = 0;