ext4/fsync.c: functions should not be declared extern

PATCH Applied H Hartley Sweeten 2 participants 2 messages Sep 23, 2011 – Oct 12, 2011 ext4 file system

lore

Share & tools

lore

H Hartley Sweeten

author

2011-09-23 22:14 UTC #0 lore raw

PATCH 1/1 ext4/fsync.c: functions should not be declared extern

The function declaration in ext4.h is already marked extern. The function definition should not have the tag.

This quiets the sparse noise:

warning: function 'ext4_flush_completed_IO' with external linkage has definition

Signed-off-by H Hartley Sweeten <[email protected]>

Cc "Theodore Ts'o" <[email protected]>

Cc Andreas Dilger <[email protected]>

---

fs/ext4/fsync.c +1 -1

index 036f78f..c942924 100644
@@ -75,7 +75,7 @@ static void dump_completed_IO(struct inode * inode)
  * to written.
  * The function return the number of pending IOs on success.
  */
-extern int ext4_flush_completed_IO(struct inode *inode)
+int ext4_flush_completed_IO(struct inode *inode)
 {
 	ext4_io_end_t *io;
 	struct ext4_inode_info *ei = EXT4_I(inode);

Ted Ts'o

maintainer Applied

2011-10-12 03:09 UTC #1 lore raw

Quoted 10 lines · H Hartley Sweeten

The function declaration in ext4.h is already marked extern. The function definition should not have the tag.
This quiets the sparse noise:
warning: function 'ext4_flush_completed_IO' with external linkage has definition
Signed-off-by H Hartley Sweeten <[email protected]>
Cc "Theodore Ts'o" <[email protected]>
Cc Andreas Dilger <[email protected]>

Thanks, applied.

- Ted