9p: fix min_t() casting in p9pdu_vwritef()

PATCH New Dan Carpenter 1 participant 1 message Sep 27, 2011

Subsystems (4)

Networking Network drivers Kernel janitors 9P file system

lore

Share & tools

lore

Dan Carpenter

author

2011-09-27 06:44 UTC #0 lore raw

PATCH 1/1 9p: fix min_t() casting in p9pdu_vwritef()

I don't think we're actually likely to hit this limit but if we do then the comparison should be done as size_t. The original code is equivalent to:

	len = strlen(sptr) % USHRT_MAX;

Signed-off-by Dan Carpenter <[email protected]>

net/9p/protocol.c +1 -1

index 55e10a9..39a4c18 100644
@@ -368,7 +368,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
 				const char *sptr = va_arg(ap, const char *);
 				uint16_t len = 0;
 				if (sptr)
-					len = min_t(uint16_t, strlen(sptr),
+					len = min_t(size_t, strlen(sptr),
 								USHRT_MAX);
 
 				errcode = p9pdu_writef(pdu, proto_version,