serial: SERIAL_MRST_MAX3110 should depend on X86_MRST
PATCH 1/1 serial: SERIAL_MRST_MAX3110 should depend on X86_MRST
As I understand it, driver mrst_max3110 is only useful on Moorestown systems, so it should depend on X86_MRST.
---
There are a few other drivers in a similar situation (i2c/busses/i2c-intel-mid, gpio/langwell_gpio, tty/serial/mfd, staging/sep) for which I suspect the same should be done, assuming that X86_MRST is for both Moorestown and Medfield.
drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/Kconfig +1 -1
@@ -695,7 +695,7 @@ config SERIAL_SA1100_CONSOLE config SERIAL_MRST_MAX3110 tristate "SPI UART driver for Max3110" - depends on SPI_DW_PCI + depends on X86_MRST && SPI_DW_PCI select SERIAL_CORE select SERIAL_CORE_CONSOLE help
Signature · 2 lines
Jean Delvare Suse L3
Quoted 2 lines · On Fri, 16 Sep 2011 22:40:16 +0200 Jean Delvare <[email protected]> wrote:
As I understand it, driver
mrst_max3110is only useful on Moorestown systems, so it should depend onX86_MRST.
Not so simple. There are various things that need dependancies. Some I've sorted in my tree, some not, but it's all shelved until kernel.org is back as I've switched to working on other projects for the moment rather than waste time chasing trees around the internet.
Quoted 7 lines
Signed-off-by Jean Delvare <[email protected]>Cc Alan Cox <[email protected]>---
There are a few other drivers in a similar situation (i2c/busses/i2c-intel-mid, gpio/langwell_gpio, tty/serial/mfd, staging/sep) for which I suspect the same should be done, assuming thatX86_MRSTis for both Moorestown and Medfield.
Not with the latest patches.
Alan
Quoted 2 lines · On Fri, 16 Sep 2011 22:40:16 +0200 Jean Delvare <[email protected]> wrote:
As I understand it, driver
mrst_max3110is only useful on Moorestown systems, so it should depend onX86_MRST.
Digging into this it builds fine on any X86 so it's more useful that it is able to get build tested than to add extra config stuff making it hard to catch bugs when changing the serial layer.
Quoted 9 lines · Alan Cox
On Fri, 16 Sep 2011 22:40:16 +0200
Quoted 2 lines · Jean Delvare
As I understand it, driver
mrst_max3110is only useful on Moorestown systems, so it should depend onX86_MRST.Digging into this it builds fine on any X86 so it's more useful that
it is able to get build tested than to add extra config stuff making it hard to catch bugs when changing the serial layer.
OK, fair enough.
Signature · 2 lines
Jean Delvare Suse L3