MX51: vision2: Set global macros
PATCH 1/1 MX51: vision2: Set global macros
Adapt vision2 to the current u-boot version. Drop own macros to set global data and use the common ones.
--- include/configs/vision2.h | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-)
include/configs/vision2.h +9 -8
@@ -192,14 +192,15 @@#define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)#define PHYS_SDRAM_2 CSD1_BASE_ADDR#define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024) -#define CONFIG_SYS_SDRAM_BASE 0x90000000 -#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000 - -#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024) -#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \ - GENERATED_GBL_DATA_SIZE) -#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \ - CONFIG_SYS_GBL_DATA_OFFSET) +#define CONFIG_SYS_SDRAM_BASE (PHYS_SDRAM_1) +#define CONFIG_SYS_INIT_RAM_ADDR (IRAM_BASE_ADDR) +#define CONFIG_SYS_INIT_RAM_SIZE (IRAM_SIZE) + +#define CONFIG_SYS_INIT_SP_OFFSET \ + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) +#define CONFIG_SYS_INIT_SP_ADDR \ + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET) +#define CONFIG_BOARD_EARLY_INIT_F /* 166 MHz DDR RAM */
Signature · 1 line
1.7.1
PATCH 1/1 MX51: vision2: Set global macros
Quoted 17 lines · Stefano Babic
Adapt vision2 to the current u-boot version. Drop own macros to set global data and use the common ones.
Signed-off-by Stefano Babic <[email protected]>--- include/configs/vision2.h | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-)include/configs/vision2.h +0
-1@@ -192,14 +192,15 @@#define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)#define PHYS_SDRAM_2 CSD1_BASE_ADDR#define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024) -#define CONFIG_SYS_SDRAM_BASE 0x90000000
include/configs/vision2.h line 197
Quoted 10 lines
include/configs/vision2.h +3
-7-#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000 - -#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024) -#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \ - GENERATED_GBL_DATA_SIZE) -#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \ - CONFIG_SYS_GBL_DATA_OFFSET) +#define CONFIG_SYS_SDRAM_BASE (PHYS_SDRAM_1) +#define CONFIG_SYS_INIT_RAM_ADDR (IRAM_BASE_ADDR) +#define CONFIG_SYS_INIT_RAM_SIZE (IRAM_SIZE)
Arent the parentheses redundant here?
Cheers
Quoted 9 lines
include/configs/vision2.h +6
-0+ +#define CONFIG_SYS_INIT_SP_OFFSET \ + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) +#define CONFIG_SYS_INIT_SP_ADDR \ + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET) +#define CONFIG_BOARD_EARLY_INIT_F /* 166 MHz DDR RAM */
PATCH 1/1 MX51: vision2: Set global macros
Quoted 22 lines · Marek Vasut
Quoted 21 lines · Stefano Babic
Adapt vision2 to the current u-boot version. Drop own macros to set global data and use the common ones.
Signed-off-by Stefano Babic <[email protected]>--- include/configs/vision2.h | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-)include/configs/vision2.h +0
-5@@ -192,14 +192,15 @@#define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)#define PHYS_SDRAM_2 CSD1_BASE_ADDR#define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024) -#define CONFIG_SYS_SDRAM_BASE 0x90000000 -#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000 - -#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024) -#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \
Quoted 8 lines
include/configs/vision2.h line 197
Quoted 6 lines
include/configs/vision2.h +3
-3- GENERATED_GBL_DATA_SIZE) -#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \ - CONFIG_SYS_GBL_DATA_OFFSET) +#define CONFIG_SYS_SDRAM_BASE (PHYS_SDRAM_1) +#define CONFIG_SYS_INIT_RAM_ADDR (IRAM_BASE_ADDR) +#define CONFIG_SYS_INIT_RAM_SIZE (IRAM_SIZE)Arent the parentheses redundant here?
I will drop in V2.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================
PATCH v2 1/1 MX51: vision2: Set global macros
In reply to Stefano BabicAdapt vision2 to the current u-boot version. Drop own macros to set global data and use the common ones.
---
Changes:
- drop redundant parentheses
include/configs/vision2.h | 17 +++++++++-------- 1 files changed, 9 insertions(+), 8 deletions(-)
include/configs/vision2.h +9 -8
@@ -192,14 +192,15 @@#define PHYS_SDRAM_1_SIZE (256 * 1024 * 1024)#define PHYS_SDRAM_2 CSD1_BASE_ADDR#define PHYS_SDRAM_2_SIZE (256 * 1024 * 1024) -#define CONFIG_SYS_SDRAM_BASE 0x90000000 -#define CONFIG_SYS_INIT_RAM_ADDR 0x1FFE8000 - -#define CONFIG_SYS_INIT_RAM_SIZE (64 * 1024) -#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_SIZE - \ - GENERATED_GBL_DATA_SIZE) -#define CONFIG_SYS_INIT_SP_ADDR (CONFIG_SYS_INIT_RAM_ADDR + \ - CONFIG_SYS_GBL_DATA_OFFSET) +#define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1 +#define CONFIG_SYS_INIT_RAM_ADDR IRAM_BASE_ADDR +#define CONFIG_SYS_INIT_RAM_SIZE IRAM_SIZE + +#define CONFIG_SYS_INIT_SP_OFFSET \ + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE) +#define CONFIG_SYS_INIT_SP_ADDR \ + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET) +#define CONFIG_BOARD_EARLY_INIT_F /* 166 MHz DDR RAM */
Signature · 1 line
1.7.1