toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
PATCH v2 1/1 toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
The "" string is not equal to the empty string. This fixes build errors like:
arm-none-linux-gnueabi-gcc: : No such file or directory
---
Changes v1 -> v2:
* Use qstrip as suggested by Thomas Petazzoni
* Add build failure example to commit log for future reference
toolchain/toolchain-external/ext-tool.mk | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
toolchain/toolchain-external/ext-tool.mk +2 -1
@@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI)) # march/mtune/floating point mode needs to be passed to the external toolchain # to select the right multilib variant -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)) +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS) TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)' endif
Signature · 1 line
1.7.6.3
PATCH v2 1/1 toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
Baruch,
Le Mon, 26 Sep 2011 10:48:57 +0300,
Baruch Siach <[email protected]> a ?crit :
Quoted 6 lines
The "" string is not equal to the empty string. This fixes build errors like:
arm-none-linux-gnueabi-gcc: : No such file or directory
Signed-off-by Baruch Siach <[email protected]>
For some reason, your patch does not seem to apply on current master.
toolchain/toolchain-external/ext-tool.mk CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI)) · line 137
Quoted 7 lines
# march/mtune/floating point mode needs to be passed to the external toolchain # to select the right multilib varianttoolchain/toolchain-external/ext-tool.mk +2
-1-ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)) +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS) TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)'
Should be use TOOLCHAIN_EXTERNAL_CUSTOM_ARGS in these two lines instead ?
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
In reply to Baruch SiachHi Buildroot list,
Quoted 6 lines · Baruch Siach
The "" string is not equal to the empty string. This fixes build errors like:
arm-none-linux-gnueabi-gcc: : No such file or directory
Signed-off-by Baruch Siach <[email protected]>
Ping?
This fixes a real build breakage of the combination of external toolchain and empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS.
baruch
Quoted 25 lines
---
Changes v1 -> v2:
* Use qstrip as suggested by Thomas Petazzoni
* Add build failure example to commit log for future referencetoolchain/toolchain-external/ext-tool.mk | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)toolchain/toolchain-external/ext-tool.mk +2
-1@@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI)) # march/mtune/floating point mode needs to be passed to the external toolchain # to select the right multilib variant -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)) +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS) TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)' endifSignature · 1 line
1.7.6.3
Signature · 3 lines
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -PATCH v2 1/1 toolchain: fix build with empty BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS
Hi Buildroot list,
Quoted 11 lines · Baruch Siach
Quoted 6 lines · Baruch Siach
The "" string is not equal to the empty string. This fixes build errors like:
arm-none-linux-gnueabi-gcc: : No such file or directory
Signed-off-by Baruch Siach <[email protected]>Ping?
This fixes a real build breakage of the combination of external toolchain and emptyBR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS.
Forget it. This patch is against some local modifications for mine (a patch that has been posted here a few months ago, but never applied).
Sorry for the noise.
baruch
Quoted 24 lines
Quoted 24 lines
---
Changes v1 -> v2:
* Use qstrip as suggested by Thomas Petazzoni
* Add build failure example to commit log for future referencetoolchain/toolchain-external/ext-tool.mk | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)toolchain/toolchain-external/ext-tool.mk +2
-1@@ -131,7 +131,8 @@ CC_TARGET_ABI_:=$(call qstrip,$(BR2_GCC_TARGET_ABI)) # march/mtune/floating point mode needs to be passed to the external toolchain # to select the right multilib variant -ifneq ($(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) +TOOLCHAIN_EXTERNAL_CUSTOM_ARGS = $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)) +ifneq ($(TOOLCHAIN_EXTERNAL_CUSTOM_ARGS),) TOOLCHAIN_EXTERNAL_CFLAGS += $(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS) TOOLCHAIN_EXTERNAL_WRAPPER_ARGS += -DBR_OPT='$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_ARGS)' endifSignature · 1 line
1.7.6.3
Signature · 3 lines
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -