Skip to contentSkip to conversation

ext3/xattr_seciruty.c: local functions should be static

PATCH In review H Hartley Sweeten 2 participants 4 messages Sep 23, 2011 – Oct 5, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext3/xattr_seciruty.c: local functions should be static

Quiets the sparse noise:

warning: symbol 'ext3_initxattrs' was not declared. Should it be static?

Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>

---

fs/ext3/xattr_security.c +1 -1
index 3c218b8..3f065f8 100644
@@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
 			      name, value, size, flags);
 }
 
-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
 		    void *fs_info)
 {
 	const struct xattr *xattr;
#1 lore raw
Quoted 8 lines · H Hartley Sweeten

Quiets the sparse noise:

warning: symbol 'ext3_initxattrs' was not declared. Should it be static?

Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>

Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.

Honza

Quoted 16 lines

---

fs/ext3/xattr_security.c +1 -1
index 3c218b8..3f065f8 100644
@@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
 			      name, value, size, flags);
 }
 
-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
 		    void *fs_info)
 {
 	const struct xattr *xattr;
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#2 lore raw
Quoted 11 lines · Jan Kara
Quoted 8 lines · H Hartley Sweeten

Quiets the sparse noise:

warning: symbol 'ext3_initxattrs' was not declared. Should it be static?

Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>

Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.

These are in linux-next due to:

commit 9d8f13ba3f4833219e50767b022b82cd0da930eb

Author: Mimi Zohar <[email protected]>
Date:   Mon Jun 6 15:29:25 2011 -0400

security: new security_inode_init_security API adds function callback

I can repost these after this commit hits Linus' kernel if necessary.

Thanks,
Hartley

#3 lore raw
Quoted 15 lines · H Hartley Sweeten
Quoted 11 lines · Jan Kara
Quoted 8 lines · H Hartley Sweeten

Quiets the sparse noise:

warning: symbol 'ext3_initxattrs' was not declared. Should it be static?

Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>

Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.

These are in linux-next due to:

Quoted 7 lines

commit 9d8f13ba3f4833219e50767b022b82cd0da930eb

Author: Mimi Zohar <[email protected]>
Date:   Mon Jun 6 15:29:25 2011 -0400

security: new security_inode_init_security API adds function callback

I can repost these after this commit hits Linus' kernel if necessary.

I see. OK, please repost when they hit Linus' kernel since I guess it's
not urgent to merge these.

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR