arm: add ide initialization

PATCH New Michael Walle 3 participants 5 messages Oct 6, 2011 – Oct 18, 2011 Arm (32-bit)

lore

Share & tools

lore

Michael Walle

author

2011-10-06 22:23 UTC #0 lore raw

PATCH 1/1 arm: add ide initialization

Call ide_init() in the board initialization if IDE support is compiled in.

Signed-off-by Michael Walle <[email protected]>

---
 arch/arm/lib/board.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

arch/arm/lib/board.c +5 -0

index 705d4d2..9addab8 100644
@@ -596,6 +596,11 @@ void board_init_r(gd_t *id, ulong dest_addr)
 #endif
 #endif
 
+#if defined(CONFIG_CMD_IDE)
+	puts ("IDE:   ");
+	ide_init ();
+#endif
+
 #ifdef CONFIG_POST
 	post_run(NULL, POST_RAM | post_bootmode_get(0));
 #endif

Signature · 1 line

1.7.2.5

Mike Frysinger

NAK

2011-10-07 17:27 UTC #1 lore raw

PATCH 1/1 arm: add ide initialization

arch/arm/lib/board.c void board_init_r(gd_t *id, ulong dest_addr) · line 602

Quoted 7 lines · On Thursday 06 October 2011 18:23:06 Michael Walle wrote:

arch/arm/lib/board.c +4 -0

 
+#if defined(CONFIG_CMD_IDE)
+	puts ("IDE:   ");
+	ide_init ();
+#endif

NAK: no space before that open paren
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111007/cccbb489/attachment.pgp

Michael Walle

author

2011-10-07 21:50 UTC #2 lore raw

PATCH 1/1 arm: add ide initialization

Am Freitag 07 Oktober 2011, 19:27:11 schrieb Mike Frysinger:

Quoted 11 lines · On Thursday 06 October 2011 18:23:06 Michael Walle wrote:

arch/arm/lib/board.c void board_init_r(gd_t *id, ulong dest_addr) · line 602
Quoted 7 lines
arch/arm/lib/board.c +4 -0
 
+#if defined(CONFIG_CMD_IDE)
+	puts ("IDE:   ");
+	ide_init ();
+#endif
NAK: no space before that open paren
-mike

as long as the style is the only objection, i'm glad to resend a fixed patch :)

Albert, are there any other objections?

Signature · 1 line

Michael

Albert ARIBAUD

NAK

2011-10-18 21:42 UTC #3 lore raw

PATCH 1/1 arm: add ide initialization

Hi Michael,

Le 07/10/2011 23:50, Michael Walle a ?crit :

Quoted 13 lines

Am Freitag 07 Oktober 2011, 19:27:11 schrieb Mike Frysinger:
Quoted 11 lines · On Thursday 06 October 2011 18:23:06 Michael Walle wrote:
arch/arm/lib/board.c void board_init_r(gd_t *id, ulong dest_addr) · line 602
Quoted 7 lines
arch/arm/lib/board.c +4 -0
 
+#if defined(CONFIG_CMD_IDE)
+	puts ("IDE:   ");
+	ide_init ();
+#endif
NAK: no space before that open paren
-mike

Quoted 4 lines

as long as the style is the only objection, i'm glad to resend a fixed patch :)
Albert, are there any other objections?

NAK: the fact that some board has an IDE interface does not mean it must initialize it in all boot cases; and the rule with devices in U-Boot is 'turn it on *only* when you're about to use it'.

Boards that always want to initialize IDE on boot can and will do so by putting 'ide reset' first in their bootcmd environment variable.

Amicalement,

Signature · 1 line

Albert.

Mike Frysinger

2011-10-18 22:19 UTC #4 lore raw

PATCH 1/1 arm: add ide initialization

Quoted 18 lines · On Tuesday 18 October 2011 17:42:26 Albert ARIBAUD wrote:

Le 07/10/2011 23:50, Michael Walle a ?crit :
Quoted 17 lines
Am Freitag 07 Oktober 2011, 19:27:11 schrieb Mike Frysinger:
Quoted 10 lines · On Thursday 06 October 2011 18:23:06 Michael Walle wrote:
arch/arm/lib/board.c void board_init_r(gd_t *id, ulong dest_addr) · line 602
Quoted 7 lines
arch/arm/lib/board.c +4 -0
 
+#if defined(CONFIG_CMD_IDE)
+	puts ("IDE:   ");
+	ide_init ();
+#endif
NAK: no space before that open paren
as long as the style is the only objection, i'm glad to resend a fixed patch
:)

Quoted 8 lines

Quoted 1 line
Albert, are there any other objections?
NAK: the fact that some board has an IDE interface does not mean it must initialize it in all boot cases; and the rule with devices in U-Boot is 'turn it on *only* when you're about to use it'.
Boards that always want to initialize IDE on boot can and will do so by putting 'ide reset' first in their bootcmd environment variable.

ACK to this. would be nice to get existing ports (ppc/m68k/sh/sparc/x86) to migrate their users to "ide reset" too ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111018/719d932c/attachment.pgp