Skip to contentSkip to conversation

fix unused variable warning

PATCH In review Daniel Walter 2 participants 2 messages Oct 10, 2011 – Oct 17, 2011 Thermal

lore
Share & tools
lore

Daniel Walter

author
#0 lore raw

PATCH 1/1 fix unused variable warning

[thermal] fix unused variable warning

thermal_event_seqnum is only used if CONFIG_NET is defined.

Signed-off-by Daniel Walter <[email protected]>
---
 drivers/thermal/thermal_sys.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

---

drivers/thermal/thermal_sys.c +2 -0
index 708f8e9..def02da 100644
@@ -60,7 +60,9 @@ static LIST_HEAD(thermal_tz_list);
 static LIST_HEAD(thermal_cdev_list);
 static DEFINE_MUTEX(thermal_list_lock);
 
+#ifdef CONFIG_NET
 static unsigned int thermal_event_seqnum;
+#endif /* CONFIG_NET */
 
 static int get_idr(struct idr *idr, struct mutex *lock, int *id)
 {
#1 lore raw

Hi Daniel,

Quoted 14 lines · Daniel Walter

[thermal] fix unused variable warning

thermal_event_seqnum is only used if CONFIG_NET is defined.

Signed-off-by Daniel Walter <[email protected]>

---
 drivers/thermal/thermal_sys.c |    2 ++

 1 files changed, 2 insertions(+), 0 deletions(-)

---

drivers/thermal/thermal_sys.c +0 -0
index 708f8e9..def02da 100644

drivers/thermal/thermal_sys.c static LIST_HEAD(thermal_tz_list); · line 66

Quoted 7 lines
drivers/thermal/thermal_sys.c +2 -0
@@ -60,7 +60,9 @@ static LIST_HEAD(thermal_tz_list);
  static LIST_HEAD(thermal_cdev_list);
  static DEFINE_MUTEX(thermal_list_lock);
 
+#ifdef CONFIG_NET
  static unsigned int thermal_event_seqnum;
+#endif /* CONFIG_NET */

I think, it would be nice to move thermal_event_seqnum under CONFIG_NET defined section, instead of wrapping with CONFIG_NET. Although your fix is okay but moving under CONFIG_NET would be nicer. Something like below:

---

drivers/thermal/thermal_sys.c +0 -2
index 708f8e9..b88c6ba 100644
@@ -60,8 +60,6 @@ static LIST_HEAD(thermal_tz_list);
 static LIST_HEAD(thermal_cdev_list);
 static DEFINE_MUTEX(thermal_list_lock);
 
-static unsigned int thermal_event_seqnum;
-
 static int get_idr(struct idr *idr, struct mutex *lock, int *id)
 {
        int err;

@@ -1293,6 +1291,8 @@ void thermal_zone_device_unregister(struct

thermal_zone_device *tz)
EXPORT_SYMBOL(thermal_zone_device_unregister);

#ifdef CONFIG_NET
+static unsigned int thermal_event_seqnum;
+
static struct genl_family thermal_event_genl_family = {
.id = GENL_ID_GENERATE,
.name = THERMAL_GENL_FAMILY_NAME,

Thanks,
Rakib