Skip to contentSkip to conversation

add package tango-icon-theme and dependency icon-naming-utils

PATCH New Klaus Schwarzkopf 2 participants 8 messages Oct 10, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add package tango-icon-theme and dependency icon-naming-utils

---
 package/Config.in                              |    1 +
 package/icon-naming-utils/icon-naming-utils.mk |   11 +++++++++++
 package/tango-icon-theme/Config.in             |    6 ++++++
 package/tango-icon-theme/tango-icon-theme.mk   |   15 +++++++++++++++
 4 files changed, 33 insertions(+), 0 deletions(-)
 create mode 100644 package/icon-naming-utils/icon-naming-utils.mk
 create mode 100644 package/tango-icon-theme/Config.in
 create mode 100644 package/tango-icon-theme/tango-icon-theme.mk
package/Config.in +1 -0
index 7112e05..4516fb9 100644
@@ -114,6 +114,7 @@ source "package/sdl_sound/Config.in"
 source "package/sdl_net/Config.in"
 source "package/sdl_ttf/Config.in"
 source "package/sdl_gfx/Config.in"
+source "package/tango-icon-theme/Config.in"
 
 comment "other GUIs"
 source "package/qt/Config.in"
package/icon-naming-utils/icon-naming-utils.mk new file +11 -0
new file mode 100644
index 0000000..556b826
@@ -0,0 +1,11 @@
+#############################################################
+#
+# icon-naming-utils
+#
+#############################################################
+ICON_NAMING_UTILS_VERSION = 0.8.90
+ICON_NAMING_UTILS_SOURCE = icon-naming-utils-$(ICON_NAMING_UTILS_VERSION).tar.gz
+ICON_NAMING_UTILS_SITE = http://tango.freedesktop.org/releases/
+HOST_ICON_NAMING_UTILS_CONF_OPT = --datarootdir=$(HOST_DIR)/usr/lib
+
+$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))
package/tango-icon-theme/Config.in new file +6 -0
new file mode 100644
index 0000000..cf20e9b
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_TANGO_ICON_THEME
+	bool "tango icon theme"
+	help
+	  Icons from the tango desktop project.
+
+	  http://tango.freedesktop.org/Tango_Desktop_Project
package/tango-icon-theme/tango-icon-theme.mk new file +15 -0
new file mode 100644
index 0000000..ed5a8b2
@@ -0,0 +1,15 @@
+#############################################################
+#
+# tango-icon-theme
+#
+#############################################################
+TANGO_ICON_THEME_VERSION = 0.8.90
+TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
+TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
+
+TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
+TANGO_ICON_THEME_CONF_OPT = --disable-icon-framing
+
+TANGO_ICON_THEME_DEPENDENCIES = host-icon-naming-utils host-pkg-config
+
+$(eval $(call AUTOTARGETS,package,tango-icon-theme))
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 add package tango-icon-theme and dependency icon-naming-utils

Hello Klaus,

Le Mon, 10 Oct 2011 15:31:36 +0200,
Klaus Schwarzkopf <[email protected]> a ?crit :

Quoted 6 lines
---
 package/Config.in                              |    1 +
 package/icon-naming-utils/icon-naming-utils.mk |   11 +++++++++++
 package/tango-icon-theme/Config.in             |    6 ++++++
 package/tango-icon-theme/tango-icon-theme.mk   |   15 +++++++++++++++

We usually have one patch per new package.

Quoted 1 line

+$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))

This should be:

$(eval $(call AUTOTARGETS))

in the Git version of Buildroot. The documentation has not yet been updated in that regard.

package/tango-icon-theme/tango-icon-theme.mk line 10

Quoted 5 lines
package/tango-icon-theme/tango-icon-theme.mk new file +5 -0
+TANGO_ICON_THEME_VERSION = 0.8.90
+TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
+TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
+
+TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig

Here you're going to build a target package (tango-icon-theme) based on library informations of the host. This looks wrong. pkg-config already looks in $(STAGING_DIR)/usr/lib/pkgconfig.

Could you detail why this is needed ?

Quoted 1 line

+$(eval $(call AUTOTARGETS,package,tango-icon-theme))

$(eval $(call AUTOTARGETS))

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 add package tango-icon-theme and dependency icon-naming-utils

Am 10.10.2011 16:10, schrieb Thomas Petazzoni:

Quoted 5 lines

Hello Klaus,

Le Mon, 10 Oct 2011 15:31:36 +0200,
Klaus Schwarzkopf<[email protected]> a ?crit :

Quoted 9 lines
Quoted 6 lines
---
  package/Config.in                              |    1 +
  package/icon-naming-utils/icon-naming-utils.mk |   11 +++++++++++
  package/tango-icon-theme/Config.in             |    6 ++++++
  package/tango-icon-theme/tango-icon-theme.mk   |   15 +++++++++++++++

We usually have one patch per new package.

The icon-naming-utils is a helper package, only for the tango-icon-theme. The program generates the right names and make links in the target filesystem.

Quoted 9 lines
Quoted 1 line

+$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))

This should be:

$(eval $(call AUTOTARGETS))

in the Git version of Buildroot. The documentation has not yet been updated in that regard.

OK

Quoted 11 lines

package/tango-icon-theme/tango-icon-theme.mk line 10

Quoted 5 lines
package/tango-icon-theme/tango-icon-theme.mk new file +5 -0
+TANGO_ICON_THEME_VERSION = 0.8.90
+TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
+TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
+
+TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig

Here you're going to build a target package (tango-icon-theme) based on library informations of the host. This looks wrong. pkg-config already looks in $(STAGING_DIR)/usr/lib/pkgconfig.

Could you detail why this is needed ?

The icon-naming-utils only need for the host, so tango-icon-theme can not find the utils. Have you an better idea?

Quoted 5 lines
Quoted 2 lines

+$(eval $(call AUTOTARGETS,package,tango-icon-theme))

$(eval $(call AUTOTARGETS))

OK

Quoted 3 lines

Regards,

Thomas

Regards,

Klaus

#3 lore raw

PATCH 1/1 add package tango-icon-theme and dependency icon-naming-utils

In reply to Thomas Petazzoni

Hello Thomas,

if made the changes, and test it with the latest git tree. But i get an error:

Quoted 1 line
Quoted 1 line
Quoted 1 line

tango-icon-theme 0.8.90 Extracting

gzip -d -c /home/klaus/ti-dvsdk_dm365/buildroot/dl/tango-icon-theme-0.8.90.tar.gz | tar --strip-components=1 -C /home/klaus/ti-dvsdk_dm365/buildroot/output/build/tango-icon-theme-0.8.90 -xf -

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

tango-icon-theme 0.8.90 Patching package//tango-icon-theme tango-icon-theme 0.8.90 Updating config.sub and config.guess

for file in config.guess config.sub; do for i in $(find /home/klaus/ti-dvsdk_dm365/buildroot/output/build/tango-icon-theme-0.8.90 -name $file); do cp support/gnuconfig/$file $i; done; done

Quoted 1 line
Quoted 1 line
Quoted 1 line

tango-icon-theme 0.8.90 Patching libtool

make: *** No rule to make target host-icon-naming-utils', needed by tango-icon-theme-depends'. Stop.

Can you help?

Regards,

Klaus

Am 10.10.2011 16:10, schrieb Thomas Petazzoni:

Quoted 42 lines

Hello Klaus,

Le Mon, 10 Oct 2011 15:31:36 +0200,
Klaus Schwarzkopf<[email protected]> a ?crit :

Quoted 6 lines
---
  package/Config.in                              |    1 +
  package/icon-naming-utils/icon-naming-utils.mk |   11 +++++++++++
  package/tango-icon-theme/Config.in             |    6 ++++++
  package/tango-icon-theme/tango-icon-theme.mk   |   15 +++++++++++++++

We usually have one patch per new package.

Quoted 1 line

+$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))

This should be:

$(eval $(call AUTOTARGETS))

in the Git version of Buildroot. The documentation has not yet been updated in that regard.

package/tango-icon-theme/tango-icon-theme.mk line 10

Quoted 5 lines
package/tango-icon-theme/tango-icon-theme.mk new file +5 -0
+TANGO_ICON_THEME_VERSION = 0.8.90
+TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
+TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
+
+TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig

Here you're going to build a target package (tango-icon-theme) based on library informations of the host. This looks wrong. pkg-config already looks in $(STAGING_DIR)/usr/lib/pkgconfig.

Could you detail why this is needed ?

Quoted 1 line

+$(eval $(call AUTOTARGETS,package,tango-icon-theme))

$(eval $(call AUTOTARGETS))

Regards,

Thomas

#4 lore raw

PATCH 1/1 add package tango-icon-theme and dependency icon-naming-utils

Le Mon, 10 Oct 2011 19:32:13 +0200,
Klaus Schwarzkopf <[email protected]> a ?crit :

Quoted 4 lines

make: *** No rule to make target host-icon-naming-utils', needed by tango-icon-theme-depends'. Stop.

Can you help?

Yes, see below.

Quoted 7 lines
Quoted 7 lines

We usually have one patch per new package.

Quoted 1 line

+$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))

This should be:

$(eval $(call AUTOTARGETS))

I should have said:

$(eval $(call AUTOTARGETS,host))

i.e, only the second and third argument have been removed. The optional fourth argument, which says whether we instantiate a host or target package, remains. Its default value is "target", so with just $(eval $(call AUTOTARGETS)) you create a target package and not the host package.

Sorry for the mistake.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 1/1 add package tango-icon-theme and dependency icon-naming-utils

Hi Thomas,

thanks very much.

Regards,

Klaus

Am 10.10.2011 19:38, schrieb Thomas Petazzoni:

Quoted 31 lines

Le Mon, 10 Oct 2011 19:32:13 +0200,
Klaus Schwarzkopf<[email protected]> a ?crit :

Quoted 4 lines

make: *** No rule to make target host-icon-naming-utils', needed by tango-icon-theme-depends'. Stop.

Can you help?

Yes, see below.

Quoted 7 lines
Quoted 7 lines

We usually have one patch per new package.

Quoted 1 line

+$(eval $(call AUTOTARGETS,package,icon-naming-utils,host))

This should be:

$(eval $(call AUTOTARGETS))

I should have said:

$(eval $(call AUTOTARGETS,host))

i.e, only the second and third argument have been removed. The optional fourth argument, which says whether we instantiate a host or target package, remains. Its default value is "target", so with just $(eval $(call AUTOTARGETS)) you create a target package and not the host package.

Sorry for the mistake.

Thomas

#6 lore raw

PATCH v2 1/2 add package tango-icon-theme

In reply to Klaus Schwarzkopf

This package need icon-naming-utils.

---
 package/Config.in                            |    1 +
 package/tango-icon-theme/Config.in           |    6 ++++++
 package/tango-icon-theme/tango-icon-theme.mk |   15 +++++++++++++++
 3 files changed, 22 insertions(+), 0 deletions(-)
 create mode 100644 package/tango-icon-theme/Config.in
 create mode 100644 package/tango-icon-theme/tango-icon-theme.mk
package/Config.in +1 -0
index 7dc8887..1cc953c 100644
@@ -115,6 +115,7 @@ source "package/sdl_sound/Config.in"
 source "package/sdl_net/Config.in"
 source "package/sdl_ttf/Config.in"
 source "package/sdl_gfx/Config.in"
+source "package/tango-icon-theme/Config.in"
 
 comment "other GUIs"
 source "package/qt/Config.in"
package/tango-icon-theme/Config.in new file +6 -0
new file mode 100644
index 0000000..cf20e9b
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_TANGO_ICON_THEME
+	bool "tango icon theme"
+	help
+	  Icons from the tango desktop project.
+
+	  http://tango.freedesktop.org/Tango_Desktop_Project
package/tango-icon-theme/tango-icon-theme.mk new file +15 -0
new file mode 100644
index 0000000..2c1a5a5
@@ -0,0 +1,15 @@
+#############################################################
+#
+# tango-icon-theme
+#
+#############################################################
+TANGO_ICON_THEME_VERSION = 0.8.90
+TANGO_ICON_THEME_SOURCE = tango-icon-theme-$(TANGO_ICON_THEME_VERSION).tar.gz
+TANGO_ICON_THEME_SITE = http://tango.freedesktop.org/releases/
+
+TANGO_ICON_THEME_CONF_ENV = PKG_CONFIG_PATH=$(HOST_DIR)/usr/lib/pkgconfig
+TANGO_ICON_THEME_CONF_OPT = --disable-icon-framing
+
+TANGO_ICON_THEME_DEPENDENCIES = host-icon-naming-utils host-pkg-config
+
+$(eval $(call AUTOTARGETS))
Signature · 1 line
1.7.0.4
#7 lore raw

PATCH v2 2/2 icon-naming-utils for tango-icon-theme

In reply to Klaus Schwarzkopf
---
 package/icon-naming-utils/icon-naming-utils.mk |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
 create mode 100644 package/icon-naming-utils/icon-naming-utils.mk
package/icon-naming-utils/icon-naming-utils.mk new file +11 -0
new file mode 100644
index 0000000..1ac359a
@@ -0,0 +1,11 @@
+#############################################################
+#
+# icon-naming-utils
+#
+#############################################################
+ICON_NAMING_UTILS_VERSION = 0.8.90
+ICON_NAMING_UTILS_SOURCE = icon-naming-utils-$(ICON_NAMING_UTILS_VERSION).tar.gz
+ICON_NAMING_UTILS_SITE = http://tango.freedesktop.org/releases/
+HOST_ICON_NAMING_UTILS_CONF_OPT = --datarootdir=$(HOST_DIR)/usr/lib
+
+$(eval $(call AUTOTARGETS,host))
Signature · 1 line
1.7.0.4