ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size

PATCH Superseded Thomas Weber 3 participants 3 messages Oct 12, 2011 Arm (32-bit)

lore

Share & tools

lore

Thomas Weber

author

2011-10-12 11:33 UTC #0 lore raw

PATCH 1/1 ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size

Use $(CROSS_COMPILE)size to determine the bss size from vmlinux.

The problem is introduced in:
commit 8738646c02064d38f6fb056eb039ebf9138c5434

ARM: zImage: make sure appended DTB doesn't get
overwritten by kernel .bss

This fixes following error message:

size: arch/arm/boot/compressed/../../../../vmlinux:
File format is ambiguous

size: Matching formats:
elf32-littlearm
elf32-littlearm-symbian
elf32-littlearm-vxworks

Signed-off-by Thomas Weber <[email protected]>

---
 arch/arm/boot/compressed/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/arm/boot/compressed/Makefile +1 -1

index e4f32a8..3103632 100644
@@ -126,7 +126,7 @@ ccflags-y := -fpic -fno-builtin -I$(obj)
 asflags-y := -Wa,-march=all
 
 # Supply kernel BSS size to the decompressor via a linker symbol.
-KBSS_SZ = $(shell size $(obj)/../../../../vmlinux | awk 'END{print $$3}')
+KBSS_SZ = $(shell $(CROSS_COMPILE)size $(obj)/../../../../vmlinux | awk 'END{print $$3}')
 LDFLAGS_vmlinux = --defsym _kernel_bss_size=$(KBSS_SZ)
 # Supply ZRELADDR to the decompressor via a linker symbol.
 ifneq ($(CONFIG_AUTO_ZRELADDR),y)

Signature · 1 line

1.7.7

Nicolas Pitre

2011-10-12 14:37 UTC #1 lore raw

PATCH 1/1 ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size

Quoted 14 lines · Thomas Weber

Use $(CROSS_COMPILE)size to determine the bss size from vmlinux.
The problem is introduced in:
commit 8738646c02064d38f6fb056eb039ebf9138c5434
ARM: zImage: make sure appended DTB doesn't get
overwritten by kernel .bss
This fixes following error message:
size: arch/arm/boot/compressed/../../../../vmlinux:
File format is ambiguous

Quoted 6 lines

size: Matching formats:
elf32-littlearm
elf32-littlearm-symbian
elf32-littlearm-vxworks
Signed-off-by Thomas Weber <[email protected]>

Acked-by Nicolas Pitre <[email protected]>

However I don't know where you picked up a reference to commit 8738646c02 which is nonexistent in any of my repositories. The right reference from RMK's devel-stable branch would be commit 5ffb04f669. Please fix that and send to the patch system.

Nicolas

Tony Lindgren

2011-10-12 21:10 UTC #2 lore raw

PATCH 1/1 ARM: zImage: Use $(CROSS_COMPILE)size to get .bss size

Quoted 16 lines · Nicolas Pitre

Quoted 14 lines · Thomas Weber
Use $(CROSS_COMPILE)size to determine the bss size from vmlinux.
The problem is introduced in:
commit 8738646c02064d38f6fb056eb039ebf9138c5434
ARM: zImage: make sure appended DTB doesn't get
overwritten by kernel .bss
This fixes following error message:
size: arch/arm/boot/compressed/../../../../vmlinux:
File format is ambiguous

Quoted 8 lines

Quoted 6 lines
size: Matching formats:
elf32-littlearm
elf32-littlearm-symbian
elf32-littlearm-vxworks
Signed-off-by Thomas Weber <[email protected]>
Acked-by Nicolas Pitre <[email protected]>

Acked-by Tony Lindgren <[email protected]>