libata: ata_timing_compute() fixup

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 2 messages Oct 13, 2011 libata

lore

Share & tools

lore

Bartlomiej Zolnierkiewicz

author

2011-10-13 13:17 UTC #0 lore raw

PATCH 1/1 libata: ata_timing_compute() fixup

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] libata: ata_timing_compute() fixup

XFER_SW_DMA_0 mode should be excluded from the extended cycle timing computations.

Noticed-by Sergei Shtylyov <[email protected]>

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
 drivers/ata/libata-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/ata/libata-core.c +1 -1

Index: b/drivers/ata/libata-core.c
===================================================================
@@ -3232,7 +3232,7 @@ int ata_timing_compute(struct ata_device
 	if (id[ATA_ID_FIELD_VALID] & 2) {	/* EIDE drive */
 		memset(&p, 0, sizeof(p));
 
-		if (speed >= XFER_PIO_0 && speed <= XFER_SW_DMA_0) {
+		if (speed >= XFER_PIO_0 && speed < XFER_SW_DMA_0) {
 			if (speed <= XFER_PIO_2)
 				p.cycle = p.cyc8b = id[ATA_ID_EIDE_PIO];
 			else if ((speed <= XFER_PIO_4) ||

Alan Cox

Acked-by on v1 1/1

2011-10-13 15:56 UTC #1 lore raw

Quoted 5 lines · On Thu, 13 Oct 2011 15:17:32 +0200 Bartlomiej Zolnierkiewicz…

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] libata: ata_timing_compute() fixup
XFER_SW_DMA_0 mode should be excluded from the extended cycle timing computations.

We don't support SWDMA but yes that is a bug

Acked-by Alan Cox <[email protected]>