pata_oldpiix: enable parallel scan

PATCH In review Bartlomiej Zolnierkiewicz 2 participants 4 messages Oct 13, 2011 libata

lore

Share & tools

lore

Bartlomiej Zolnierkiewicz

author

2011-10-13 14:03 UTC #0 lore raw

PATCH 2/2 pata_oldpiix: enable parallel scan

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] pata_oldpiix: enable parallel scan

Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

---
earlier references:
https://lkml.org/lkml/2011/2/8/111
https://lkml.org/lkml/2010/2/18/275

 drivers/ata/pata_oldpiix.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/ata/pata_oldpiix.c +2 -1

Index: b/drivers/ata/pata_oldpiix.c
===================================================================
@@ -258,7 +258,8 @@ static int oldpiix_init_one (struct pci_
 
 	ata_print_version_once(&pdev->dev, DRV_VERSION);
 
-	return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL, 0);
+	return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL,
+				      ATA_HOST_PARALLEL_SCAN);
 }
 
 static const struct pci_device_id oldpiix_pci_tbl[] = {

Alan Cox

2011-10-13 15:49 UTC #1 lore raw

Quoted 4 lines · On Thu, 13 Oct 2011 16:03:34 +0200 Bartlomiej Zolnierkiewicz…

From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] pata_oldpiix: enable parallel scan
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

Have you tested this. When I talked with Intel people about parallel scanning nobody in Intel I could find could answer whether it was safe on the ancient PIIX versions.

Bartlomiej Zolnierkiewicz

author

2011-10-13 16:10 UTC #2 lore raw

Quoted 11 lines · Alan Cox

Quoted 4 lines · On Thu, 13 Oct 2011 16:03:34 +0200 Bartlomiej Zolnierkiewicz…
From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] pata_oldpiix: enable parallel scan
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>
Have you tested this. When I talked with Intel people about parallel scanning nobody in Intel I could find could answer whether it was safe on the ancient PIIX versions.

No, it wasn't tested on the real hardware.

I think it should be in libata-dev or -mm/-next for rather long time..

Alan Cox

2011-10-13 19:12 UTC #3 lore raw

Quoted 10 lines · On Thu, 13 Oct 2011 18:06:08 +0200 Bartlomiej Zolnierkiewicz…

Quoted 8 lines · Alan Cox
Quoted 4 lines · On Thu, 13 Oct 2011 16:03:34 +0200 Bartlomiej Zolnierkiewicz…
From: Bartlomiej Zolnierkiewicz <[email protected]>
Subject: [PATCH] pata_oldpiix: enable parallel scan
Signed-off-by Bartlomiej Zolnierkiewicz <[email protected]>

Quoted 7 lines

Quoted 3 lines
Have you tested this. When I talked with Intel people about parallel scanning nobody in Intel I could find could answer whether it was safe on the ancient PIIX versions.
No, it wasn't tested on the real hardware.
I think it should be in libata-dev or -mm/-next for rather long time..

I don't see it's worth adding, its near impossible to test and its for old hardware that doesn't fast boot anyway. Really it's the netbook generation devices where this matters.