New package: ImLib2

PATCH Superseded yegorslists at googlemail.com 4 participants 14 messages Oct 11, 2011 – Oct 14, 2011

lore

Share & tools

lore

yegorslists at googlemail.com

author

2011-10-11 10:26 UTC #0 lore raw

PATCH v2 1/1 New package: ImLib2

From: Yegor Yefremov <[email protected]>

Signed-off-by Frederic Bassaler <[email protected]>

Signed-off-by Matias Garcia <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes v2: add libXext dependency

 package/Config.in        |    1 +
 package/imlib2/Config.in |   38 +++++++++++++++++++++++++++++
 package/imlib2/imlib2.mk |   60 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 99 insertions(+), 0 deletions(-)
 create mode 100644 package/imlib2/Config.in
 create mode 100644 package/imlib2/imlib2.mk

package/Config.in +1 -0

index 7dc8887..7a7b4bf 100644
@@ -282,6 +282,7 @@ source "package/fontconfig/Config.in"
 source "package/freetype/Config.in"
 source "package/gtk2-engines/Config.in"
 source "package/gtk2-themes/Config.in"
+source "package/imlib2/Config.in"
 source "package/jpeg/Config.in"
 source "package/libart/Config.in"
 source "package/libdrm/Config.in"

package/imlib2/Config.in new file +38 -0

new file mode 100644
index 0000000..9b6ee98
@@ -0,0 +1,38 @@
+config BR2_PACKAGE_IMLIB2
+	bool "imlib2"
+	help
+	  Imlib 2 is the successor to Imlib.
+
+	  http://freshmeat.net/projects/imlib2/
+
+if BR2_PACKAGE_IMLIB2
+
+config BR2_PACKAGE_IMLIB2_JPEG
+	select BR2_PACKAGE_JPEG
+	bool "JPEG support"
+
+config BR2_PACKAGE_IMLIB2_PNG
+	select BR2_PACKAGE_LIBPNG
+	bool "PNG support"
+
+config BR2_PACKAGE_IMLIB2_GIF
+	select BR2_PACKAGE_LIBUNGIF
+	bool "GIF support"
+
+config BR2_PACKAGE_IMLIB2_TIFF
+	select BR2_PACKAGE_TIFF
+	bool "TIFF support"
+
+config BR2_PACKAGE_IMLIB2_FREETYPE
+	select BR2_PACKAGE_FREETYPE
+	bool "FreeType support"
+
+config BR2_PACKAGE_IMLIB2_ID3
+	select BR2_PACKAGE_LIBID3TAG
+	bool "ID3 support"
+
+config BR2_PACKAGE_IMLIB2_X
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	bool "X support"
+endif

package/imlib2/imlib2.mk new file +60 -0

60 lines not on this page · raw message

Signature · 1 line

1.7.1.1

Arnout Vandecappelle

2011-10-11 16:17 UTC #1 lore raw

PATCH v2 1/1 New package: ImLib2

On Tuesday 11 October 2011 12:26:10, yegorslists at googlemail.com wrote:
[snip]

package/imlib2/Config.in line 38

Quoted 5 lines

package/imlib2/Config.in new file +5 -0

+config BR2_PACKAGE_IMLIB2_X
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	bool "X support"
+endif

Shouldn't this depend on BR2_PACKAGE_XORG7 ?

[snip]

Regards,
Arnout

Signature · 9 lines

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111011/38cd0045/attachment-0001.html>

Yegor Yefremov

author

2011-10-12 09:18 UTC #2 lore raw

PATCH v2 1/1 New package: ImLib2

Quoted 9 lines · Arnout Vandecappelle

On Tuesday 11 October 2011 12:26:10, yegorslists at googlemail.com wrote:
[snip]
Quoted 3 lines
+config BR2_PACKAGE_IMLIB2_X
+ select BR2_PACKAGE_XLIB_LIBX11

Quoted 7 lines

Quoted 5 lines
+ select BR2_PACKAGE_XLIB_LIBXEXT
+ bool "X support"
+endif
Shouldn't this depend on BR2_PACKAGE_XORG7 ?

Thanks for reviewing. I checked these two packages_ libx11 and libxext and they seem to selected by xorg anyway, so I replaced them by dependency on BR2_PACKAGE_XORG7.

Yegor

Arnout Vandecappelle

2011-10-12 09:25 UTC #3 lore raw

PATCH v2 1/1 New package: ImLib2

Quoted 14 lines · Yegor Yefremov

Quoted 5 lines · Arnout Vandecappelle
On Tuesday 11 October 2011 12:26:10, yegorslists at googlemail.com wrote:
[snip]
Quoted 7 lines
package/imlib2/Config.in line 38
Quoted 5 lines
package/imlib2/Config.in new file +5 -0
+config BR2_PACKAGE_IMLIB2_X
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXEXT
+ bool "X support"
+endif
Shouldn't this depend on BR2_PACKAGE_XORG7 ?

Quoted 3 lines

Thanks for reviewing. I checked these two packages_ libx11 and libxext and they seem to selected by xorg anyway, so I replaced them by dependency on BR2_PACKAGE_XORG7.

libXext indeed selects libX11, but I don't see how libXext would be automatically selected...

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43

Yegor Yefremov

2011-10-12 09:32 UTC #4 lore raw

PATCH v2 1/1 New package: ImLib2

Am 12.10.2011 11:25, schrieb Arnout Vandecappelle:

Quoted 16 lines · Yegor Yefremov

Quoted 14 lines · Arnout Vandecappelle
Quoted 12 lines · yegorslists at googlemail.com
[snip]
package/imlib2/Config.in line 38
Quoted 5 lines
package/imlib2/Config.in new file +5 -0
+config BR2_PACKAGE_IMLIB2_X
+ select BR2_PACKAGE_XLIB_LIBX11
+ select BR2_PACKAGE_XLIB_LIBXEXT
+ bool "X support"
+endif
Shouldn't this depend on BR2_PACKAGE_XORG7 ?

Quoted 5 lines

Quoted 3 lines
Thanks for reviewing. I checked these two packages_ libx11 and libxext and they seem to selected by xorg anyway, so I replaced them by dependency on BR2_PACKAGE_XORG7.
libXext indeed selects libX11, but I don't see how libXext would be automatically selected...

What about BR2_PACKAGE_XSERVER_XORG_SERVER [=y] && BR2_PACKAGE_XORG7 [=y] && !BR2_avr32 [=n]?

Arnout Vandecappelle

2011-10-13 22:07 UTC #5 lore raw

PATCH v2 1/1 New package: ImLib2

Quoted 9 lines · Yegor Yefremov

Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Shouldn't this depend on BR2_PACKAGE_XORG7 ?
Thanks for reviewing. I checked these two packages_ libx11 and libxext and they seem to selected by xorg anyway, so I replaced them by dependency on BR2_PACKAGE_XORG7.
libXext indeed selects libX11, but I don't see how libXext would be automatically selected...
What about BR2_PACKAGE_XSERVER_XORG_SERVER [=y] && BR2_PACKAGE_XORG7 [=y] && !BR2_avr32 [=n]?

Yes, but you can usefully build ImLib2 without an Xserver. BR2_PACKAGE_XSERVER_XORG_SERVER does not get selected by BR2_PACKAGE_XORG7.

Regards,
Arnout

Signature · 9 lines

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111014/bb50d761/attachment.html>

Thomas Petazzoni

2011-10-12 09:40 UTC #6 lore raw

PATCH v2 1/1 New package: ImLib2

In reply to Yegor Yefremov

Le Wed, 12 Oct 2011 11:18:34 +0200,
Yegor Yefremov <[email protected]> a ?crit :

Quoted 3 lines

Thanks for reviewing. I checked these two packages_ libx11 and libxext and they seem to selected by xorg anyway, so I replaced them by dependency on BR2_PACKAGE_XORG7.

The dependencies on X.org are quite a mess these days. Maybe packages depend on xserver-xorg_server, while they should depend on the X11 libraries that they require.

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Yegor Yefremov

2011-10-12 09:44 UTC #7 lore raw

PATCH v2 1/1 New package: ImLib2

Am 12.10.2011 11:40, schrieb Thomas Petazzoni:

Quoted 10 lines

Le Wed, 12 Oct 2011 11:18:34 +0200,
Yegor Yefremov <[email protected]> a ?crit :
Quoted 3 lines
Thanks for reviewing. I checked these two packages_ libx11 and libxext and they seem to selected by xorg anyway, so I replaced them by dependency on BR2_PACKAGE_XORG7.
The dependencies on X.org are quite a mess these days. Maybe packages depend on xserver-xorg_server, while they should depend on the X11 libraries that they require.

O.K. BR2_PACKAGE_XSERVER_XORG_SERVER definitely specifies that libXext is to be selected.

Yegor

Thomas Petazzoni

2011-10-12 09:53 UTC #8 lore raw

PATCH v2 1/1 New package: ImLib2

Le Wed, 12 Oct 2011 11:44:46 +0200,
Yegor Yefremov <[email protected]> a ?crit :

Quoted 6 lines

Quoted 3 lines
The dependencies on X.org are quite a mess these days. Maybe packages depend on xserver-xorg_server, while they should depend on the X11 libraries that they require.
O.K. BR2_PACKAGE_XSERVER_XORG_SERVER definitely specifies that libXext is to be selected.

Yes, but technically speaking, all X11 client libraries and programs should *not* depend on the X.org server, but rather on the needed X11 libraries. For several reasons:

*) Because technically, the clients don't require the server to

    already be built ;

*) Because if one day, we manage to enable parallel building of

    packages, it is great to have correct dependencies ;

*) Because you can imagine a setup in which you build several X11
client libraries and programs, but not the X server, and the X applications display their windows to a remote X server, which is not built by Buildroot.

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Yegor Yefremov

2011-10-12 09:59 UTC #9 lore raw

PATCH v2 1/1 New package: ImLib2

Am 12.10.2011 11:53, schrieb Thomas Petazzoni:

Quoted 15 lines

Le Wed, 12 Oct 2011 11:44:46 +0200,
Yegor Yefremov <[email protected]> a ?crit :
Quoted 5 lines
Quoted 3 lines
The dependencies on X.org are quite a mess these days. Maybe packages depend on xserver-xorg_server, while they should depend on the X11 libraries that they require.
O.K. BR2_PACKAGE_XSERVER_XORG_SERVER definitely specifies that libXext is to be selected.
Yes, but technically speaking, all X11 client libraries and programs should *not* depend on the X.org server, but rather on the needed X11 libraries. For several reasons:
*) Because technically, the clients don't require the server to
    already be built ;

Quoted 7 lines

*) Because if one day, we manage to enable parallel building of
    packages, it is great to have correct dependencies ;
*) Because you can imagine a setup in which you build several X11
client libraries and programs, but not the X server, and the X applications display their windows to a remote X server, which is not built by Buildroot.

O.K. I make ImLib2 depend on libXext. Du to the fact, that libX11 is selected by libXext I don't need this additional dependency.

For feh I then make 2 dependencies:

BR2_PACKAGE_XLIB_LIBXINERAMA
BR2_PACKAGE_XLIB_LIBXT

Yegor

Arnout Vandecappelle

2011-10-13 22:09 UTC #10 lore raw

PATCH v2 1/1 New package: ImLib2

In reply to Thomas Petazzoni

Quoted 2 lines · Thomas Petazzoni

*) Because if one day, we manage to enable parallel building of
    packages, it is great to have correct dependencies ;

Actually that would only be for Makefile dependencies, not for Kconfig dependencies...

Regards,
Arnout

Signature · 9 lines

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111014/142f2e32/attachment.html>

Thomas Petazzoni

2011-10-14 06:36 UTC #11 lore raw

PATCH v2 1/1 New package: ImLib2

Le Fri, 14 Oct 2011 00:09:13 +0200,
Arnout Vandecappelle <[email protected]> a ?crit :

Quoted 2 lines

Actually that would only be for Makefile dependencies, not for
Kconfig dependencies...

True, but this is also wrong currently for Makefile dependencies:

cairo/cairo.mk: CAIRO_DEPENDENCIES += xserver_xorg-server docker/docker.mk:DOCKER_DEPENDENCIES = host-pkg-config libglib2 xserver_xorg-server fltk/fltk.mk:FLTK_DEPENDENCIES = xserver_xorg-server xlib_libXt games/rubix/rubix.mk:RUBIX_DEPENDENCIES = xserver_xorg-server

java/classpath/classpath.mk:    CLASSPATH_DEPENDENCIES+= xserver_xorg-server
java/jamvm/jamvm.mk:    JAMVM_DEPENDENCIES+= xserver_xorg-server
libgtk2/libgtk2.mk:     LIBGTK2_DEPENDENCIES += xlib_libXcomposite xserver_xorg-server

metacity/metacity.mk:METACITY_DEPENDENCIES = libgtk2 xserver_xorg-server
pango/pango.mk: PANGO_DEPENDENCIES += xserver_xorg-server pcmanfm/pcmanfm.mk:PCMANFM_DEPENDENCIES = host-pkg-config libgtk2 gamin startup-notification xserver_xorg-server sdl/sdl.mk:SDL_DEPENDENCIES += xserver_xorg-server
synergy/synergy.mk:SYNERGY_DEPENDENCIES = xserver_xorg-server xlib_libXtst torsmo/torsmo.mk:TORSMO_DEPENDENCIES = xserver_xorg-server
webkit/webkit.mk: WEBKIT_DEPENDENCIES += xserver_xorg-server xlib_libXt

I don't think any of these actually require the X.org server to be built.

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Yegor Yefremov

2011-10-14 07:51 UTC #12 lore raw

PATCH v2 1/1 New package: ImLib2

Am 14.10.2011 08:36, schrieb Thomas Petazzoni:

Quoted 23 lines

Le Fri, 14 Oct 2011 00:09:13 +0200,
Arnout Vandecappelle <[email protected]> a ?crit :
Quoted 2 lines
Actually that would only be for Makefile dependencies, not for
Kconfig dependencies...
True, but this is also wrong currently for Makefile dependencies:
cairo/cairo.mk: CAIRO_DEPENDENCIES += xserver_xorg-server docker/docker.mk:DOCKER_DEPENDENCIES = host-pkg-config libglib2 xserver_xorg-server fltk/fltk.mk:FLTK_DEPENDENCIES = xserver_xorg-server xlib_libXt games/rubix/rubix.mk:RUBIX_DEPENDENCIES = xserver_xorg-server
java/classpath/classpath.mk:    CLASSPATH_DEPENDENCIES+= xserver_xorg-server
java/jamvm/jamvm.mk:    JAMVM_DEPENDENCIES+= xserver_xorg-server
libgtk2/libgtk2.mk:     LIBGTK2_DEPENDENCIES += xlib_libXcomposite xserver_xorg-server
metacity/metacity.mk:METACITY_DEPENDENCIES = libgtk2 xserver_xorg-server
pango/pango.mk: PANGO_DEPENDENCIES += xserver_xorg-server pcmanfm/pcmanfm.mk:PCMANFM_DEPENDENCIES = host-pkg-config libgtk2 gamin startup-notification xserver_xorg-server sdl/sdl.mk:SDL_DEPENDENCIES += xserver_xorg-server
synergy/synergy.mk:SYNERGY_DEPENDENCIES = xserver_xorg-server xlib_libXtst torsmo/torsmo.mk:TORSMO_DEPENDENCIES = xserver_xorg-server
webkit/webkit.mk: WEBKIT_DEPENDENCIES += xserver_xorg-server xlib_libXt

Quoted 1 line

I don't think any of these actually require the X.org server to be built.

As far as I understand the dependencies should look like this:

for ImLib2

depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */ select BR2_PACKAGE_XLIB_LIBX11
select BR2_PACKAGE_XLIB_LIBXEXT

for feh

depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */ select BR2_PACKAGE_XLIB_LIBXINERAMA
select BR2_PACKAGE_XLIB_LIBXT

Do we agree on this scheme?

Yegor

Arnout Vandecappelle

2011-10-14 08:05 UTC #13 lore raw

PATCH v2 1/1 New package: ImLib2

Quoted 8 lines · Yegor Yefremov

As far as I understand the dependencies should look like this:
for ImLib2
depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */ select BR2_PACKAGE_XLIB_LIBX11
select BR2_PACKAGE_XLIB_LIBXEXT

Quoted 7 lines

for feh
depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */ select BR2_PACKAGE_XLIB_LIBXINERAMA
select BR2_PACKAGE_XLIB_LIBXT
Do we agree on this scheme?

I'm sorry, I have to correct myself again... In xlib_libXext.mk we can find

XLIB_LIBXEXT_DEPENDENCIES = xlib_libX11 xproto_xextproto xproto_xproto

Since ImLib2's configure doesn't need to be informed about libX11 directly, that dependency is redundant after all - both in Config.in and in imlib2.mk.

That said, it doesn't hurt to keep it.

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43