Skip to contentSkip to conversation

remote-curl.c: honor pushurl

BUG Michael Schubert 2 participants 2 messages Jun 15, 2016

lore
Share & tools
lore
#0 lore raw

When doing a push (fetch, ..) over http(s), git calls git-remote-http to communicate with the server.

git-remote-http <remote> [<url>]

Git correctly honors a configured pushurl and passes it to git-remote-http, but git-remote-http is initiating the http connection with the url defined for remote (remote->url) rather than the passed url. This undermines the purpose of a config like

url = https://example.com/repo.git
pushurl = https://[email protected]/repo.git

Introduced around 888692b7 - CC'ing Tay Ray Chuan. (I don't know if it was working before, though.)

#1 lore raw
Quoted 10 lines · Michael Schubert

When doing a push (fetch, ..) over http(s), git calls git-remote-http to communicate with the server.

git-remote-http <remote> [<url>]

Git correctly honors a configured pushurl and passes it to git-remote-http, but git-remote-http is initiating the http connection with the url defined for remote (remote->url) rather than the passed url. This undermines the purpose of a config like

Quoted 5 lines

url = https://example.com/repo.git
pushurl = https://[email protected]/repo.git

Introduced around 888692b7 - CC'ing Tay Ray Chuan. (I don't know if it was working before, though.)

Already noticed and fixed last week.

See this thread, starting at the focused message.

http://thread.gmane.org/gmane.comp.version-control.git/182752/focus=182872

-Peff