Skip to contentSkip to conversation

drm/i915: cleanup min_t() casting

PATCH New Dan Carpenter 1 participant 1 message Oct 18, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: cleanup min_t() casting

Casting "len" from uin32_t to uint8_t in min_t() truncates the upper bits. It doesn't matter in this case because "len" is never more than 0x1f, but Smatch warns about it, so let's change it.

drivers/gpu/drm/i915/intel_display.c +1 -1
index 8230cf5..65897be 100644
@@ -5702,7 +5702,7 @@ static void g4x_write_eld(struct drm_connector *connector,
 	if (!eld[0])
 		return;
 
-	len = min_t(uint8_t, eld[2], len);
+	len = min_t(uint32_t, eld[2], len);
 	DRM_DEBUG_DRIVER("ELD size %d\n", len);
 	for (i = 0; i < len; i++)
 		I915_WRITE(G4X_HDMIW_HDMIEDID, *((uint32_t *)eld + i));