debugX macro

U-Boot Marek Vasut 3 participants 5 messages Oct 23, 2011 – Oct 25, 2011

Share & tools

Marek Vasut

author

2011-10-23 14:46 UTC #0 lore raw

Hi,

I've been doing the debug() cleanup and found the debugX() macro is used only in very few patches. Maybe punting it altogether won't hurt.

The following do use it:
./board/spc1920/hpi.c
./drivers/mtd/nand/s3c2410_nand.c

Opinions?

Thanks, Cheers!

Wolfgang Denk

2011-10-23 17:23 UTC #1 lore raw

Dear Marek Vasut,

Quoted 9 lines · In message <[email protected]> you wrote:

I've been doing the debug() cleanup and found the debugX() macro is used only in very few patches. Maybe punting it altogether won't hurt.
The following do use it:
./board/spc1920/hpi.c
./drivers/mtd/nand/s3c2410_nand.c
Opinions?

Dump it!

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beware of programmers carrying screwdrivers."      - Chip Salzenberg

Marek Vasut

author

2011-10-23 20:46 UTC #2 lore raw

Quoted 6 lines · Wolfgang Denk

Dear Marek Vasut,
Quoted 3 lines · In message <[email protected]> you wrote:
I've been doing the debug() cleanup and found the debugX() macro is used only in very few patches. Maybe punting it altogether won't hurt.

Quoted 7 lines

Quoted 5 lines
The following do use it:
./board/spc1920/hpi.c
./drivers/mtd/nand/s3c2410_nand.c
Opinions?
Dump it!

Dumped on next iteration of the GCC4.6 cleanups!

Cheers

Joe Hershberger

2011-10-25 17:11 UTC #3 lore raw

In reply to Wolfgang Denk

Quoted 7 lines · Wolfgang Denk

Dear Marek Vasut,
Quoted 4 lines · In message <[email protected]> you wrote:
I've been doing the debug() cleanup and found the debugX() macro is used only in very few patches. Maybe punting it altogether won't hurt.

Quoted 7 lines

Quoted 5 lines
The following do use it:
./board/spc1920/hpi.c
./drivers/mtd/nand/s3c2410_nand.c
Opinions?
Dump it!

I'm working on a patch to rework the net subsystem and I find it quite useful for filtering debug traces to a manageable level. I think it should stay around.

Thanks
-Joe

Marek Vasut

author

2011-10-25 22:16 UTC #4 lore raw

Quoted 13 lines · Wolfgang Denk

Quoted 12 lines
Dear Marek Vasut,
Quoted 8 lines · In message <[email protected]> you wrote:
I've been doing the debug() cleanup and found the debugX() macro is used only in very few patches. Maybe punting it altogether won't hurt.
The following do use it:
./board/spc1920/hpi.c
./drivers/mtd/nand/s3c2410_nand.c
Opinions?

Quoted 8 lines

Quoted 1 line
Dump it!
I'm working on a patch to rework the net subsystem and I find it quite useful for filtering debug traces to a manageable level. I think it should stay around.
Thanks
-Joe

Hi Joe,

why can't you just reimplement it properly with your patchset ? Currently, all the uses of this macro in the tree are bogus so your code might be a good example.

Cheers