Skip to contentSkip to conversation

Switching ssb to read 8-bit quantities from SPROM

DISCUSSION Larry Finger 2 participants 2 messages Oct 26, 2011 – Oct 27, 2011

lore
Share & tools
lore
#0 lore raw

I tested the effects of changing ssb to read the SSPROM in 8-bit hunks rather than as 16-bit words in the manner that was just submitted for brcmsmac. Although this simplifies the calculation of the crc8, it only reduced the size of the module by 31 bytes, thus I will not be submitting the patch.

When the library version of the crc8 routine was used rather than the one built into ssb, the size of the driver was increased by 17 bytes.

Larry

#1 lore raw
Quoted 7 lines · On Wed, 26 Oct 2011 17:24:46 -0500 Larry Finger <[email protected]>…

I tested the effects of changing ssb to read the SSPROM in 8-bit hunks rather than as 16-bit words in the manner that was just submitted for brcmsmac. Although this simplifies the calculation of the crc8, it only reduced the size of the module by 31 bytes, thus I will not be submitting the patch.

When the library version of the crc8 routine was used rather than the one built into ssb, the size of the driver was increased by 17 bytes.

Well, if this doesn't cause regressions due to the changed reads, I'm OK with it (as in I don't really care either way).
But it has to be tested on b44, too.

Signature · 1 line
Greetings, Michael.