qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

DISCUSSION Lucas Meneghel Rodrigues 7 participants 16 messages Oct 26, 2011 – Nov 3, 2011 KVM

Share & tools

Lucas Meneghel Rodrigues

author

2011-10-26 14:41 UTC #0 lore raw

Hi folks:

We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:

commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8

Author: Richard Henderson <[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700

fdc: Convert to isa_register_portio_list

Signed-off-by Richard Henderson <[email protected]>

Signed-off-by Avi Kivity <[email protected]>

Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.

Cheers,

Lucas and Cleber

Kevin Wolf

2011-10-26 15:44 UTC #1 lore raw

Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:

Quoted 11 lines

Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson <[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list

Quoted 7 lines

Signed-off-by Richard Henderson <[email protected]>
Signed-off-by Avi Kivity <[email protected]>
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.

Can you please try again with the latest block branch? I think there is a patch queued that will fix it.

Kevin

Cleber Rosa

2011-10-26 16:30 UTC #2 lore raw

Quoted 15 lines · Kevin Wolf

Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 14 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>

Quoted 8 lines

Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin

Kevin,

The behaviour of the latest block branch is indeed different, but not much better.

In my quick manual test, booting via a FreeDOS floppy image:

* latest master: does not seem to read the floppy at all
* latest block: reads the floppy only to the point that 'FreeDOS' is printed in the console

All other qemu/qemu-kvm versions tested (for example 0.15.0), successfully read and boot the same image.

CR.

Lucas Meneghel Rodrigues

author

2011-10-26 17:19 UTC #3 lore raw

In reply to Kevin Wolf

Quoted 15 lines · Kevin Wolf

Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 14 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>

Quoted 7 lines

Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.

Kevin, I did try with HEAD of your repo:

git://repo.or.cz/qemu/kevin.git

[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master

With this repo, master branch, the problem persists. With the block branch, the problem persists.

Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.

Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.

Please merge the fixes with qemu master as soon as you can, we are probably leave windows installs from the upstream daily jobs until the fixes get to master.

Thanks,

Lucas

Stefan Hajnoczi

2011-10-27 08:10 UTC #4 lore raw

Quoted 46 lines · Lucas Meneghel Rodrigues

Quoted 15 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 14 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Quoted 7 lines
Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.

Quoted 7 lines

Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.

I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).

Stefan

Lucas Meneghel Rodrigues

author

2011-10-27 18:57 UTC #5 lore raw

Quoted 51 lines · Stefan Hajnoczi

Quoted 50 lines · Lucas Meneghel Rodrigues
Quoted 15 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 14 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Quoted 7 lines
Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.

Quoted 7 lines

Quoted 3 lines
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).

So no, the block branch does not resolve the floppy access problem.

Well, considering the tests of the stable set I'm running against qemu right now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.

Thanks Stefan!

Zhi Yong Wu

2011-10-28 01:17 UTC #6 lore raw

Quoted 64 lines · Lucas Meneghel Rodrigues

Quoted 55 lines · Stefan Hajnoczi
Quoted 53 lines · Lucas Meneghel Rodrigues
Quoted 17 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 15 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date: Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Quoted 7 lines
Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Quoted 7 lines
Quoted 3 lines
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).

Quoted 6 lines

So no, the block branch does not resolve the floppy access problem.
Well, considering the tests of the stable set I'm running against qemu right now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.

What is the OS of your guest? fedora16 or RHEL6? I would like recently to use floppy device in guest.

Quoted 7 lines

Thanks Stefan!
--
To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 3 lines

Regards,

Zhi Yong Wu

Lucas Meneghel Rodrigues

author

2011-10-28 02:20 UTC #7 lore raw

Quoted 66 lines · Zhi Yong Wu

Quoted 64 lines · Lucas Meneghel Rodrigues
Quoted 62 lines · Stefan Hajnoczi
Quoted 49 lines · Lucas Meneghel Rodrigues
Quoted 17 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 15 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Quoted 7 lines
Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Quoted 7 lines
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).

Quoted 8 lines

Quoted 6 lines
So no, the block branch does not resolve the floppy access problem.
Well, considering the tests of the stable set I'm running against qemu right now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.
What is the OS of your guest? fedora16 or RHEL6? I would like recently to use floppy device in guest.

Fedora 15.

Zhi Yong Wu

2011-10-28 10:24 UTC #8 lore raw

Quoted 80 lines · Lucas Meneghel Rodrigues

Quoted 79 lines · Zhi Yong Wu
Quoted 75 lines · Lucas Meneghel Rodrigues
Quoted 58 lines · Stefan Hajnoczi
Quoted 55 lines · Lucas Meneghel Rodrigues
Quoted 23 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 12 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date: Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Quoted 8 lines
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated
regression jobs), so please take a look at it.
Quoted 3 lines
Can you please try again with the latest block branch? I think there is
a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Quoted 7 lines
Quoted 3 lines
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).
So no, the block branch does not resolve the floppy access problem.
Well, considering the tests of the stable set I'm running against qemu right
now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.

Quoted 4 lines

Quoted 2 lines
What is the OS of your guest? fedora16 or RHEL6? I would like recently to use floppy device in guest.
Fedora 15.

Just i tried to use Fedora-15-x86_64-DVD.iso to install one guest, but hang up.

My qemu.git/HEAD is 9f60639b848944200c3d33a89233d808de0b5a43.

While it can work when using ./Fedora-14-x86_64-DVD.iso.

Quoted 2 lines

Regards,

Signature · 3 lines

Regards,

Zhi Yong Wu

Zhi Yong Wu

2011-10-28 10:28 UTC #9 lore raw

Quoted 82 lines · Zhi Yong Wu

Quoted 80 lines · Lucas Meneghel Rodrigues
Quoted 79 lines · Zhi Yong Wu
Quoted 75 lines · Lucas Meneghel Rodrigues
Quoted 58 lines · Stefan Hajnoczi
Quoted 55 lines · Lucas Meneghel Rodrigues
Quoted 23 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 12 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date: Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Quoted 8 lines
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated
regression jobs), so please take a look at it.
Quoted 3 lines
Can you please try again with the latest block branch? I think there is
a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Quoted 7 lines
Quoted 3 lines
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).
So no, the block branch does not resolve the floppy access problem.
Well, considering the tests of the stable set I'm running against qemu right
now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.

Quoted 4 lines

Quoted 4 lines
Quoted 2 lines
What is the OS of your guest? fedora16 or RHEL6? I would like recently to use floppy device in guest.
Fedora 15.

And on one host with OS Fedora 15, after floppy.ko is loaded, i have not seen its device file /dev/fd0.

On one guest with RH6 or Fedora 14, it fails to load floppy.ko.

Quoted 16 lines

Just i tried to use Fedora-15-x86_64-DVD.iso to install one guest, but hang up.
My qemu.git/HEAD is 9f60639b848944200c3d33a89233d808de0b5a43.
While it can work when using ./Fedora-14-x86_64-DVD.iso.
Quoted 2 lines
Regards,
--
Regards,
Zhi Yong Wu

Signature · 3 lines

Regards,

Zhi Yong Wu

Lucas Meneghel Rodrigues

author

2011-10-28 11:46 UTC #10 lore raw

In reply to Zhi Yong Wu

Quoted 66 lines · Zhi Yong Wu

Quoted 64 lines · Lucas Meneghel Rodrigues
Quoted 62 lines · Stefan Hajnoczi
Quoted 49 lines · Lucas Meneghel Rodrigues
Quoted 17 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 15 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Quoted 7 lines
Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Quoted 7 lines
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).

Quoted 8 lines

Quoted 6 lines
So no, the block branch does not resolve the floppy access problem.
Well, considering the tests of the stable set I'm running against qemu right now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.
What is the OS of your guest? fedora16 or RHEL6? I would like recently to use floppy device in guest.

Ok, correcting my answer, it was Windows 7 SP1. For some reason, I read 'host' instead of guest. I had a long day when I wrote the 1st reply.

It's been a while that we've verified that the linux floppy driver is quite unstable. In general linux + floppy devices on a guest tends to crash the guest kernel, and that's why in kvm autotest we moved from floppy devices to cdroms to hold the kickstart file. The fact you managed to get things working under F14 means you are lucky, and that particular floppy driver bug does not happen under F14's kernel. We never had such a kernel crash problem with any of the Windows's kernels.

So if I were you, I would *not* use a floppy with a linux guest. Well, unless you want to debug the floppy driver bug and fix this on upstream linux once for all, so future versions of linux won't have this problem.

Gleb Natapov

2011-10-28 12:10 UTC #11 lore raw

Quoted 89 lines · Lucas Meneghel Rodrigues

Quoted 66 lines · Zhi Yong Wu
Quoted 64 lines · Lucas Meneghel Rodrigues
Quoted 62 lines · Stefan Hajnoczi
Quoted 49 lines · Lucas Meneghel Rodrigues
Quoted 17 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 15 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Quoted 7 lines
Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Quoted 7 lines
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).
Quoted 8 lines
Quoted 6 lines
So no, the block branch does not resolve the floppy access problem.
Well, considering the tests of the stable set I'm running against qemu right now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.
What is the OS of your guest? fedora16 or RHEL6? I would like recently to use floppy device in guest.
Ok, correcting my answer, it was Windows 7 SP1. For some reason, I read 'host' instead of guest. I had a long day when I wrote the 1st reply.
It's been a while that we've verified that the linux floppy driver is quite unstable. In general linux + floppy devices on a guest tends to crash the guest kernel, and that's why in kvm autotest we moved from floppy devices to cdroms to hold the kickstart file. The fact you managed to get things working under F14 means you are lucky, and that particular floppy driver bug does not happen under F14's kernel. We never had such a kernel crash problem with any of the Windows's kernels.

Quoted 4 lines

So if I were you, I would *not* use a floppy with a linux guest. Well, unless you want to debug the floppy driver bug and fix this on upstream linux once for all, so future versions of linux won't have this problem.

AFAIK the problem exists only on smp guest.

--
Gleb.

Zhi Yong Wu

2011-10-31 02:38 UTC #12 lore raw

In reply to Lucas Meneghel Rodrigues

Quoted 94 lines · Lucas Meneghel Rodrigues

Quoted 73 lines · Zhi Yong Wu
Quoted 70 lines · Lucas Meneghel Rodrigues
Quoted 58 lines · Stefan Hajnoczi
Quoted 55 lines · Lucas Meneghel Rodrigues
Quoted 23 lines · Kevin Wolf
Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 12 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date: Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Quoted 8 lines
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated
regression jobs), so please take a look at it.
Quoted 3 lines
Can you please try again with the latest block branch? I think there is
a patch queued that will fix it.
Kevin, I did try with HEAD of your repo:
git://repo.or.cz/qemu/kevin.git
[lmr@freedom qemu-kwolf]$ git branch -r
origin/HEAD -> origin/master
origin/blkqueue
origin/blkqueue-v1
origin/block
origin/coroutine
origin/coroutine-block
origin/coroutine-devel
origin/devel
origin/ehci
origin/for-anthony
origin/for-stable-0.14
origin/inplace-conversion
origin/master
With this repo, master branch, the problem persists. With the block branch, the problem persists.
Now, with the blkqueue branch the problem is resolved. Cleber had the same results booting a FreeDOS floppy. So the fix is indeed in blkqueue.
Quoted 7 lines
Quoted 3 lines
Oh, you might want to check the blkqueue branch, it does have quite a bunch of set but unused variables, which will cause compilation errors unless --disable-werror is passed to the configure script.
I think blkqueue is an older development branch of the "block queue" feature that Kevin was working on. It is not Kevin's block tree (see his "block" branch).
So no, the block branch does not resolve the floppy access problem.
Quoted 8 lines
Quoted 5 lines
Well, considering the tests of the stable set I'm running against qemu right
now, this is not the biggest of our problems... I'm verifying qemu is segfaulting on nearly every prolonged attempt of doing migration... I'm about to write an email about it.
What is the OS of your guest? fedora16 or RHEL6? I would like recently to use floppy device in guest.
Ok, correcting my answer, it was Windows 7 SP1. For some reason, I read 'host' instead of guest. I had a long day when I wrote the 1st reply.
It's been a while that we've verified that the linux floppy driver is quite unstable. In general linux + floppy devices on a guest tends to crash the guest kernel, and that's why in kvm autotest we moved from floppy devices to cdroms to hold the kickstart file. The fact you managed to get things working under F14 means you are lucky, and that particular floppy driver bug does not happen under F14's kernel. We never had such a kernel crash problem with any of the Windows's kernels.

Quoted 3 lines

So if I were you, I would *not* use a floppy with a linux guest. Well, unless you want to debug the floppy driver bug and fix this on upstream linux once for all, so future versions of linux won't have this problem.

I need to do some works for fdc, etc. So i have to use it in one linux guest. anyway, thanks.

Quoted 1 line

Signature · 3 lines

Regards,

Zhi Yong Wu

Cleber Rosa

2011-10-26 17:37 UTC #13 lore raw

In reply to Kevin Wolf

Quoted 15 lines · Kevin Wolf

Am 26.10.2011 16:41, schrieb Lucas Meneghel Rodrigues:
Quoted 14 lines
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>

Quoted 8 lines

Quoted 4 lines
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Can you please try again with the latest block branch? I think there is a patch queued that will fix it.
Kevin

Kevin,

The behaviour of the latest block branch is indeed different, but not much better.

In my quick manual test, booting via a FreeDOS floppy image:

* latest master: does not seem to read the floppy at all
* latest block: reads the floppy only to the point that 'FreeDOS' is printed in the console

All other qemu/qemu-kvm versions tested (for example 0.15.0), successfully read and boot the same image.

CR.

Zhi Yong Wu

2011-11-02 07:48 UTC #14 lore raw

In reply to Lucas Meneghel Rodrigues

Quoted 11 lines · Lucas Meneghel Rodrigues

Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson <[email protected]>
Date: Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list

Quoted 7 lines

Signed-off-by Richard Henderson <[email protected]>
Signed-off-by Avi Kivity <[email protected]>
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.

Just i tried the latest qemu.git upstream, it can work for floppy now. I can see the floppy drive on guest and the file in it saved by me.

My qemu.git/HEAD is

commit e072ea2fd8fdceef64159b9596d3c15ce01bea91

Author: Anthony Liguori <[email protected]>
Date:   Tue Nov 1 19:37:01 2011 -0500

Bump version to 1.0-rc0

Look out 1.0, here we come!

Signed-off-by Anthony Liguori <[email protected]>

Quoted 6 lines

Cheers,
Lucas and Cleber

Signature · 3 lines

Regards,

Zhi Yong Wu

Lucas Meneghel Rodrigues

author

2011-11-03 02:01 UTC #15 lore raw

Quoted 26 lines · Zhi Yong Wu

Quoted 11 lines · Lucas Meneghel Rodrigues
Hi folks:
We've captured a regression with floppy disk on recent qemu (and qemu-kvm, after a code merge). We bisected it to be caused by:
commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8
Author: Richard Henderson<[email protected]>
Date:   Mon Aug 15 15:08:45 2011 -0700
fdc: Convert to isa_register_portio_list
Quoted 7 lines
Signed-off-by Richard Henderson<[email protected]>
Signed-off-by Avi Kivity<[email protected]>
Since this commit, the guest doesn't see a floppy disk attached to it anymore, blocking kvm autotest ability to install windows guests automatically. This is a big deal for kvm autotest (ruins our automated regression jobs), so please take a look at it.
Just i tried the latest qemu.git upstream, it can work for floppy now. I can see the floppy drive on guest and the file in it saved by me.
My qemu.git/HEAD is
commit e072ea2fd8fdceef64159b9596d3c15ce01bea91

Quoted 9 lines

Author: Anthony Liguori<[email protected]>
Date:   Tue Nov 1 19:37:01 2011 -0500
Bump version to 1.0-rc0
Look out 1.0, here we come!
Signed-off-by Anthony Liguori<[email protected]>

Ok, I have triggered some jobs and will look during the morning whether this is working for us as well.