femon patch for dB

I added a switch to femon so it displays signal and snr in dB.

The cx23885 driver for my Hauppauge WinTV-HVR1250 reports signal and snr in dB.

http://lockie.ca/test/femon.patch.bz2

Quoted 6 lines

I added a switch to femon so it displays signal and snr in dB.

The cx23885 driver for my Hauppauge WinTV-HVR1250 reports signal and snr in dB.

http://lockie.ca/test/femon.patch.bz2

Use git send-email to submit patches to mailing lists, thanks

diff -r d4e8bf5658ce util/femon/femon.c

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +5 -0

@@ -16,6 +16,9 @@
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ * James Lockie: Oct. 2011
+ * modified to add a switch (-2) to show signal/snr in dB
  */
 
 

@@ -37,11 +40,16 @@
 
 #include <libdvbapi/dvbfe.h>
 
+/* the s5h1409 delivers both fields in 0.1dB increments, while
+ * some demods expect signal to be 0-65535 and SNR to be in 1/256

increments

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +2 -0

+*/
+
 #define FE_STATUS_PARAMS

(DVBFE_INFO_LOCKSTATUS|DVBFE_INFO_SIGNAL_STRENGTH|DVBFE_INFO_BER|DVBFE_INFO_SNR|DVBFE_INFO_UNCORRECTED_BLOCKS)

static char *usage_str =
"\nusage: femon [options]\n"

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +1 -1

-    "     -H        : human readable output\n"
+    "     -H        : human readable output: (signal: 0-65335, snr:

1/256 increments)\n"
+ " -2 : human readable output: (signal and snr in .1 dB
increments)\n"

" -A : Acoustical mode. A sound indicates the signal
quality.\n"
" -r : If 'Acoustical mode' is active it tells the
application\n"
" is called remotely via ssh. The sound is heard on
the 'real'\n"

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +0 -0

 {

     struct dvbfe_info fe_info;
     unsigned int samples = 0;

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +24 -23

@@ -93,31 +101,32 @@ int check_frontend (struct dvbfe_handle
             fprintf(stderr, "Problem retrieving frontend information:
 %m\n");
         }
 
+        //  print the status code
+        printf ("status %c%c%c%c%c | ",
+            fe_info.signal ? 'S' : ' ',
+            fe_info.carrier ? 'C' : ' ',
+            fe_info.viterbi ? 'V' : ' ',
+            fe_info.sync ? 'Y' : ' ',
+            fe_info.lock ? 'L' : ' ' );
 
+        if (db_readable) {
+                       printf ("signal %3.0fdB | snr %3.0fdB",
+                (fe_info.signal_strength * 0.1),
+                (fe_info.snr * 0.1) );
+        } else if (human_readable) {
+                       printf ("signal %3u%% | snr %3u%%",
+                (fe_info.signal_strength * 100) / 0xffff,
+                (fe_info.snr * 100) / 0xffff );
+        } else {
+            printf ("signal %04x | snr %04x",
+                fe_info.signal_strength,
+                fe_info.snr );
+        }
 
-        if (human_readable) {
-                       printf ("status %c%c%c%c%c | signal %3u%% | snr
 %3u%% | ber %d | unc %d | ",
-                fe_info.signal ? 'S' : ' ',
-                fe_info.carrier ? 'C' : ' ',
-                fe_info.viterbi ? 'V' : ' ',
-                fe_info.sync ? 'Y' : ' ',
-                fe_info.lock ? 'L' : ' ',
-                (fe_info.signal_strength * 100) / 0xffff,
-                (fe_info.snr * 100) / 0xffff,
-                fe_info.ber,
-                fe_info.ucblocks);
-        } else {
-            printf ("status %c%c%c%c%c | signal %04x | snr %04x | ber
 %08x | unc %08x | ",
-                fe_info.signal ? 'S' : ' ',
-                fe_info.carrier ? 'C' : ' ',
-                fe_info.viterbi ? 'V' : ' ',
-                fe_info.sync ? 'Y' : ' ',
-                fe_info.lock ? 'L' : ' ',
-                fe_info.signal_strength,
-                fe_info.snr,
-                fe_info.ber,
-                fe_info.ucblocks);
-        }
+        /* always print ber and ucblocks */
+        printf (" | ber %08x | unc %08x | ",
+            fe_info.ber,
+            fe_info.ucblocks);

 
         if (fe_info.lock)
             printf("FE_HAS_LOCK");

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +0 -0

 {

     int result;
     struct dvbfe_handle *fe;

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +7 -4

@@ -175,7 +184,7 @@ int do_mon(unsigned int adapter, unsigne
     }
     printf("FE: %s (%s)\n", fe_info.name, fe_type);
 
-    result = check_frontend (fe, human_readable, count);
+    result = check_frontend (fe, human_readable, db_readable, count);
 
     dvbfe_close(fe);
 

@@ -186,9 +195,10 @@ int main(int argc, char *argv[])
 {
     unsigned int adapter = 0, frontend = 0, count = 0;
     int human_readable = 0;
+    int db_readable = 0;
     int opt;
 
-       while ((opt = getopt(argc, argv, "rAHa:f:c:")) != -1) {
+       while ((opt = getopt(argc, argv, "rAH2a:f:c:")) != -1) {
         switch (opt)
         {
         default:

@@ -206,6 +216,9 @@ int main(int argc, char *argv[])
         case 'H':
             human_readable = 1;
             break;
+        case '2':
+            db_readable = 1;
+            break;
         case 'A':
             // Acoustical mode: we have to reduce the delay between
             // checks in order to hear nice sound

@@ -218,7 +231,7 @@ int main(int argc, char *argv[])
         }
     }
 
-    do_mon(adapter, frontend, human_readable, count);
+    do_mon(adapter, frontend, human_readable, db_readable, count);
 
     return 0;
 }
 
--

Quoted 17 lines

diff -r d4e8bf5658ce util/femon/femon.c

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +3 -0

@@ -16,6 +16,9 @@
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ * James Lockie: Oct. 2011
+ * modified to add a switch (-2) to show signal/snr in dB
  */
 
 

@@ -37,11 +40,16 @@
 
 #include <libdvbapi/dvbfe.h>
 

Quoted 3 lines

util/femon/femon.c Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c Fri Oct 07 01:26:04 2011 +0530 +2 -0

+/* the s5h1409 delivers both fields in 0.1dB increments, while
+ * some demods expect signal to be 0-65535 and SNR to be in 1/256

increments

Looks like thunderbird is being too helpful for us here -- by breaking a long line where it shouldn't be broken. You can see if <kernel source>/Documentation/email-clients.txt helps you any with that.

Em 29-10-2011 07:39, Randy Dunlap escreveu:

Quoted 18 lines · James

Quoted 17 lines

diff -r d4e8bf5658ce util/femon/femon.c

util/femon/femon.c    Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c    Fri Oct 07 01:26:04 2011 +0530 +3 -0

@@ -16,6 +16,9 @@
   * You should have received a copy of the GNU General Public License
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ * James Lockie: Oct. 2011
+ * modified to add a switch (-2) to show signal/snr in dB
   */
 
 

@@ -37,11 +40,16 @@
 
  #include <libdvbapi/dvbfe.h>
 

Quoted 7 lines

Quoted 3 lines

util/femon/femon.c    Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c    Fri Oct 07 01:26:04 2011 +0530 +2 -0

+/* the s5h1409 delivers both fields in 0.1dB increments, while
+ * some demods expect signal to be 0-65535 and SNR to be in 1/256

increments

Looks like thunderbird is being too helpful for us here -- by breaking a long line where it shouldn't be broken.  You can see if <kernel source>/Documentation/email-clients.txt helps you any with that.

This is not a kernel patch, but yes, you're right: there's nothing we can't apply it to dvb-apps as-is.

Thunderbird only works well if the html editor is disabled and if the max number of lines is set to 0. I use it here, but I'm currently sending patches directly from git, as it is simpler, if the smtp server is properly configured. There is one plugin for it that fixes those stuff on thunerbird (asalted-patches), but this doesn't work with newer versions of it (well, fixing it is probably a one-line patch like [2] changing the maxVersion).

[1] https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/
[2] https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/rev/49d587f60371

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Quoted 40 lines · Mauro Carvalho Chehab

Em 29-10-2011 07:39, Randy Dunlap escreveu:

Quoted 18 lines · James

Quoted 17 lines

diff -r d4e8bf5658ce util/femon/femon.c

util/femon/femon.c    Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c    Fri Oct 07 01:26:04 2011 +0530 +3 -0

@@ -16,6 +16,9 @@
   * You should have received a copy of the GNU General Public License
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ * James Lockie: Oct. 2011
+ * modified to add a switch (-2) to show signal/snr in dB
   */
 
 

@@ -37,11 +40,16 @@
 
  #include <libdvbapi/dvbfe.h>
 

Quoted 7 lines

Quoted 3 lines

util/femon/femon.c    Fri Oct 28 18:52:12 2011 -0400 renamed from util/femon/femon.c    Fri Oct 07 01:26:04 2011 +0530 +2 -0

+/* the s5h1409 delivers both fields in 0.1dB increments, while
+ * some demods expect signal to be 0-65535 and SNR to be in 1/256

increments

Looks like thunderbird is being too helpful for us here -- by breaking a long line where it shouldn't be broken.  You can see if <kernel source>/Documentation/email-clients.txt helps you any with that.

This is not a kernel patch, but yes, you're right: there's nothing we can't apply it to dvb-apps as-is.

Thunderbird only works well if the html editor is disabled and if the max number of lines is set to 0. I use it here, but I'm currently sending patches directly from git, as it is simpler, if the smtp server is properly configured. There is one plugin for it that fixes those stuff on thunerbird (asalted-patches), but this doesn't work with newer versions of it (well, fixing it is probably a one-line patch like [2] changing the maxVersion).

[1] https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/
[2] https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/rev/49d587f60371

Quoted 7 lines

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

please do not apply this patch - as per the patch description (i haven't seen the patch yet since it wasnt sent inline) this is a userspace conversion patch based on the output of *one* demodulator driver.

I will push the work for the ATSC snr conversions to my git repository and issue a pull request to Mauro by the end of the day.  This issue is larger than a simple userspace unit conversion.  Please send in the patch inline anyway, as some users may wish to experiment with it, but we need to first standardize the kernel unit reporting before we claim to report in a given unit.

The patch is actually OK with me, except that i disagree with the -2 parameter choice. I propose instead, to use a lowercase 'h' ...

You should take look to demod drivers and check what those are returning. I have strong feeling that most drivers returns SNR as 10xdB. And SS as 0-0xffff. I think there is good consensus of SNR unit, but for SS it is not so clear. For my drivers I have used SNR 10xdB and SS 0-0xffff. That's why, giving only those two alternatives is not suitable. Maybe it is better to set own param for SNR and SS?

I will push the work for the ATSC snr conversions to my git repository and issue a pull request to Mauro by the end of the day.  This issue is larger than a simple userspace unit conversion.  Please send in the patch inline anyway, as some users may wish to experiment with it, but we need to first standardize the kernel unit reporting before we claim to report in a given unit.

I added a switch to femon so it displays signal and snr in dB.

The cx23885 driver for my Hauppauge WinTV-HVR1250 reports signal and snr in dB.

http://lockie.ca/test/femon.patch.bz2