Skip to contentSkip to conversation

dockstar: include headers that were removed from kirkwood.h

PATCH New Eric Cooper 2 participants 3 messages Oct 29, 2011

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dockstar: include headers that were removed from kirkwood.h

Commit a7efd719f415833a833d6a8e46bcd470a0847ecc removed some #includes from kirkwood.h that must now be done in dockstar.c

---
 board/Seagate/dockstar/dockstar.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
board/Seagate/dockstar/dockstar.c +2 -0
index cab3a83..9aab62d 100644
@@ -27,6 +27,8 @@
 
 #include <common.h>
 #include <miiphy.h>
+#include <asm/io.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include "dockstar.h"
Signature · 1 line
1.7.7
#1 lore raw

PATCH 1/1 dockstar: include headers that were removed from kirkwood.h

Hi Eric,

Quoted 7 lines · On Sat, 29 Oct 2011 15:09:40 -0400 Eric Cooper <[email protected]> wrote:

Commit a7efd719f415833a833d6a8e46bcd470a0847ecc removed some #includes from kirkwood.h that must now be done in dockstar.c

---
 board/Seagate/dockstar/dockstar.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

There is another similar patch also fixing compiler warning for mvgbe.c:

http://patchwork.ozlabs.org/patch/122552/

Thanks,
Anatolij

#2 lore raw

PATCH 1/1 dockstar: include headers that were removed from kirkwood.h

Quoted 3 lines · Anatolij Gustschin

There is another similar patch also fixing compiler warning for mvgbe.c:

http://patchwork.ozlabs.org/patch/122552/

Yes, please go ahead and use yours. I'd suggest moving the #includes in dockstar.c up a few lines, though, so that '#include "dockstar.h"' is the last one, to be consistent with other board files like sheevaplug.c etc.

Signature · 1 line
Eric Cooper             e c c @ c m u . e d u