ARM: netspace_v2: fix warnings

PATCH New Anatolij Gustschin 4 participants 7 messages Oct 29, 2011 – Oct 30, 2011

lore

Share & tools

lore

Anatolij Gustschin

author

2011-10-29 21:31 UTC #0 lore raw

PATCH 1/1 ARM: netspace_v2: fix warnings

Fix compiler warnings when compiling for netspace_v2, netspace_max_v2 and inetspace_v2:

netspace_v2.c: In function 'board_early_init_f':
netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio' netspace_v2.c: In function 'board_init':
netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'

Signed-off-by Anatolij Gustschin <[email protected]>

Cc Simon Guinot <[email protected]>

Cc Albert ARIBAUD <[email protected]>

---
 board/LaCie/netspace_v2/netspace_v2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

board/LaCie/netspace_v2/netspace_v2.c +1 -0

index 3bb83f3..7c4b15e 100644
@@ -24,6 +24,7 @@
 #include <miiphy.h>
 #include <netdev.h>
 #include <command.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include <asm/arch/gpio.h>

Signature · 1 line

1.7.1

Marek Vasut

2011-10-29 22:36 UTC #1 lore raw

PATCH 1/1 ARM: netspace_v2: fix warnings

Quoted 20 lines

Fix compiler warnings when compiling for netspace_v2, netspace_max_v2 and inetspace_v2:
netspace_v2.c: In function 'board_early_init_f':
netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio' netspace_v2.c: In function 'board_init':
netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'
Signed-off-by Anatolij Gustschin <[email protected]>
Cc Simon Guinot <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 board/LaCie/netspace_v2/netspace_v2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
(quoted diff) +0 -0
b/board/LaCie/netspace_v2/netspace_v2.c index 3bb83f3..7c4b15e 100644

board/LaCie/netspace_v2/netspace_v2.c line 30

Quoted 7 lines

board/LaCie/netspace_v2/netspace_v2.c +1 -0

@@ -24,6 +24,7 @@
 #include <miiphy.h>
 #include <netdev.h>
 #include <command.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include <asm/arch/gpio.h>

Acked-by Marek Vasut <[email protected]>

Albert ARIBAUD

2011-10-30 10:45 UTC #2 lore raw

PATCH 1/1 ARM: netspace_v2: fix warnings

In reply to Anatolij Gustschin

Hi Anatolij,

Le 29/10/2011 23:31, Anatolij Gustschin a ?crit :

Quoted 20 lines

Fix compiler warnings when compiling for netspace_v2, netspace_max_v2 and inetspace_v2:
netspace_v2.c: In function 'board_early_init_f':
netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio' netspace_v2.c: In function 'board_init':
netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'
Signed-off-by Anatolij Gustschin<[email protected]>
Cc Simon Guinot<[email protected]>
Cc Albert ARIBAUD<[email protected]>
---
  board/LaCie/netspace_v2/netspace_v2.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
board/LaCie/netspace_v2/netspace_v2.c +0 -0
index 3bb83f3..7c4b15e 100644

board/LaCie/netspace_v2/netspace_v2.c line 30

Quoted 7 lines

board/LaCie/netspace_v2/netspace_v2.c +1 -0

@@ -24,6 +24,7 @@
  #include<miiphy.h>
  #include<netdev.h>
  #include<command.h>
+#include<asm/arch/cpu.h>
  #include<asm/arch/kirkwood.h>
  #include<asm/arch/mpp.h>
  #include<asm/arch/gpio.h>

Applied to u-boot-arm/master, as a bugfix to help netspace_v2 compile clean.

Note however that I also see the following warning for netspace_v2:

mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'

Amicalement,

Signature · 1 line

Albert.

Anatolij Gustschin

author

2011-10-30 11:34 UTC #3 lore raw

PATCH 1/1 ARM: netspace_v2: fix warnings

Hi Albert,

On Sun, 30 Oct 2011 11:45:37 +0100
Albert ARIBAUD <[email protected]> wrote:
...

Quoted 6 lines

Applied to u-boot-arm/master, as a bugfix to help netspace_v2 compile clean.
Note however that I also see the following warning for netspace_v2:
mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'

This one is fixed by another patch for fixing dockstar compile breakage I've applied before [1]. There is also another patch for fixing dreamplug breakage [2]. Can you apply them too? I've resend the dockstar patch, but forgot to tag it as v2, sorry.

Thanks,
Anatolij

[1] http://patchwork.ozlabs.org/patch/122575/
[2] http://patchwork.ozlabs.org/patch/122579/

Albert ARIBAUD

2011-10-30 16:19 UTC #4 lore raw

PATCH 1/1 ARM: netspace_v2: fix warnings

Hi Anatolij,

Le 30/10/2011 12:34, Anatolij Gustschin a ?crit :

Quoted 17 lines

Hi Albert,
On Sun, 30 Oct 2011 11:45:37 +0100
Albert ARIBAUD<[email protected]> wrote:
...
Quoted 6 lines
Applied to u-boot-arm/master, as a bugfix to help netspace_v2 compile clean.
Note however that I also see the following warning for netspace_v2:
mvgbe.c: In function 'mvgbe_initialize':
mvgbe.c:735: warning: implicit declaration of function 'get_random_hex'
This one is fixed by another patch for fixing dockstar compile breakage I've applied before [1]. There is also another patch for fixing dreamplug breakage [2]. Can you apply them too? I've resend the dockstar patch, but forgot to tag it as v2, sorry.

Quoted 5 lines

Thanks,
Anatolij
[1] http://patchwork.ozlabs.org/patch/122575/
[2] http://patchwork.ozlabs.org/patch/122579/

I take both in u-boot-arm/master as bug fixes.

Amicalement,

Signature · 1 line

Albert.

Anatolij Gustschin

author

2011-10-30 16:21 UTC #5 lore raw

PATCH 1/1 ARM: netspace_v2: fix warnings

Hi Albert,

On Sun, 30 Oct 2011 17:19:58 +0100
Albert ARIBAUD <[email protected]> wrote:
...

Quoted 4 lines

Quoted 2 lines
[1] http://patchwork.ozlabs.org/patch/122575/
[2] http://patchwork.ozlabs.org/patch/122579/
I take both in u-boot-arm/master as bug fixes.

Thanks!

Anatolij

Simon Guinot

2011-10-30 12:40 UTC #6 lore raw

PATCH 1/1 ARM: netspace_v2: fix warnings

In reply to Anatolij Gustschin

Quoted 7 lines · Anatolij Gustschin

Fix compiler warnings when compiling for netspace_v2, netspace_max_v2 and inetspace_v2:
netspace_v2.c: In function 'board_early_init_f':
netspace_v2.c:37: warning: implicit declaration of function 'kw_config_gpio' netspace_v2.c: In function 'board_init':
netspace_v2.c:86: warning: implicit declaration of function 'kw_sdram_bar'

It seems to me this regression has been introduced by:

commit a7efd719f415833a833d6a8e46bcd470a0847ecc

Author: Lei Wen <[[email protected]]>
Date:   Tue Oct 18 20:11:42 2011 +0530

ARM: kirkwood: reduce dependence of including platform file

For files like the drivers/serial/serial.c, it must include the platform file, as the CONFIG_SYS_NS16550_COM1 must reference to the definition in the platform definition files.

Include the platform definition file in the config file, so that it would decouple the dependence for the driver files.

Signed-off-by Lei Wen <[email protected]>

Maybe that more boards are affected.

Quoted 13 lines

Signed-off-by Anatolij Gustschin <[email protected]>
Cc Simon Guinot <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 board/LaCie/netspace_v2/netspace_v2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
board/LaCie/netspace_v2/netspace_v2.c +0 -0
index 3bb83f3..7c4b15e 100644

board/LaCie/netspace_v2/netspace_v2.c line 30

Quoted 7 lines

board/LaCie/netspace_v2/netspace_v2.c +1 -0

@@ -24,6 +24,7 @@
 #include <miiphy.h>
 #include <netdev.h>
 #include <command.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include <asm/arch/gpio.h>

Acked-by Simon Guinot <[email protected]>

Thanks for the compilation clean-up.

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111030/e6aaa9cc/attachment.pgp