Skip to contentSkip to conversation

ARM: dreamplug: fix compilation

PATCH New Anatolij Gustschin 2 participants 4 messages Oct 29, 2011 Real time clock (RTC)

lore
Share & tools
lore

Anatolij Gustschin

author
#0 lore raw

PATCH 1/1 ARM: dreamplug: fix compilation

Fix build issues:

mvrtc.c: In function 'rtc_get':
mvrtc.c:45: warning: implicit declaration of function 'readl'
mvrtc.c: In function 'rtc_set':
mvrtc.c:100: warning: implicit declaration of function 'writel'
dreamplug.c: In function 'board_early_init_f':
dreamplug.c:43: warning: implicit declaration of function 'kw_config_gpio'
dreamplug.c: In function 'board_init':
dreamplug.c:108: warning: implicit declaration of function 'kw_sdram_bar' drivers/rtc/librtc.o: In function `rtc_set':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:92: undefined reference to writel' /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:103: undefined reference to writel' drivers/rtc/librtc.o: In function `rtc_reset':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:117: undefined reference to readl' /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:120: undefined reference to readl' drivers/rtc/librtc.o: In function `rtc_get':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:45: undefined reference to readl' /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:48: undefined reference to readl'
...

Signed-off-by Anatolij Gustschin <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 board/Marvell/dreamplug/dreamplug.c |    1 +
 drivers/rtc/mvrtc.c                 |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
board/Marvell/dreamplug/dreamplug.c +1 -0
index 13b4013..31b73c9 100644
@@ -27,6 +27,7 @@
 
 #include <common.h>
 #include <miiphy.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include "dreamplug.h"
drivers/rtc/mvrtc.c +1 -0
index ccc573a..edc1f4f 100644
@@ -28,6 +28,7 @@
 #include <common.h>
 #include <command.h>
 #include <rtc.h>
+#include <asm/io.h>
 #include "mvrtc.h"
 
 /* This RTC does not support century, so we assume 20 */
Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 ARM: dreamplug: fix compilation

Quoted 51 lines

Fix build issues:

mvrtc.c: In function 'rtc_get':
mvrtc.c:45: warning: implicit declaration of function 'readl' mvrtc.c: In function 'rtc_set':
mvrtc.c:100: warning: implicit declaration of function 'writel' dreamplug.c: In function 'board_early_init_f':
dreamplug.c:43: warning: implicit declaration of function 'kw_config_gpio' dreamplug.c: In function 'board_init':
dreamplug.c:108: warning: implicit declaration of function 'kw_sdram_bar' drivers/rtc/librtc.o: In function `rtc_set':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:92:
undefined reference to `writel' /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:103:
undefined reference to writel' drivers/rtc/librtc.o: In function rtc_reset':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:117:
undefined reference to `readl' /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:120:
undefined reference to readl' drivers/rtc/librtc.o: In function rtc_get':
/home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:45:
undefined reference to `readl' /home/ag/u-boot/u-boot-move-new-host/u-boot-video/drivers/rtc/mvrtc.c:48:
undefined reference to `readl' ...

Signed-off-by Anatolij Gustschin <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Albert ARIBAUD <[email protected]>
---
 board/Marvell/dreamplug/dreamplug.c |    1 +
 drivers/rtc/mvrtc.c                 |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/board/Marvell/dreamplug/dreamplug.c index 13b4013..31b73c9 100644

board/Marvell/dreamplug/dreamplug.c +1 -0
@@ -27,6 +27,7 @@
 
 #include <common.h>
 #include <miiphy.h>
+#include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
 #include "dreamplug.h"
drivers/rtc/mvrtc.c +0 -0
index ccc573a..edc1f4f 100644

drivers/rtc/mvrtc.c line 34

Quoted 7 lines
drivers/rtc/mvrtc.c +1 -0
@@ -28,6 +28,7 @@
 #include <common.h>
 #include <command.h>
 #include <rtc.h>
+#include <asm/io.h>
 #include "mvrtc.h"
 
 /* This RTC does not support century, so we assume 20 */

How the heck did you get this? I MAKEALL-ed all ARM boards and didn't get this crap.

Either way:

Acked-by Marek Vasut <[email protected]>
author
#2 lore raw

PATCH 1/1 ARM: dreamplug: fix compilation

Hi,

On Sun, 30 Oct 2011 00:36:51 +0200
Marek Vasut <[email protected]> wrote:
...

Quoted 2 lines

How the heck did you get this? I MAKEALL-ed all ARM boards and didn't get this crap.

It showed up when running 'MAKEALL arm' in my u-boot-video repo. It also shows up on current u-boot master when running './MAKEALL dreamplug'. In both tests I used ELDK-4.2 ARM toolchain. The issue also show up when running './MAKEALL dreamplug' using current u-boot-arm/master.

Anatolij

#3 lore raw

PATCH 1/1 ARM: dreamplug: fix compilation

Quoted 9 lines

Hi,

On Sun, 30 Oct 2011 00:36:51 +0200
Marek Vasut <[email protected]> wrote:
...

Quoted 2 lines

How the heck did you get this? I MAKEALL-ed all ARM boards and didn't get this crap.

Quoted 7 lines

It showed up when running 'MAKEALL arm' in my u-boot-video repo. It also shows up on current u-boot master when running './MAKEALL dreamplug'. In both tests I used ELDK-4.2 ARM toolchain. The issue also show up when running './MAKEALL dreamplug' using current u-boot-arm/master.

Anatolij

I'll re-run my tests, thanks !!!