Skip to contentSkip to conversation

kernel panic on device removal when using a workqueue and delayed_work

DISCUSSION Frank Schäfer 3 participants 7 messages Oct 30, 2011 – Nov 5, 2011

lore
Share & tools
lore
#0 lore raw

Hi,

with the following simple kernel module, I have a good chance to get a kernel panic when I unplug the device:

#include <linux/workqueue.h>
#include <linux/usb.h>
#include <linux/module.h>

MODULE_AUTHOR("Nobody");
MODULE_DESCRIPTION("example driver for causing kernel panic"); MODULE_LICENSE("GPL");

static struct delayed_work poll_work;

static void poll(struct work_struct *work)

{
    schedule_delayed_work(&poll_work,
                  msecs_to_jiffies(100));
}

static int test_probe(struct usb_interface *intf,
const struct usb_device_id *id)

{
    INIT_DELAYED_WORK(&poll_work, poll);
    schedule_delayed_work(&poll_work,
                  msecs_to_jiffies(100));
    return 0;
}

static void test_disconnect(struct usb_interface *intf)

{
    cancel_delayed_work_sync(&poll_work);
}
static const struct usb_device_id device_table[] = {
    {USB_DEVICE(0x1234, 0x5678)},
    {}
};

MODULE_DEVICE_TABLE(usb, device_table);

static struct usb_driver test_driver = {

    .name       = "test",
    .id_table   = device_table,
    .probe      = test_probe,

.disconnect = test_disconnect,
};

static int __init test_mod_init(void)

{
    return usb_register(&test_driver);
}

static void __exit test_mod_exit(void)

{
    usb_deregister(&test_driver);
}

module_init(test_mod_init);
module_exit(test_mod_exit);

A picture of the backtrace (the machine immediately turns off without saving a backtrace) can be found at

http://imageshack.us/photo/my-images/823/img075gv.jpg

Kernel version is 3.1.0.

This is the first time I'm using a workqueue, so there is a good chance that I missed something... Or is this a kernel bug ?

Regards,
Frank Schaefer

#1 lore raw
Quoted 69 lines · Frank Sch�fer

Hi,

with the following simple kernel module, I have a good chance to get a kernel panic when I unplug the device:

#include <linux/workqueue.h>
#include <linux/usb.h>
#include <linux/module.h>

MODULE_AUTHOR("Nobody");
MODULE_DESCRIPTION("example driver for causing kernel panic"); MODULE_LICENSE("GPL");

static struct delayed_work poll_work;

static void poll(struct work_struct *work)

{
    schedule_delayed_work(&poll_work,
                  msecs_to_jiffies(100));
}

static int test_probe(struct usb_interface *intf,
const struct usb_device_id *id)

{
    INIT_DELAYED_WORK(&poll_work, poll);
    schedule_delayed_work(&poll_work,
                  msecs_to_jiffies(100));
    return 0;
}

static void test_disconnect(struct usb_interface *intf)

{
    cancel_delayed_work_sync(&poll_work);
}
static const struct usb_device_id device_table[] = {
    {USB_DEVICE(0x1234, 0x5678)},
    {}
};

MODULE_DEVICE_TABLE(usb, device_table);

static struct usb_driver test_driver = {

    .name       = "test",
    .id_table   = device_table,
    .probe      = test_probe,

.disconnect = test_disconnect,
};

static int __init test_mod_init(void)

{
    return usb_register(&test_driver);
}

static void __exit test_mod_exit(void)

{
    usb_deregister(&test_driver);
}

module_init(test_mod_init);
module_exit(test_mod_exit);

A picture of the backtrace (the machine immediately turns off without saving a backtrace) can be found at

Quoted 7 lines

http://imageshack.us/photo/my-images/823/img075gv.jpg

Kernel version is 3.1.0.

This is the first time I'm using a workqueue, so there is a good chance that I missed something...

You should cancel the work you have armed before exit. See cancel_delayed_work().

Quoted 1 line

Or is this a kernel bug ?

I don't think so.

Thanks,
Yong

#2 lore raw

Am 31.10.2011 04:11, schrieb Yong Zhang:

Quoted 36 lines · Frank Sch�fer
Quoted 35 lines

Hi,

with the following simple kernel module, I have a good chance to get a kernel panic when I unplug the device:

#include<linux/workqueue.h>
#include<linux/usb.h>
#include<linux/module.h>

MODULE_AUTHOR("Nobody");
MODULE_DESCRIPTION("example driver for causing kernel panic"); MODULE_LICENSE("GPL");

static struct delayed_work poll_work;

static void poll(struct work_struct *work)

{
     schedule_delayed_work(&poll_work,
                   msecs_to_jiffies(100));
}

static int test_probe(struct usb_interface *intf,
const struct usb_device_id *id)

{
     INIT_DELAYED_WORK(&poll_work, poll);
     schedule_delayed_work(&poll_work,
                   msecs_to_jiffies(100));
     return 0;
}

static void test_disconnect(struct usb_interface *intf)

{
     cancel_delayed_work_sync(&poll_work);
}

...

Quoted 35 lines
Quoted 35 lines
static const struct usb_device_id device_table[] = {
     {USB_DEVICE(0x1234, 0x5678)},
     {}
};

MODULE_DEVICE_TABLE(usb, device_table);

static struct usb_driver test_driver = {

     .name       = "test",
     .id_table   = device_table,
     .probe      = test_probe,

.disconnect = test_disconnect,
};

static int __init test_mod_init(void)

{
     return usb_register(&test_driver);
}

static void __exit test_mod_exit(void)

{
     usb_deregister(&test_driver);
}

module_init(test_mod_init);
module_exit(test_mod_exit);

A picture of the backtrace (the machine immediately turns off without saving a backtrace) can be found at

http://imageshack.us/photo/my-images/823/img075gv.jpg

Quoted 7 lines
Quoted 5 lines

Kernel version is 3.1.0.

This is the first time I'm using a workqueue, so there is a good chance that I missed something...

You should cancel the work you have armed before exit. See cancel_delayed_work().

That's what I'm doing (see above).
Did you read the code ? ;-)

Regards,
Frank Schaefer

Quoted 5 lines
Quoted 1 line

Or is this a kernel bug ?

I don't think so.

Thanks,
Yong

#3 lore raw

Am Montag, 31. Oktober 2011, 11:26:58 schrieb Frank Schäfer:

Quoted 8 lines

Am 31.10.2011 04:11, schrieb Yong Zhang:

Quoted 4 lines
Quoted 2 lines

This is the first time I'm using a workqueue, so there is a good chance that I missed something...

You should cancel the work you have armed before exit. See cancel_delayed_work().

That's what I'm doing (see above).
Did you read the code ? ;-)

Does it work if you set a flag and resubmit the work only conditionally on it?

Regards
Oliver

#4 lore raw

Am 31.10.2011 11:29, schrieb Oliver Neukum:

Quoted 10 lines

Am Montag, 31. Oktober 2011, 11:26:58 schrieb Frank Schäfer:

Quoted 7 lines

Am 31.10.2011 04:11, schrieb Yong Zhang:

Quoted 4 lines
Quoted 2 lines

This is the first time I'm using a workqueue, so there is a good chance that I missed something...

You should cancel the work you have armed before exit. See cancel_delayed_work().

That's what I'm doing (see above).
Did you read the code ? ;-)

Does it work if you set a flag and resubmit the work only conditionally on it?

What do you mean ? Which flag should I set and what's the condition to check for ?

Regards,
Frank

Quoted 2 lines

Regards
Oliver

#5 lore raw
In reply to Frank Schäfer
Quoted 3 lines · Frank Schäfer

Am 31.10.2011 04:11, schrieb Yong Zhang:
That's what I'm doing (see above).
Did you read the code ? ;-)

Oh, blind me.

Maybe you can enable DEBUG_OBJECTS_TIMERS && DEBUG_OBJECTS_WORK to check if anything is broken.

Thanks,
Yong

#6 lore raw

Am 02.11.2011 07:31, schrieb Yong Zhang:

Quoted 8 lines · Frank Schäfer
Quoted 3 lines

Am 31.10.2011 04:11, schrieb Yong Zhang:
That's what I'm doing (see above).
Did you read the code ? ;-)

Oh, blind me.

Maybe you can enable DEBUG_OBJECTS_TIMERS&& DEBUG_OBJECTS_WORK to check if anything is broken.

I enabled both debug options but nothing changed (nothing new in the logs). Any other ideas to debug this further ?

Thanks,
Frank

Quoted 2 lines

Thanks,
Yong