Skip to contentSkip to conversation

mmc: mv_sdhci: Fix host version read for Armada100

PATCH Superseded Ajay Bhargav 3 participants 5 messages Nov 2, 2011 – Nov 3, 2011 1 message not in the archive

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Ajay Bhargav

author
#1 lore raw

PATCH 1/1 mmc: mv_sdhci: Fix host version read for Armada100

Quoted 80 lines · ----- "Marek Vasut
Quoted 2 lines
Quoted 1 line · ----- "Marek Vasut
Quoted 1 line

sdhci_readw does not work for host version read in Armada100

series

Quoted 1 line
Quoted 1 line
Quoted 1 line

SoCs. This patch fix this issue by making a sdhci_readl call to

get

Quoted 19 lines
Quoted 19 lines

host

drivers/mmc/mv_sdhci.c static inline void mv_sdhci_writeb(struct

Quoted 13 lines

version.

Signed-off-by Ajay Bhargav <[email protected]>

---

 drivers/mmc/mv_sdhci.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/mmc/mv_sdhci.c +0 -0
index f92caeb..c7fd287 100644
@@ -30,6 +30,7 @@ static inline void mv_sdhci_writeb(struct

sdhci_host

Quoted 1 line
Quoted 1 line

drivers/mmc/mv_sdhci.c static inline void mv_sdhci_writeb(struct · line 30

Quoted 1 line
drivers/mmc/mv_sdhci.c +0 -0
 *host, u8 val, int reg) #endif /* CONFIG_MMC_SDHCI_IO_ACCESSORS

*/

Quoted 6 lines
Quoted 6 lines

drivers/mmc/mv_sdhci.c static inline void mv_sdhci_writeb(struct · line 35

Quoted 6 lines
drivers/mmc/mv_sdhci.c +1 -0
 static char *MVSDH_NAME = "mv_sdh";
 
+
 
 int mv_sdh_init(u32 regbase, u32 max_clk, u32 min_clk, u32

quirks)

Quoted 5 lines
Quoted 5 lines

drivers/mmc/mv_sdhci.c int mv_sdh_init(u32 regbase, u32 max_clk,

Quoted 5 lines
drivers/mmc/mv_sdhci.c +0 -0
 {
drivers/mmc/mv_sdhci.c +0 -0
 	struct sdhci_host *host = NULL;

@@ -48,7 +49,12 @@ int mv_sdh_init(u32 regbase, u32 max_clk,

u32

Quoted 5 lines
Quoted 5 lines

min_clk,

Quoted 2 lines
drivers/mmc/mv_sdhci.c +0 -0
 u32 quirks) mv_ops.write_b = mv_sdhci_writeb;
Quoted 7 lines
Quoted 7 lines

drivers/mmc/mv_sdhci.c int mv_sdh_init(u32 regbase, u32 max_clk, · line 57

Quoted 7 lines
drivers/mmc/mv_sdhci.c +3 -0
 	host->ops = &mv_ops;
 
 #endif
 
+#ifdef CONFIG_ARMADA100
+	/* SDHCI host version read workaround for Armada100 series */
+	host->version = sdhci_readl(host, SDHCI_HOST_VERSION - 2) >>

16;

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/mmc/mv_sdhci.c +1 -0
+#else
 
 	host->version = sdhci_readw(host, SDHCI_HOST_VERSION);
Quoted 8 lines
Quoted 8 lines

drivers/mmc/mv_sdhci.c

Quoted 6 lines
drivers/mmc/mv_sdhci.c +1 -0
+#endif
 
 	add_sdhci(host, max_clk, min_clk);
 	return 0;
 
 }

Basically armada100 can't do 16bit access to that register. Ok,

but

Quoted 2 lines
Quoted 2 lines

why does it
work for other registers? Also, can you make this a config option

like

Quoted 9 lines
Quoted 4 lines

CONFIG_SDHCI_REG32_QUIRK (invent some better name ;-) ).

Cheers

Hi Marek,

Armada100 SOC has this bug for particularly that register. This is particularly for that register so Do you think a config is required

for

Quoted 1 line

this?

Quoted 8 lines

Well such crippled hardware might appear somewhere else too, so yes. But still,
it's surprising it's only one register, really. Can you point me to a

datasheet/errata stating it?

Thanks!

I agree, adding a quirk for this is best option this way driver will still be generic for marvell series.
Marek, I am really sorry but I am not allowed to share errata here :) I will ask my senior if i can atleast send you a screenshot regarding this issue.

Regards,
Ajay Bhargav

#2 lore raw

PATCH 1/1 mmc: mv_sdhci: Fix host version read for Armada100

Quoted 4 lines
Quoted 3 lines · ----- "Marek Vasut
Quoted 2 lines
Quoted 1 line · ----- "Marek Vasut
Quoted 1 line

sdhci_readw does not work for host version read in Armada100

[...]

Quoted 4 lines
Quoted 4 lines

Well such crippled hardware might appear somewhere else too, so yes. But still,
it's surprising it's only one register, really. Can you point me to a

Quoted 8 lines
Quoted 3 lines

datasheet/errata stating it?

Thanks!

I agree, adding a quirk for this is best option this way driver will still be generic for marvell series. Marek, I am really sorry but I am not allowed to share errata here :) I will ask my senior if i can atleast send you a screenshot regarding this issue.

Stupid Marvell crap again :-(

Quoted 3 lines

Regards,
Ajay Bhargav

#3 lore raw

PATCH 1/1 mmc: mv_sdhci: Fix host version read for Armada100

Quoted 29 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Marek Vasut
Sent: Wednesday, November 02, 2011 3:55 PM
To: Ajay Bhargav
Cc: u-boot at lists.denx.de; afleming at gmail.com
Subject: Re: [U-Boot] [PATCH] mmc: mv_sdhci: Fix host version read for Armada100

Quoted 3 lines
Quoted 2 lines · ----- "Marek Vasut
Quoted 2 lines
Quoted 1 line · ----- "Marek Vasut
Quoted 1 line

sdhci_readw does not work for host version read in

Armada100

Quoted 1 line
Quoted 1 line

[...]

Quoted 1 line
Quoted 1 line

Well such crippled hardware might appear somewhere else

too, so yes.

Quoted 2 lines
Quoted 2 lines

But still,
it's surprising it's only one register, really. Can you

point me to a

Quoted 6 lines
Quoted 4 lines

datasheet/errata stating it?

Thanks!

I agree, adding a quirk for this is best option this way

Quoted 8 lines

driver will still

Quoted 1 line

be generic for marvell series. Marek, I am really sorry but I

am not

Quoted 1 line

allowed to share errata here :) I will ask my senior if i can

atleast send

Quoted 1 line

you a screenshot regarding this issue.

Stupid Marvell crap again :-(

Hi Marek
I understand your concern.
Please understand there are company policies we need to follow.

Meanwhile have a look at documentation (software manual) at below pointer, if it helps you (I hope you already had it :-D )
http://www.marvell.com/application-processors/armada-100/

Copying Lei too, if he can help you further on this.

Regards..
Prafulla . .

#4 lore raw

PATCH 1/1 mmc: mv_sdhci: Fix host version read for Armada100

Quoted 42 lines
Quoted 42 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Marek Vasut
Sent: Wednesday, November 02, 2011 3:55 PM
To: Ajay Bhargav
Cc: u-boot at lists.denx.de; afleming at gmail.com
Subject: Re: [U-Boot] [PATCH] mmc: mv_sdhci: Fix host version read for Armada100

Quoted 3 lines
Quoted 2 lines · ----- "Marek Vasut
Quoted 2 lines
Quoted 1 line · ----- "Marek Vasut
Quoted 1 line

sdhci_readw does not work for host version read in

Armada100

[...]

Quoted 1 line
Quoted 1 line

Well such crippled hardware might appear somewhere else

too, so yes.

Quoted 2 lines
Quoted 2 lines

But still,
it's surprising it's only one register, really. Can you

point me to a

Quoted 5 lines
Quoted 3 lines

datasheet/errata stating it?

Thanks!

I agree, adding a quirk for this is best option this way

driver will still

Quoted 1 line

be generic for marvell series. Marek, I am really sorry but I

am not

Quoted 1 line

allowed to share errata here :) I will ask my senior if i can

atleast send

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

you a screenshot regarding this issue.

Stupid Marvell crap again :-(

Hi Marek
I understand your concern.
Please understand there are company policies we need to follow.

Which are ... see above :-)

Quoted 4 lines

Meanwhile have a look at documentation (software manual) at below pointer, if it helps you (I hope you already had it :-D )
http://www.marvell.com/application-processors/armada-100/

Good, thank you. Do you plan to release armada610 TRM too (used in OLPC 1.75) ?

Cheers

#5 lore raw

PATCH 1/1 mmc: mv_sdhci: Fix host version read for Armada100

Quoted 69 lines

-----Original Message-----
From: Marek Vasut [mailto:marek.vasut at gmail.com]
Sent: Wednesday, November 02, 2011 7:59 PM
To: Prafulla Wadaskar
Cc: Ajay Bhargav; u-boot at lists.denx.de; afleming at gmail.com; Lei Wen; Chris Ball
Subject: Re: [U-Boot] [PATCH] mmc: mv_sdhci: Fix host version read for Armada100

Quoted 7 lines
Quoted 7 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Marek Vasut
Sent: Wednesday, November 02, 2011 3:55 PM
To: Ajay Bhargav
Cc: u-boot at lists.denx.de; afleming at gmail.com
Subject: Re: [U-Boot] [PATCH] mmc: mv_sdhci: Fix host

version

Quoted 5 lines
Quoted 5 lines

read for Armada100

Quoted 3 lines
Quoted 2 lines · ----- "Marek Vasut
Quoted 2 lines
Quoted 1 line · ----- "Marek Vasut
Quoted 1 line

sdhci_readw does not work for host version read

in

Quoted 16 lines
Quoted 16 lines

Armada100

[...]

Quoted 1 line
Quoted 1 line

Well such crippled hardware might appear somewhere else

too, so yes.

Quoted 2 lines
Quoted 2 lines

But still,
it's surprising it's only one register, really. Can you

point me to a

Quoted 2 lines
Quoted 2 lines

datasheet/errata stating it?

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Thanks!

I agree, adding a quirk for this is best option this way

driver will still

Quoted 1 line

be generic for marvell series. Marek, I am really sorry

but I

Quoted 4 lines
Quoted 4 lines

am not

Quoted 1 line

allowed to share errata here :) I will ask my senior if i

can

Quoted 10 lines
Quoted 6 lines

atleast send

Quoted 1 line

you a screenshot regarding this issue.

Stupid Marvell crap again :-(

Hi Marek
I understand your concern.
Please understand there are company policies we need to

follow.

Which are ... see above :-)

Quoted 1 line
Quoted 7 lines
Quoted 1 line

Meanwhile have a look at documentation (software manual) at

below pointer,

Quoted 2 lines

if it helps you (I hope you already had it :-D )
http://www.marvell.com/application-processors/armada-100/

Good, thank you. Do you plan to release armada610 TRM too (used in OLPC 1.75) ?

I will query on this and let you know.

Regards..
Prafulla . . .