Skip to contentSkip to conversation

arm: exynos: Fix compiler error with THIS_MODULE

PATCH New Kyungmin Park 2 participants 2 messages Nov 7, 2011 – Nov 8, 2011

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 1/1 arm: exynos: Fix compiler error with THIS_MODULE

From: Kyungmin Park <[email protected]>

CC arch/arm/mach-exynos/cpuidle.o
arch/arm/mach-exynos/cpuidle.c:36: error: 'THIS_MODULE' undeclared here (not in a function) arch/arm/mach-exynos/cpuidle.c: In function 'exynos4_enter_idle':
arch/arm/mach-exynos/cpuidle.c:42: error: storage size of 'before' isn't known arch/arm/mach-exynos/cpuidle.c:42: error: storage size of 'after' isn't known arch/arm/mach-exynos/cpuidle.c:46: error: implicit declaration of function 'do_gettimeofday' arch/arm/mach-exynos/cpuidle.c:52: error: 'USEC_PER_SEC' undeclared (first use in this function) arch/arm/mach-exynos/cpuidle.c:52: error: (Each undeclared identifier is reported only once arch/arm/mach-exynos/cpuidle.c:52: error: for each function it appears in.) arch/arm/mach-exynos/cpuidle.c:42: warning: unused variable 'after' arch/arm/mach-exynos/cpuidle.c:42: warning: unused variable 'before'
make[1]: *** [arch/arm/mach-exynos/cpuidle.o] Error 1

Signed-off-by Kyungmin Park <[email protected]>

---

arch/arm/mach-exynos/cpuidle.c +1 -0
index bf7e96f..84628a8 100644
@@ -9,6 +9,7 @@
 */
 
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/cpuidle.h>
 #include <linux/io.h>
#1 lore raw

PATCH 1/1 arm: exynos: Fix compiler error with THIS_MODULE

Quoted 5 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

CC arch/arm/mach-exynos/cpuidle.o
arch/arm/mach-exynos/cpuidle.c:36: error: 'THIS_MODULE' undeclared here

(not in

Quoted 3 lines

a function)
arch/arm/mach-exynos/cpuidle.c: In function 'exynos4_enter_idle':
arch/arm/mach-exynos/cpuidle.c:42: error: storage size of 'before' isn't

known

Quoted 1 line

arch/arm/mach-exynos/cpuidle.c:42: error: storage size of 'after' isn't

known

Quoted 3 lines

arch/arm/mach-exynos/cpuidle.c:46: error: implicit declaration of function 'do_gettimeofday'
arch/arm/mach-exynos/cpuidle.c:52: error: 'USEC_PER_SEC' undeclared (first

use

Quoted 2 lines

in this function)
arch/arm/mach-exynos/cpuidle.c:52: error: (Each undeclared identifier is

reported

Quoted 2 lines

only once
arch/arm/mach-exynos/cpuidle.c:52: error: for each function it appears

in.)

Review

Quoted 7 lines

arch/arm/mach-exynos/cpuidle.c:42: warning: unused variable 'after' arch/arm/mach-exynos/cpuidle.c:42: warning: unused variable 'before' make[1]: *** [arch/arm/mach-exynos/cpuidle.o] Error 1

Signed-off-by Kyungmin Park <[email protected]>

---

(quoted diff) +0 -0

b/arch/arm/mach-exynos/cpuidle.c

arch/arm/mach-exynos/cpuidle.c line 15

Quoted 11 lines

index bf7e96f..84628a8 100644

arch/arm/mach-exynos/cpuidle.c +1 -0
@@ -9,6 +9,7 @@
 */
 
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/cpuidle.h>
 #include <linux/io.h>

Yes, that happened due to the commit 32aaeffbd4a7 (Merge branch 'modsplit-Oct31_2011'...) and I need to fix other Samsung stuff also.

OK, will apply.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.