Skip to contentSkip to conversation

BAD APICID ?

DISCUSSION Dave Jones 3 participants 4 messages Nov 7, 2011

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

We got a report from a Fedora user hitting a WARN_ON in the apic setup code.

Here..

1230 #ifdef CONFIG_X86_32
1231 /*

1232          * APIC LDR is initialized.  If logical_apicid mapping was
1233          * initialized during get_smp_config(), make sure it matches the
1234          * actual value.
1235          */
1236         i = early_per_cpu(x86_cpu_to_logical_apicid, cpu);
1237         WARN_ON(i != BAD_APICID && i != logical_smp_processor_id());
1238         /* always use the value from LDR */
1239         early_per_cpu(x86_cpu_to_logical_apicid, cpu) =

1240 logical_smp_processor_id();

The full report is at https://bugzilla.redhat.com/show_bug.cgi?id=743930

Report is against our 3.0 builds, but that code look unchanged in 3.1 too, and even in current Linus head.

Any thoughts on what could cause this ?

Dave

#1 lore raw
Quoted 14 lines · Dave Jones

We got a report from a Fedora user hitting a WARN_ON in the apic setup code.

Here..

1230 #ifdef CONFIG_X86_32
1231 /*

1232          * APIC LDR is initialized.  If logical_apicid mapping was
1233          * initialized during get_smp_config(), make sure it matches the
1234          * actual value.
1235          */
1236         i = early_per_cpu(x86_cpu_to_logical_apicid, cpu);
1237         WARN_ON(i != BAD_APICID && i != logical_smp_processor_id());
1238         /* always use the value from LDR */
1239         early_per_cpu(x86_cpu_to_logical_apicid, cpu) =
Quoted 8 lines

1240 logical_smp_processor_id();

The full report is at https://bugzilla.redhat.com/show_bug.cgi?id=743930

Report is against our 3.0 builds, but that code look unchanged in 3.1 too, and even in current Linus head.

Any thoughts on what could cause this ?

Already fixed upstream: 838312be46f3abfbdc175f81c3e54a857994476d

Here's the whole thread: http://lkml.org/lkml/2011/10/14/231

HTH.

Signature · 8 lines
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
author
#2 lore raw
Quoted 22 lines · Borislav Petkov
Quoted 21 lines · Dave Jones

We got a report from a Fedora user hitting a WARN_ON in the apic setup code.

Here..

1230 #ifdef CONFIG_X86_32
1231 /*

1232          * APIC LDR is initialized.  If logical_apicid mapping was
1233          * initialized during get_smp_config(), make sure it matches the
1234          * actual value.
1235          */
1236         i = early_per_cpu(x86_cpu_to_logical_apicid, cpu);
1237         WARN_ON(i != BAD_APICID && i != logical_smp_processor_id());
1238         /* always use the value from LDR */
1239         early_per_cpu(x86_cpu_to_logical_apicid, cpu) =

1240 logical_smp_processor_id();

The full report is at https://bugzilla.redhat.com/show_bug.cgi?id=743930

Report is against our 3.0 builds, but that code look unchanged in 3.1 too, and even in current Linus head.

Quoted 7 lines
Quoted 1 line

Any thoughts on what could cause this ?

Already fixed upstream: 838312be46f3abfbdc175f81c3e54a857994476d

Here's the whole thread: http://lkml.org/lkml/2011/10/14/231

HTH.

ah, excellent, thanks.
That seems to have not hit stable, even though it was cc'd. Greg ?

Dave

#3 lore raw
Quoted 25 lines · Dave Jones
Quoted 24 lines · Borislav Petkov
Quoted 22 lines · Dave Jones

We got a report from a Fedora user hitting a WARN_ON in the apic setup code.

Here..

1230 #ifdef CONFIG_X86_32
1231 /*

1232          * APIC LDR is initialized.  If logical_apicid mapping was
1233          * initialized during get_smp_config(), make sure it matches the
1234          * actual value.
1235          */
1236         i = early_per_cpu(x86_cpu_to_logical_apicid, cpu);
1237         WARN_ON(i != BAD_APICID && i != logical_smp_processor_id());
1238         /* always use the value from LDR */
1239         early_per_cpu(x86_cpu_to_logical_apicid, cpu) =

1240 logical_smp_processor_id();

The full report is at https://bugzilla.redhat.com/show_bug.cgi?id=743930

Report is against our 3.0 builds, but that code look unchanged in 3.1 too, and even in current Linus head.

Any thoughts on what could cause this ?

Quoted 8 lines
Quoted 5 lines

Already fixed upstream: 838312be46f3abfbdc175f81c3e54a857994476d

Here's the whole thread: http://lkml.org/lkml/2011/10/14/231

HTH.

ah, excellent, thanks.
That seems to have not hit stable, even though it was cc'd. Greg ?

It's already been queued up for the next stable release, which should be coming out later this week once the firehose of the 3.2 merge window slows down.

thanks,

greg k-h