Skip to contentSkip to conversation

Pet Peaves about Platform code, and arch_reset

PATCH New Russell King - ARM Linux 3 participants 11 messages Nov 6, 2011 – Nov 11, 2011

Subsystems (8)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos OMAP2+ support +4 more subsystems
lore
Share & tools
lore

Russell King - ARM Linux

author
#0 lore raw

Here's a list of my peaves about current platform code - which are causing me great issue when trying to clean up the arch_reset() stuff:

1. Lack of trailing ',' on structure initializers
This makes it much harder to add additional initializers at the end of existing initializers, and increases the risks of conflicts being caused due to more lines having to be modified.

(This won't work directly because the tabs have been converted to space. The empty-looking [] contain a space plus a tab.)

$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm -r|wc -l
768
$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm/*omap* -r|wc -l
325

Note that this is _far_ too big a problem - and trivial - to fix in a set of silly churn generating patches - it's a problem to be fixed as a part of _other_ changes to the files.

But most importantly _stop_ introducing versions of this problem.

2. Lack of consistent formatting for structure initializers within a mach- subdirectory. Some use tabs to align the '=' sign. Others use one space. This makes a repeated paste of a new initializer mismatch the rest of the formatting of the structure.

I _really_ don't care to fix the new initializer I'm introducing to match the random formatting within a subdirectory.

3. Files containing one data structure or function are quite an annoyance when trying to do something like move arch_reset() out of the header file into the platform .c code; this requires creating yet another file containing one function, or consolidating the platform code together first. I've fixed clps711x for that (so I can convert it), but left others.

4. People who think that include files must be stored under a directory with 'include' somewhere mentioned in its path. This is a big one and a *REAL* hate. Include files _private_ to a group of source files in a directory should live in the same directory as those files. For instance, this should be zero because the 'map_io' function should not be exported outside of the arch/arm/mach-* subdirectory:

$ grep -l map_io arch/arm/mach-*/include/mach/*.h | wc -l
21

Let's look at some specific cases:

$ grep omap15xx_map_io arch/arm/mach-omap1 arch/arm/plat-omap/ -r
arch/arm/mach-omap1/board-innovator.c:      omap15xx_map_io();
arch/arm/mach-omap1/board-palmte.c: .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-palmz71.c:        .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-voiceblue.c:      .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/io.c:void __init omap15xx_map_io(void)
arch/arm/mach-omap1/board-palmtt.c: .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-fsample.c:        omap15xx_map_io();
arch/arm/mach-omap1/board-sx1.c:    .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-ams-delta.c:      .map_io         = omap15xx_map_io,
arch/arm/plat-omap/include/plat/io.h:void omap15xx_map_io(void);
arch/arm/plat-omap/include/plat/io.h:static inline void omap15xx_map_io(void)

What is the point of the omap15xx_map_io prototype being is a _completely_ different place to where it is defined?

The problem is where do I put a function prototype for omap1_restart() amongst these header files for OMAP1 board files to pick up? Better still, don't tell me, but fix this stuff so that OMAP1 private stuff is in a 'common.h' or 'board.h' header file in arch/arm/mach-omap1.

$ grep s5pv210_init_irq arch/arm -r
arch/arm/mach-s5pv210/mach-aquila.c:        .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/mach-torbreck.c:      .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/mach-goni.c:  .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/cpu.c:void __init s5pv210_init_irq(void)
arch/arm/mach-s5pv210/mach-smdkc110.c:      .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/mach-smdkv210.c:      .init_irq       = s5pv210_init_irq,
arch/arm/plat-samsung/include/plat/s5pv210.h:extern void s5pv210_init_irq(void);

Again, what is the point of this lack of locality? And more-over, where the hell do I put a prototype for my new s5pv210_restart() which is in arch/arm/mach-s5pv210/cpu.c ? Again, don't tell me but fix stuff so that the function prototypes etc are closer to their definitions and uses.

There is no excuse for this kind of crap, other than people being sheep and following idiotic and rediculous ideas like "include files must be under a directory called include".

The arch_reset() branch, when published, will end with a commit removing the converted (and therefore empty) arch_reset() functions in mach/system.h, and its call site. Those platforms which haven't been converted will still have an arch_reset() function but this will no longer be called.

I currently have a couple of commits which move things like OMAP1 (dangling arch_reset), Exynos4 and S5PV210 (converted but missing a function prototype, and therefore fail to build) in the right direction _but_ will break because of the issues raised above, particularly (4). Whether I care to fix it depends on the reaction to this mail and whether people change their behaviour to how they lay code out.

One point to note (for those who question whether it's a good idea to touch the old code): the problem platform code is not the old stuff. The old stuff, being older, is much less complex and therefore easier to convert. What's proving to be more of a headache is the more modern and current stuff, particularly where people have decided to follow non-kernel convention about things like placement of include files.

For reference, he's the list - after five days work - of those platforms which are proving hard to convert:

arch/arm/mach-bcmring/include/mach/system.h
arch/arm/mach-davinci/include/mach/system.h
arch/arm/mach-gemini/include/mach/system.h
arch/arm/mach-ks8695/include/mach/system.h
arch/arm/mach-netx/include/mach/system.h
arch/arm/mach-nomadik/include/mach/system.h
arch/arm/mach-omap1/include/mach/system.h
arch/arm/mach-omap2/include/mach/system.h
arch/arm/mach-s3c2410/include/mach/system-reset.h
arch/arm/mach-s3c64xx/include/mach/system.h
arch/arm/mach-shmobile/include/mach/system.h
arch/arm/mach-vt8500/include/mach/system.h
arch/arm/plat-mxc/include/mach/system.h
arch/arm/plat-samsung/include/plat/system-reset.h
arch/arm/plat-tcc/include/mach/system.h

maintainer
#1 lore raw
Quoted 15 lines · Russell King - ARM Linux

Here's a list of my peaves about current platform code - which are causing me great issue when trying to clean up the arch_reset() stuff:

1. Lack of trailing ',' on structure initializers
This makes it much harder to add additional initializers at the end of existing initializers, and increases the risks of conflicts being caused due to more lines having to be modified.

(This won't work directly because the tabs have been converted to space. The empty-looking [] contain a space plus a tab.)

$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm -r|wc -l
768
$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm/*omap* -r|wc -l
325
Quoted 5 lines

Note that this is _far_ too big a problem - and trivial - to fix in a set of silly churn generating patches - it's a problem to be fixed as a part of _other_ changes to the files.

But most importantly _stop_ introducing versions of this problem.

Sounds like we need a spatch for this issue?

Quoted 7 lines

2. Lack of consistent formatting for structure initializers within a mach- subdirectory. Some use tabs to align the '=' sign. Others use one space. This makes a repeated paste of a new initializer mismatch the rest of the formatting of the structure.

I _really_ don't care to fix the new initializer I'm introducing to match the random formatting within a subdirectory.

This too could be fixes up using spatch?

Quoted 32 lines

3. Files containing one data structure or function are quite an annoyance when trying to do something like move arch_reset() out of the header file into the platform .c code; this requires creating yet another file containing one function, or consolidating the platform code together first. I've fixed clps711x for that (so I can convert it), but left others.

4. People who think that include files must be stored under a directory with 'include' somewhere mentioned in its path. This is a big one and a *REAL* hate. Include files _private_ to a group of source files in a directory should live in the same directory as those files. For instance, this should be zero because the 'map_io' function should not be exported outside of the arch/arm/mach-* subdirectory:

$ grep -l map_io arch/arm/mach-*/include/mach/*.h | wc -l
21

Let's look at some specific cases:

$ grep omap15xx_map_io arch/arm/mach-omap1 arch/arm/plat-omap/ -r
arch/arm/mach-omap1/board-innovator.c:      omap15xx_map_io();
arch/arm/mach-omap1/board-palmte.c: .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-palmz71.c:        .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-voiceblue.c:      .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/io.c:void __init omap15xx_map_io(void)
arch/arm/mach-omap1/board-palmtt.c: .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-fsample.c:        omap15xx_map_io();
arch/arm/mach-omap1/board-sx1.c:    .map_io         = omap15xx_map_io,
arch/arm/mach-omap1/board-ams-delta.c:      .map_io         = omap15xx_map_io,
arch/arm/plat-omap/include/plat/io.h:void omap15xx_map_io(void);
arch/arm/plat-omap/include/plat/io.h:static inline void omap15xx_map_io(void)
Quoted 7 lines

What is the point of the omap15xx_map_io prototype being is a _completely_ different place to where it is defined?

The problem is where do I put a function prototype for omap1_restart() amongst these header files for OMAP1 board files to pick up? Better still, don't tell me, but fix this stuff so that OMAP1 private stuff is in a 'common.h' or 'board.h' header file in arch/arm/mach-omap1.

Yeah we should add arch/arm/mach-omap1/common.h for this.

Quoted 60 lines
$ grep s5pv210_init_irq arch/arm -r
arch/arm/mach-s5pv210/mach-aquila.c:        .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/mach-torbreck.c:      .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/mach-goni.c:  .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/cpu.c:void __init s5pv210_init_irq(void)
arch/arm/mach-s5pv210/mach-smdkc110.c:      .init_irq       = s5pv210_init_irq,
arch/arm/mach-s5pv210/mach-smdkv210.c:      .init_irq       = s5pv210_init_irq,
arch/arm/plat-samsung/include/plat/s5pv210.h:extern void s5pv210_init_irq(void);

Again, what is the point of this lack of locality? And more-over, where the hell do I put a prototype for my new s5pv210_restart() which is in arch/arm/mach-s5pv210/cpu.c ? Again, don't tell me but fix stuff so that the function prototypes etc are closer to their definitions and uses.

There is no excuse for this kind of crap, other than people being sheep and following idiotic and rediculous ideas like "include files must be under a directory called include".

The arch_reset() branch, when published, will end with a commit removing the converted (and therefore empty) arch_reset() functions in mach/system.h, and its call site. Those platforms which haven't been converted will still have an arch_reset() function but this will no longer be called.

I currently have a couple of commits which move things like OMAP1 (dangling arch_reset), Exynos4 and S5PV210 (converted but missing a function prototype, and therefore fail to build) in the right direction _but_ will break because of the issues raised above, particularly (4). Whether I care to fix it depends on the reaction to this mail and whether people change their behaviour to how they lay code out.

One point to note (for those who question whether it's a good idea to touch the old code): the problem platform code is not the old stuff. The old stuff, being older, is much less complex and therefore easier to convert. What's proving to be more of a headache is the more modern and current stuff, particularly where people have decided to follow non-kernel convention about things like placement of include files.

For reference, he's the list - after five days work - of those platforms which are proving hard to convert:

arch/arm/mach-bcmring/include/mach/system.h arch/arm/mach-davinci/include/mach/system.h arch/arm/mach-gemini/include/mach/system.h arch/arm/mach-ks8695/include/mach/system.h arch/arm/mach-netx/include/mach/system.h arch/arm/mach-nomadik/include/mach/system.h arch/arm/mach-omap1/include/mach/system.h arch/arm/mach-omap2/include/mach/system.h arch/arm/mach-s3c2410/include/mach/system-reset.h arch/arm/mach-s3c64xx/include/mach/system.h arch/arm/mach-shmobile/include/mach/system.h arch/arm/mach-vt8500/include/mach/system.h arch/arm/plat-mxc/include/mach/system.h arch/arm/plat-samsung/include/plat/system-reset.h arch/arm/plat-tcc/include/mach/system.h
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#2 lore raw
Quoted 16 lines · Tony Lindgren
Quoted 15 lines · Russell King - ARM Linux

Here's a list of my peaves about current platform code - which are causing me great issue when trying to clean up the arch_reset() stuff:

1. Lack of trailing ',' on structure initializers
This makes it much harder to add additional initializers at the end of existing initializers, and increases the risks of conflicts being caused due to more lines having to be modified.

(This won't work directly because the tabs have been converted to space. The empty-looking [] contain a space plus a tab.)

$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm -r|wc -l
768
$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm/*omap* -r|wc -l
325
Quoted 7 lines
Quoted 5 lines

Note that this is _far_ too big a problem - and trivial - to fix in a set of silly churn generating patches - it's a problem to be fixed as a part of _other_ changes to the files.

But most importantly _stop_ introducing versions of this problem.

Sounds like we need a spatch for this issue?

I guess spatch would need some patching to deal with this.. I tried with something like:

@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 {
...
- .fld at p = E,
+ .fld = E,
...
};

That catches them, but adds an extra comma in the beginning :)

ams-delta-fiq.c 2011-11-08 18:04:36.094948038 -0800 renamed from ams-delta-fiq.c 2011-11-08 18:03:20.110707512 -0800 +1 -1
@@ -25,7 +25,7 @@
 #include <mach/ams-delta-fiq.h>
 
 static struct fiq_handler fh = {
-	.name	= "ams-delta-fiq"
+	,.name = "ams-delta-fiq",
 };
 
 /*

And it also messes up the formatting for other structs..

Anyways, I think I got most of these fixed for all ARM subarchitectures in a pile of 72 patches, the stats are:

486 files changed, 2296 insertions(+), 2296 deletions(-)

This is something people can then use as a base to start chipping away at the problem. I'm thinking it may be possible to use this as a base for search and replacement type work and then hopefully git mergetool will pick the relevant changes when rebasing a working branch to the mainline.

I can also post the patches here if people want, but sounds like we're not going to merge them as they are, but instead will slowly fix the issue in other related patches?

I've pushed the patches into a git branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap formatting:

Web interface at:

http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=shortlog;h=refs/heads/formatting

Regards,

Tony

#3 lore raw
Quoted 71 lines · Tony Lindgren
Quoted 16 lines · Tony Lindgren
Quoted 15 lines · Russell King - ARM Linux

Here's a list of my peaves about current platform code - which are causing me great issue when trying to clean up the arch_reset() stuff:

1. Lack of trailing ',' on structure initializers
This makes it much harder to add additional initializers at the end of existing initializers, and increases the risks of conflicts being caused due to more lines having to be modified.

(This won't work directly because the tabs have been converted to space. The empty-looking [] contain a space plus a tab.)

$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm -r|wc -l
768
$ grep '[   ][      ]*\.[[:alnum:]_][[:alnum:]_]*[  ]*=[    ]*[[:alnum:]_{][[:alnum:]_|()}]*[^,]$' arch/arm/*omap* -r|wc -l
325
Quoted 7 lines
Quoted 5 lines

Note that this is _far_ too big a problem - and trivial - to fix in a set of silly churn generating patches - it's a problem to be fixed as a part of _other_ changes to the files.

But most importantly _stop_ introducing versions of this problem.

Sounds like we need a spatch for this issue?

I guess spatch would need some patching to deal with this.. I tried with something like:

@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 {
...

(quoted diff) +1 -1
-       .fld@p = E,
+       .fld = E,
...

};

That catches them, but adds an extra comma in the beginning :)

ams-delta-fiq.c 2011-11-08 18:04:36.094948038 -0800 renamed from ams-delta-fiq.c 2011-11-08 18:03:20.110707512 -0800 +1 -1
@@ -25,7 +25,7 @@
 #include <mach/ams-delta-fiq.h>
 
 static struct fiq_handler fh = {
-	.name	= "ams-delta-fiq"
+	,.name = "ams-delta-fiq",
 };
 
 /*

And it also messes up the formatting for other structs..

Anyways, I think I got most of these fixed for all ARM subarchitectures in a pile of 72 patches, the stats are:

486 files changed, 2296 insertions(+), 2296 deletions(-)

This is something people can then use as a base to start chipping away at the problem. I'm thinking it may be possible to use this as a base for search and replacement type work and then hopefully git mergetool will pick the relevant changes when rebasing a working branch to the mainline.

I can also post the patches here if people want, but sounds like we're not going to merge them as they are, but instead will slowly fix the issue in other related patches?

Quoted 8 lines

I've pushed the patches into a git branch at:

git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap formatting:

Web interface at:

http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap.git;a=shortlog;h=refs/heads/formatting

For record, we may not want to do this for cases below, since we should never add entry after sentinel.

static const struct of_device_id imx53_iomuxc_of_match[] __initconst = {

@@ -75,7 +75,7 @@ static const struct of_device_id imx53_iomuxc_of_match[] __initconst = {
        { .compatible = "fsl,imx53-iomuxc-evk", .data = imx53_evk_common_init, },
        { .compatible = "fsl,imx53-iomuxc-qsb", .data = imx53_qsb_common_init, },
        { .compatible = "fsl,imx53-iomuxc-smd", .data = imx53_smd_common_init, },

- { /* sentinel */ }
+ { /* sentinel */ },
};

static void __init imx53_dt_init(void)

@@ -112,7 +112,7 @@ static const char *imx53_dt_board_compat[] __initdata = {
        "fsl,imx53-evk",
        "fsl,imx53-qsb",
        "fsl,imx53-smd",

- NULL
+ NULL,
};

Signature · 2 lines
Regards,
Shawn
maintainer
#4 lore raw

PATCH 1/1 ARM: OMAP: Introduce local common.h files

In reply to Tony Lindgren

As suggested by Russell King - ARM Linux <[email protected]>, there's no need to keep local prototypes in non-local headers.

Add mach-omap1/common.h and mach-omap2/common.h and move the local prototypes there from plat/common.h and mach/omap4-common.h.

Signed-off-by Tony Lindgren <[email protected]>
arch/arm/mach-omap1/board-ams-delta.c +0 -0
index 51bae31..1b37400 100644

---
Here's a patch that fixes the locality issues for MACHINE_START/END functions at least.

arch/arm/mach-omap1/board-ams-delta.c +1 -1
@@ -35,7 +35,7 @@
 #include <plat/mux.h>
 #include <plat/usb.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <mach/camera.h>
 
 #include <mach/ams-delta-fiq.h>
arch/arm/mach-omap1/board-fsample.c +1 -1
index 2317827..b9c4c0f 100644
@@ -32,7 +32,7 @@
 #include <plat/flash.h>
 #include <plat/fpga.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/board.h>
 
 /* fsample is pretty close to p2-sample */
arch/arm/mach-omap1/board-generic.c +1 -1
index dc5b75d..7f41d7a 100644
@@ -25,7 +25,7 @@
 #include <plat/mux.h>
 #include <plat/usb.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 
 /* assume no Mini-AB port */
arch/arm/mach-omap1/board-h2.c +1 -1
index b334b14..7933b97 100644
@@ -43,7 +43,7 @@
 #include <plat/irda.h>
 #include <plat/usb.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/flash.h>
 
 #include "board-h2.h"
arch/arm/mach-omap1/board-h3.c +1 -1
index 74ebe72..04be2f8 100644
@@ -45,7 +45,7 @@
 #include <plat/usb.h>
 #include <plat/keypad.h>
 #include <plat/dma.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/flash.h>
 
 #include "board-h3.h"
arch/arm/mach-omap1/board-htcherald.c +1 -1
index 3e91baa..46fcfeb 100644
@@ -41,7 +41,7 @@
 #include <asm/mach/arch.h>
 
 #include <plat/omap7xx.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/board.h>
 #include <plat/keypad.h>
 #include <plat/usb.h>
arch/arm/mach-omap1/board-innovator.c +1 -1
index 273153d..f99d11d 100644
@@ -37,7 +37,7 @@
 #include <plat/tc.h>
 #include <plat/usb.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/mmc.h>
 
 /* At OMAP1610 Innovator the Ethernet is directly connected to CS1 */
arch/arm/mach-omap1/board-nokia770.c +1 -1
index 6798b84..c643423 100644
@@ -30,7 +30,7 @@
 #include <plat/usb.h>
 #include <plat/board.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/hwa742.h>
 #include <plat/lcd_mipid.h>
 #include <plat/mmc.h>
arch/arm/mach-omap1/board-osk.c +1 -1
index c385927..a409dfc 100644
@@ -51,7 +51,7 @@
 #include <plat/usb.h>
 #include <plat/mux.h>
 #include <plat/tc.h>
-#include <plat/common.h>
+#include "common.h"
 
 /* At OMAP5912 OSK the Ethernet is directly connected to CS1 */
 #define OMAP_OSK_ETHR_START		0x04800300
arch/arm/mach-omap1/board-palmte.c +1 -1
index f9c44cb..105292d 100644
@@ -41,7 +41,7 @@
 #include <plat/board.h>
 #include <plat/irda.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 
 #define PALMTE_USBDETECT_GPIO	0
 #define PALMTE_USB_OR_DC_GPIO	1
arch/arm/mach-omap1/board-palmtt.c +1 -1
index 11a9853..387a900 100644
@@ -39,7 +39,7 @@
 #include <plat/board.h>
 #include <plat/irda.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
arch/arm/mach-omap1/board-palmz71.c +1 -1
index 4206157..df6d15e 100644
@@ -41,7 +41,7 @@
 #include <plat/board.h>
 #include <plat/irda.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 
 #include <linux/spi/spi.h>
 #include <linux/spi/ads7846.h>
arch/arm/mach-omap1/board-perseus2.c +1 -1
index 203ae07..57ecd7e 100644
@@ -32,7 +32,7 @@
 #include <plat/fpga.h>
 #include <plat/flash.h>
 #include <plat/keypad.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/board.h>
 
 static const unsigned int p2_keymap[] = {
arch/arm/mach-omap1/board-sx1.c +1 -1
index 092a4c0..774ae39 100644
@@ -40,7 +40,7 @@
 #include <plat/usb.h>
 #include <plat/tc.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/keypad.h>
 #include <plat/board-sx1.h>
arch/arm/mach-omap1/board-voiceblue.c +1 -1
index 61ed6cd..7721c14 100644
@@ -34,7 +34,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board-voiceblue.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/flash.h>
 #include <plat/mux.h>
 #include <plat/tc.h>
arch/arm/mach-omap1/common.h new file +61 -0

61 lines not on this page · raw message

arch/arm/mach-omap1/devices.c +1 -1
index 48ef988..9d47ca7 100644
@@ -22,7 +22,7 @@
 #include <mach/hardware.h>
 #include <asm/mach/map.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/tc.h>
 #include <plat/board.h>
 #include <plat/mux.h>
arch/arm/mach-omap1/time.c +1 -1
index a183777..485a21d 100644
@@ -54,7 +54,7 @@
 #include <asm/mach/irq.h>
 #include <asm/mach/time.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #ifdef CONFIG_OMAP_MPU_TIMER
arch/arm/mach-omap1/timer32k.c +1 -1
index 96604a5..9a54ef4 100644
@@ -52,7 +52,7 @@
 #include <asm/irq.h>
 #include <asm/mach/irq.h>
 #include <asm/mach/time.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/dmtimer.h>
 
 /*
arch/arm/mach-omap2/board-2430sdp.c +1 -1
index d704f0a..a17a6c4 100644
@@ -34,7 +34,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc.h>
 #include <plat/usb.h>
 #include <plat/gpmc-smc91x.h>
arch/arm/mach-omap2/board-3430sdp.c +1 -1
index 77142c1..670919c 100644
@@ -33,7 +33,7 @@
 #include <plat/mcspi.h>
 #include <plat/board.h>
 #include <plat/usb.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/dma.h>
 #include <plat/gpmc.h>
 #include <video/omapdss.h>
arch/arm/mach-omap2/board-3630sdp.c +1 -1
index f552305..63f4b4f 100644
@@ -16,7 +16,7 @@
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/board.h>
 #include <plat/gpmc-smc91x.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/board-4430sdp.c +1 -2
index 5156468..cff2e32 100644
@@ -27,13 +27,12 @@
 #include <linux/leds_pwm.h>
 
 #include <mach/hardware.h>
-#include <mach/omap4-common.h>
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/usb.h>
 #include <plat/mmc.h>
 #include <plat/omap4-keypad.h>
arch/arm/mach-omap2/board-am3517crane.c +1 -1
index 7834536..2570475 100644
@@ -27,7 +27,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/usb.h>
 
 #include "mux.h"
arch/arm/mach-omap2/board-am3517evm.c +1 -1
index d314f03..56ea011 100644
@@ -32,7 +32,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/usb.h>
 #include <video/omapdss.h>
 #include <video/omap-panel-generic-dpi.h>
arch/arm/mach-omap2/board-apollon.c +1 -1
index de8134b..9aea158 100644
@@ -37,7 +37,7 @@
 #include <plat/led.h>
 #include <plat/usb.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc.h>
 
 #include <video/omapdss.h>
arch/arm/mach-omap2/board-cm-t35.c +1 -1
index bd1bcac..e1de33e 100644
@@ -37,7 +37,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/nand.h>
 #include <plat/gpmc.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/board-cm-t3517.c +1 -1
index 3f4dc66..952df9b 100644
@@ -39,7 +39,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/usb.h>
 #include <plat/nand.h>
 #include <plat/gpmc.h>
arch/arm/mach-omap2/board-devkit8000.c +1 -1
index 90154e4..99e6e7a 100644
@@ -41,7 +41,7 @@
 #include <asm/mach/flash.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc.h>
 #include <plat/nand.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/board-generic.c +1 -2
index fb55fa3..a89d723 100644
@@ -20,8 +20,7 @@
 #include <asm/mach/arch.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
-#include <mach/omap4-common.h>
+#include "common.h"
 #include "common-board-devices.h"
 
 /*
arch/arm/mach-omap2/board-h4.c +1 -1
index 8b351d9..199a174 100644
@@ -34,7 +34,7 @@
 
 #include <plat/usb.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/menelaus.h>
 #include <plat/dma.h>
 #include <plat/gpmc.h>
arch/arm/mach-omap2/board-igep0020.c +1 -1
index d0a3f78..6434bdc 100644
@@ -28,7 +28,7 @@
 #include <asm/mach/arch.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc.h>
 #include <plat/usb.h>
 #include <video/omapdss.h>
arch/arm/mach-omap2/board-ldp.c +1 -1
index e179da0..e75102a 100644
@@ -36,7 +36,7 @@
 
 #include <plat/mcspi.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc.h>
 #include <mach/board-zoom.h>
arch/arm/mach-omap2/board-n8x0.c +1 -1
index e9d5f4a..7368614 100644
@@ -26,7 +26,7 @@
 #include <asm/mach-types.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/menelaus.h>
 #include <mach/irqs.h>
 #include <plat/mcspi.h>
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
index 4a71cb7..1843e14 100644
@@ -40,7 +40,7 @@
 #include <asm/mach/flash.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <video/omapdss.h>
 #include <video/omap-panel-dvi.h>
 #include <plat/gpmc.h>
arch/arm/mach-omap2/board-omap3evm.c +1 -1
index ec00b2e..1653d18 100644
@@ -43,7 +43,7 @@
 
 #include <plat/board.h>
 #include <plat/usb.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/mcspi.h>
 #include <video/omapdss.h>
 #include <video/omap-panel-dvi.h>
arch/arm/mach-omap2/board-omap3logic.c +1 -1
index 7c0f193..1b2a776 100644
@@ -40,7 +40,7 @@
 
 #include <plat/mux.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc-smsc911x.h>
 #include <plat/gpmc.h>
 #include <plat/sdrc.h>
arch/arm/mach-omap2/board-omap3pandora.c +1 -1
index f7811f4..6297e81 100644
@@ -41,7 +41,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <mach/hardware.h>
 #include <plat/mcspi.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/board-omap3stalker.c +1 -1
index ddb7d66..ab22647 100644
@@ -35,7 +35,7 @@
 #include <asm/mach/flash.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc.h>
 #include <plat/nand.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/board-omap3touchbook.c +1 -1
index a2d0d19..2741a34 100644
@@ -44,7 +44,7 @@
 #include <asm/mach/flash.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/gpmc.h>
 #include <plat/nand.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/board-omap4panda.c +1 -2
index a8c2c42..7722d4d 100644
@@ -30,14 +30,13 @@
 #include <linux/wl12xx.h>
 
 #include <mach/hardware.h>
-#include <mach/omap4-common.h>
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 #include <video/omapdss.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/usb.h>
 #include <plat/mmc.h>
 #include <video/omap-panel-dvi.h>
arch/arm/mach-omap2/board-overo.c +1 -1
index 4cf7aea..26c5cbb 100644
@@ -43,7 +43,7 @@
 #include <asm/mach/map.h>
 
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <video/omapdss.h>
 #include <video/omap-panel-generic-dpi.h>
 #include <video/omap-panel-dvi.h>
arch/arm/mach-omap2/board-rm680.c +1 -1
index 616fb39..6ffb640 100644
@@ -25,7 +25,7 @@
 #include <plat/mmc.h>
 #include <plat/usb.h>
 #include <plat/gpmc.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/onenand.h>
 
 #include "mux.h"
arch/arm/mach-omap2/board-rx51-peripherals.c +1 -1
index ba1aa07..bd18d69 100644
@@ -27,7 +27,7 @@
 
 #include <plat/mcspi.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/dma.h>
 #include <plat/gpmc.h>
 #include <plat/onenand.h>
arch/arm/mach-omap2/board-rx51.c +1 -1
index 4af7c4b..8477313 100644
@@ -25,7 +25,7 @@
 
 #include <plat/mcspi.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/dma.h>
 #include <plat/gpmc.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/board-ti8168evm.c +1 -1
index e6ee884..8402b39 100644
@@ -22,7 +22,7 @@
 
 #include <plat/irqs.h>
 #include <plat/board.h>
-#include <plat/common.h>
+#include "common.h"
 
 static struct omap_board_config_kernel ti8168_evm_config[] __initdata = {
 };
arch/arm/mach-omap2/board-zoom-peripherals.c +1 -1
index 6d0aa4f..8d7ce11 100644
@@ -24,7 +24,7 @@
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/usb.h>
 
 #include <mach/board-zoom.h>
arch/arm/mach-omap2/board-zoom.c +1 -1
index be6684d..bd58f92 100644
@@ -21,7 +21,7 @@
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/board.h>
 #include <plat/usb.h>
arch/arm/mach-omap2/cm2xxx_3xxx.c +1 -1
index 38830d8..04d39cd 100644
@@ -18,7 +18,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "cm.h"
 #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/cm44xx.c +1 -1
index e96f53e..6a83630 100644
@@ -18,7 +18,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "cm.h"
 #include "cm1_44xx.h"
arch/arm/mach-omap2/cminst44xx.c +1 -1
index eb2a472..6204dea 100644
@@ -20,7 +20,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "cm.h"
 #include "cm1_44xx.h"
arch/arm/mach-omap2/common.c +1 -1
index 110e5b9..684b8a7 100644
@@ -17,7 +17,7 @@
 #include <linux/clk.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/board.h>
 #include <plat/mux.h>
arch/arm/mach-omap2/common.h new file +185 -0

185 lines not on this page · raw message

arch/arm/mach-omap2/control.c +1 -1
index e34d27f..114c037 100644
@@ -15,7 +15,7 @@
 #include <linux/kernel.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/sdrc.h>
 
 #include "cm-regbits-34xx.h"
arch/arm/mach-omap2/i2c.c +1 -1
index ace9994..a12e224 100644
@@ -21,7 +21,7 @@
 
 #include <plat/cpu.h>
 #include <plat/i2c.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/omap_hwmod.h>
 
 #include "mux.h"
arch/arm/mach-omap2/id.c +1 -1
index 7f47092..27ad722 100644
@@ -21,7 +21,7 @@
 
 #include <asm/cputype.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/cpu.h>
 
 #include <mach/id.h>
arch/arm/mach-omap2/include/mach/omap4-common.h deleted +0 -43

43 lines not on this page · raw message

arch/arm/mach-omap2/io.c +2 -2
index 25d20ce..33f090c 100644
@@ -35,7 +35,7 @@
 #include "clock3xxx.h"
 #include "clock44xx.h"
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/omap-pm.h>
 #include "voltage.h"
 #include "powerdomain.h"

@@ -43,7 +43,7 @@
 #include "clockdomain.h"
 #include <plat/omap_hwmod.h>
 #include <plat/multi.h>
-#include <plat/common.h>
+#include "common.h"
 
 /*
  * The machine specific code may provide the extra mapping besides the
arch/arm/mach-omap2/omap-hotplug.c +2 -1
index 4976b93..e5a1c3f 100644
@@ -19,7 +19,8 @@
 #include <linux/smp.h>
 
 #include <asm/cacheflush.h>
-#include <mach/omap4-common.h>
+
+#include "common.h"
 
 int platform_cpu_kill(unsigned int cpu)
 {
arch/arm/mach-omap2/omap-smp.c +2 -1
index 4412ddb..e99bc6c 100644
@@ -24,7 +24,8 @@
 #include <asm/hardware/gic.h>
 #include <asm/smp_scu.h>
 #include <mach/hardware.h>
-#include <mach/omap4-common.h>
+
+#include "common.h"
 
 /* SCU base address */
 static void __iomem *scu_base;
arch/arm/mach-omap2/omap4-common.c +2 -1
index 35ac3e5..f327d74 100644
@@ -22,7 +22,8 @@
 #include <plat/irqs.h>
 
 #include <mach/hardware.h>
-#include <mach/omap4-common.h>
+
+#include "common.h"
 
 #ifdef CONFIG_CACHE_L2X0
 void __iomem *l2cache_base;
arch/arm/mach-omap2/omap_hwmod.c +1 -1
index 6b3088d..00fcd2c 100644
@@ -137,7 +137,7 @@
 #include <linux/mutex.h>
 #include <linux/spinlock.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/cpu.h>
 #include "clockdomain.h"
 #include "powerdomain.h"
arch/arm/mach-omap2/pm.c +1 -1
index 1e79bdf..e7bee5c 100644
@@ -18,7 +18,7 @@
 
 #include <plat/omap-pm.h>
 #include <plat/omap_device.h>
-#include <plat/common.h>
+#include "common.h"
 
 #include "voltage.h"
 #include "powerdomain.h"
arch/arm/mach-omap2/pm24xx.c +1 -0
index cf0c216..ef8595c 100644
@@ -42,6 +42,7 @@
 #include <plat/dma.h>
 #include <plat/board.h>
 
+#include "common.h"
 #include "prm2xxx_3xxx.h"
 #include "prm-regbits-24xx.h"
 #include "cm2xxx_3xxx.h"
arch/arm/mach-omap2/pm34xx.c +1 -0
index efa6649..fa637df 100644
@@ -42,6 +42,7 @@
 #include <plat/gpmc.h>
 #include <plat/dma.h>
 
+#include "common.h"
 #include "cm2xxx_3xxx.h"
 #include "cm-regbits-34xx.h"
 #include "prm-regbits-34xx.h"
arch/arm/mach-omap2/pm44xx.c +1 -1
index 59a870b..8edb015 100644
@@ -16,8 +16,8 @@
 #include <linux/err.h>
 #include <linux/slab.h>
 
+#include "common.h"
 #include "powerdomain.h"
-#include <mach/omap4-common.h>
 
 struct power_state {
 	struct powerdomain *pwrdm;
arch/arm/mach-omap2/prcm.c +1 -1
index 597e2da..c35e5ce 100644
@@ -26,7 +26,7 @@
 #include <linux/export.h>
 
 #include <mach/system.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/prcm.h>
 #include <plat/irqs.h>
arch/arm/mach-omap2/prcm_mpu44xx.c +1 -1
index 171fe17..ca669b5 100644
@@ -15,7 +15,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prcm_mpu44xx.h"
 #include "cm-regbits-44xx.h"
arch/arm/mach-omap2/prm2xxx_3xxx.c +1 -1
index f02d87f..9a08ba3 100644
@@ -16,7 +16,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/cpu.h>
 #include <plat/prcm.h>
arch/arm/mach-omap2/prm44xx.c +1 -1
index 495a31a..dd885ee 100644
@@ -17,7 +17,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/cpu.h>
 #include <plat/prcm.h>
arch/arm/mach-omap2/prminst44xx.c +1 -1
index 3a7bab1..f6de5bc 100644
@@ -16,7 +16,7 @@
 #include <linux/err.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prm44xx.h"
 #include "prminst44xx.h"
arch/arm/mach-omap2/sdram-nokia.c +1 -1
index 14caa22..ee3a8ad 100644
@@ -18,7 +18,7 @@
 #include <linux/io.h>
 
 #include <plat/io.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/clock.h>
 #include <plat/sdrc.h>
arch/arm/mach-omap2/sdrc.c +1 -1
index 8f27828..e3d345f 100644
@@ -23,7 +23,7 @@
 #include <linux/clk.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/clock.h>
 #include <plat/sram.h>
arch/arm/mach-omap2/sdrc2xxx.c +1 -1
index ccdb010..791a63c 100644
@@ -24,7 +24,7 @@
 #include <linux/clk.h>
 #include <linux/io.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/clock.h>
 #include <plat/sram.h>
arch/arm/mach-omap2/serial.c +1 -1
index 9992dbf..42c3267 100644
@@ -33,7 +33,7 @@
 #include <plat/omap-serial.h>
 #endif
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/board.h>
 #include <plat/clock.h>
 #include <plat/dma.h>
arch/arm/mach-omap2/smartreflex.c +1 -1
index 6a4f683..919d827 100644
@@ -26,7 +26,7 @@
 #include <linux/slab.h>
 #include <linux/pm_runtime.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "pm.h"
 #include "smartreflex.h"
arch/arm/mach-omap2/timer.c +1 -1
index 037b0d7..9edcd52 100644
@@ -41,7 +41,7 @@
 #include <plat/dmtimer.h>
 #include <asm/localtimer.h>
 #include <asm/sched_clock.h>
-#include <plat/common.h>
+#include "common.h"
 #include <plat/omap_hwmod.h>
 #include <plat/omap_device.h>
 #include <plat/omap-pm.h>
arch/arm/mach-omap2/vc3xxx_data.c +1 -1
index cfe348e..a5ec7f8 100644
@@ -18,7 +18,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prm-regbits-34xx.h"
 #include "voltage.h"
arch/arm/mach-omap2/vc44xx_data.c +1 -1
index 2740a96..d70b930 100644
@@ -18,7 +18,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prm44xx.h"
 #include "prm-regbits-44xx.h"
arch/arm/mach-omap2/voltage.c +1 -1
index 1f8fdf7..8a36342 100644
@@ -27,7 +27,7 @@
 #include <linux/slab.h>
 #include <linux/clk.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prm-regbits-34xx.h"
 #include "prm-regbits-44xx.h"
arch/arm/mach-omap2/voltagedomains3xxx_data.c +1 -1
index 071101d..474559d 100644
@@ -18,7 +18,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 
-#include <plat/common.h>
+#include "common.h"
 #include <plat/cpu.h>
 
 #include "prm-regbits-34xx.h"
arch/arm/mach-omap2/voltagedomains44xx_data.c +1 -1
index c4584e9..4e11d02 100644
@@ -21,7 +21,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prm-regbits-44xx.h"
 #include "prm44xx.h"
arch/arm/mach-omap2/vp.c +1 -1
index 66bd700..807391d 100644
@@ -1,7 +1,7 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "voltage.h"
 #include "vp.h"
arch/arm/mach-omap2/vp3xxx_data.c +1 -1
index 260c554..bd89f80 100644
@@ -19,7 +19,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prm-regbits-34xx.h"
 #include "voltage.h"
arch/arm/mach-omap2/vp44xx_data.c +1 -1
index b4e7704..8c031d1 100644
@@ -19,7 +19,7 @@
 #include <linux/err.h>
 #include <linux/init.h>
 
-#include <plat/common.h>
+#include "common.h"
 
 #include "prm44xx.h"
 #include "prm-regbits-44xx.h"
arch/arm/plat-omap/include/plat/common.h +0 -82

94 lines not on this page · raw message

arch/arm/plat-omap/include/plat/io.h +0 -68

74 lines not on this page · raw message

arch/arm/plat-omap/include/plat/irqs.h +0 -10
index 30e1071..d3a9fcd 100644
@@ -438,16 +438,6 @@
 
 #ifndef __ASSEMBLY__
 extern void __iomem *omap_irq_base;
-void omap1_init_irq(void);
-void omap2_init_irq(void);
-void omap3_init_irq(void);
-void ti816x_init_irq(void);
-extern int omap_irq_pending(void);
-void omap_intc_save_context(void);
-void omap_intc_restore_context(void);
-void omap3_intc_suspend(void);
-void omap3_intc_prepare_idle(void);
-void omap3_intc_resume_idle(void);
 #endif
 
 #include <mach/hardware.h>
author
#5 lore raw

PATCH 1/1 ARM: OMAP: Introduce local common.h files

Quoted 7 lines · Tony Lindgren

As suggested by Russell King - ARM Linux <[email protected]>, there's no need to keep local prototypes in non-local headers.

Add mach-omap1/common.h and mach-omap2/common.h and move the local prototypes there from plat/common.h and mach/omap4-common.h.

Signed-off-by Tony Lindgren <[email protected]>

Great, looks fine, thanks. I suspect the chance of conflicts on this are about the same as the chance of conflicts with the rest of the restart series (in that, new platforms will need to be fixed for both these changes.)

So, I suggest that I add it to my series so I can fix the OMAP changes there so stuff still builds - and then I can see about publishing a more stable branch in a couple of weeks for new platforms to base on.

If you agree, could you put it in the patch system please? Thanks.

maintainer
#6 lore raw

PATCH 1/1 ARM: OMAP: Introduce local common.h files

Quoted 9 lines · Russell King - ARM Linux
Quoted 7 lines · Tony Lindgren

As suggested by Russell King - ARM Linux <[email protected]>, there's no need to keep local prototypes in non-local headers.

Add mach-omap1/common.h and mach-omap2/common.h and move the local prototypes there from plat/common.h and mach/omap4-common.h.

Signed-off-by Tony Lindgren <[email protected]>
Quoted 8 lines

Great, looks fine, thanks. I suspect the chance of conflicts on this are about the same as the chance of conflicts with the rest of the restart series (in that, new platforms will need to be fixed for both these changes.)

So, I suggest that I add it to my series so I can fix the OMAP changes there so stuff still builds - and then I can see about publishing a more stable branch in a couple of weeks for new platforms to base on.

OK, a stable branch is needed badly for this.. If possible please publish some minimal stable base branch as soon as you can as pretty much all omap patches need to be updated for this one.

Quoted 1 line

If you agree, could you put it in the patch system please? Thanks.

Sounds good to me, it there now as patch 7159/1.

Regards,

Tony

author
#7 lore raw

PATCH 1/1 ARM: OMAP: Introduce local common.h files

Quoted 15 lines · Tony Lindgren
Quoted 14 lines · Russell King - ARM Linux
Quoted 7 lines · Tony Lindgren

As suggested by Russell King - ARM Linux <[email protected]>, there's no need to keep local prototypes in non-local headers.

Add mach-omap1/common.h and mach-omap2/common.h and move the local prototypes there from plat/common.h and mach/omap4-common.h.

Signed-off-by Tony Lindgren <[email protected]>

Great, looks fine, thanks. I suspect the chance of conflicts on this are about the same as the chance of conflicts with the rest of the restart series (in that, new platforms will need to be fixed for both these changes.)

Quoted 7 lines
Quoted 3 lines

So, I suggest that I add it to my series so I can fix the OMAP changes there so stuff still builds - and then I can see about publishing a more stable branch in a couple of weeks for new platforms to base on.

OK, a stable branch is needed badly for this.. If possible please publish some minimal stable base branch as soon as you can as pretty much all omap patches need to be updated for this one.

I want to give it something between a week and two before closing the window for acked-bys etc (amongst other reasons).

Quoted 3 lines
Quoted 1 line

If you agree, could you put it in the patch system please? Thanks.

Sounds good to me, it there now as patch 7159/1.

Thanks, merged that into the series. The updated OMAP patch updated is below, which has been moved to part 2. Lastly, the final patch of part 2 has been updated to delete the empty arch_reset(), so OMAP is now entirely free of arch_reset() references. This leaves a total of 12 references left to nobble.

8<---
From: Russell King - ARM Linux <[email protected]>
Subject: [PATCH] ARM: restart: omap: use new restart hook

Hook these platforms restart code into the new restart hook rather than using arch_reset().

Signed-off-by Russell King <[email protected]>
---
 arch/arm/mach-omap1/board-ams-delta.c      |    1 +
 arch/arm/mach-omap1/board-fsample.c        |    1 +
 arch/arm/mach-omap1/board-generic.c        |    1 +
 arch/arm/mach-omap1/board-h2.c             |    1 +
 arch/arm/mach-omap1/board-h3.c             |    1 +
 arch/arm/mach-omap1/board-htcherald.c      |    1 +
 arch/arm/mach-omap1/board-innovator.c      |    1 +
 arch/arm/mach-omap1/board-nokia770.c       |    1 +
 arch/arm/mach-omap1/board-osk.c            |    1 +
 arch/arm/mach-omap1/board-palmte.c         |    1 +
 arch/arm/mach-omap1/board-palmtt.c         |    1 +
 arch/arm/mach-omap1/board-palmz71.c        |    1 +
 arch/arm/mach-omap1/board-perseus2.c       |    1 +
 arch/arm/mach-omap1/board-sx1.c            |    1 +
 arch/arm/mach-omap1/board-voiceblue.c      |    5 ++---
 arch/arm/mach-omap1/common.h               |    1 +
 arch/arm/mach-omap1/reset.c                |    4 +---
 arch/arm/mach-omap2/board-2430sdp.c        |    1 +
 arch/arm/mach-omap2/board-3430sdp.c        |    1 +
 arch/arm/mach-omap2/board-3630sdp.c        |    1 +
 arch/arm/mach-omap2/board-4430sdp.c        |    1 +
 arch/arm/mach-omap2/board-am3517crane.c    |    1 +
 arch/arm/mach-omap2/board-am3517evm.c      |    1 +
 arch/arm/mach-omap2/board-apollon.c        |    1 +
 arch/arm/mach-omap2/board-cm-t35.c         |    2 ++
 arch/arm/mach-omap2/board-cm-t3517.c       |    1 +
 arch/arm/mach-omap2/board-devkit8000.c     |    1 +
 arch/arm/mach-omap2/board-generic.c        |    4 ++++
 arch/arm/mach-omap2/board-h4.c             |    1 +
 arch/arm/mach-omap2/board-igep0020.c       |    2 ++
 arch/arm/mach-omap2/board-ldp.c            |    1 +
 arch/arm/mach-omap2/board-n8x0.c           |    3 +++
 arch/arm/mach-omap2/board-omap3beagle.c    |    1 +
 arch/arm/mach-omap2/board-omap3evm.c       |    1 +
 arch/arm/mach-omap2/board-omap3logic.c     |    2 ++
 arch/arm/mach-omap2/board-omap3pandora.c   |    1 +
 arch/arm/mach-omap2/board-omap3stalker.c   |    1 +
 arch/arm/mach-omap2/board-omap3touchbook.c |    1 +
 arch/arm/mach-omap2/board-omap4panda.c     |    1 +
 arch/arm/mach-omap2/board-overo.c          |    1 +
 arch/arm/mach-omap2/board-rm680.c          |    1 +
 arch/arm/mach-omap2/board-rx51.c           |    1 +
 arch/arm/mach-omap2/board-ti8168evm.c      |    1 +
 arch/arm/mach-omap2/board-zoom.c           |    2 ++
 arch/arm/mach-omap2/common.h               |    1 +
 arch/arm/mach-omap2/prcm.c                 |    4 +---
 arch/arm/plat-omap/include/plat/system.h   |    4 +++-
 47 files changed, 59 insertions(+), 10 deletions(-)
arch/arm/mach-omap1/board-ams-delta.c +1 -0
index 1b37400..2120369 100644
@@ -382,6 +382,7 @@ MACHINE_START(AMS_DELTA, "Amstrad E3 (Delta)")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= ams_delta_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
 
 EXPORT_SYMBOL(ams_delta_latch1_write);
arch/arm/mach-omap1/board-fsample.c +1 -0
index b9c4c0f..0b9464b 100644
@@ -390,4 +390,5 @@ MACHINE_START(OMAP_FSAMPLE, "OMAP730 F-Sample")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_fsample_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-generic.c +1 -0
index 7f41d7a..9a5fe58 100644
@@ -89,4 +89,5 @@ MACHINE_START(OMAP_GENERIC, "Generic OMAP1510/1610/1710")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_generic_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-h2.c +1 -0
index 7933b97..00ad6b2 100644
@@ -456,4 +456,5 @@ MACHINE_START(OMAP_H2, "TI-H2")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= h2_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-h3.c +1 -0
index 04be2f8..4a7f251 100644
@@ -444,4 +444,5 @@ MACHINE_START(OMAP_H3, "TI OMAP1710 H3 board")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= h3_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-htcherald.c +1 -0
index 46fcfeb..731cc3d 100644
@@ -610,4 +610,5 @@ MACHINE_START(HERALD, "HTC Herald")
 	.init_irq       = omap1_init_irq,
 	.init_machine   = htcherald_init,
 	.timer          = &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-innovator.c +1 -0
index f99d11d..309369e 100644
@@ -460,4 +460,5 @@ MACHINE_START(OMAP_INNOVATOR, "TI-Innovator")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= innovator_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-nokia770.c +1 -0
index c643423..f9efc03 100644
@@ -259,4 +259,5 @@ MACHINE_START(NOKIA770, "Nokia 770")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_nokia770_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-osk.c +1 -0
index a409dfc..675de06 100644
@@ -578,4 +578,5 @@ MACHINE_START(OMAP_OSK, "TI-OSK")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= osk_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-palmte.c +1 -0
index 105292d..81fa27f 100644
@@ -270,4 +270,5 @@ MACHINE_START(OMAP_PALMTE, "OMAP310 based Palm Tungsten E")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_palmte_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-palmtt.c +1 -0
index 387a900..81cb821 100644
@@ -317,4 +317,5 @@ MACHINE_START(OMAP_PALMTT, "OMAP1510 based Palm Tungsten|T")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_palmtt_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-palmz71.c +1 -0
index df6d15e..e881945 100644
@@ -334,4 +334,5 @@ MACHINE_START(OMAP_PALMZ71, "OMAP310 based Palm Zire71")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_palmz71_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-perseus2.c +1 -0
index 57ecd7e..c000bed 100644
@@ -352,4 +352,5 @@ MACHINE_START(OMAP_PERSEUS2, "OMAP730 Perseus2")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_perseus2_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-sx1.c +1 -0
index 774ae39..7bcd82a 100644
@@ -416,4 +416,5 @@ MACHINE_START(SX1, "OMAP310 based Siemens SX1")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= omap_sx1_init,
 	.timer		= &omap1_timer,
+	.restart	= omap1_restart,
 MACHINE_END
arch/arm/mach-omap1/board-voiceblue.c +2 -3
index 7721c14..fb61434 100644
@@ -221,7 +221,7 @@ void voiceblue_wdt_ping(void)
 	gpio_set_value(0, wdt_gpio_state);
 }
 
-static void voiceblue_reset(char mode, const char *cmd)
+static void voiceblue_restart(char mode, const char *cmd)
 {
 	/*
 	 * Workaround for 5912/1611b bug mentioned in sprz209d.pdf p. 28

@@ -285,8 +285,6 @@ static void __init voiceblue_init(void)
 	 * (it is connected through invertor) */
 	omap_writeb(0x00, OMAP_LPG1_LCR);
 	omap_writeb(0x00, OMAP_LPG1_PMR);	/* Disable clock */
-
-	arch_reset = voiceblue_reset;
 }
 
 MACHINE_START(VOICEBLUE, "VoiceBlue OMAP5910")

@@ -298,4 +296,5 @@ MACHINE_START(VOICEBLUE, "VoiceBlue OMAP5910")
 	.init_irq	= omap1_init_irq,
 	.init_machine	= voiceblue_init,
 	.timer		= &omap1_timer,
+	.restart	= voiceblue_restart,
 MACHINE_END
arch/arm/mach-omap1/common.h +1 -0
index 52c4eda..a9a5146 100644
@@ -54,6 +54,7 @@ static inline void omap16xx_map_io(void)
 
 void omap1_init_early(void);
 void omap1_init_irq(void);
+void omap1_restart(char, const char *);
 
 extern struct sys_timer omap1_timer;
 extern bool omap_32k_timer_init(void);
arch/arm/mach-omap1/reset.c +1 -3
index ad951ee..8b1cc6e 100644
@@ -8,7 +8,7 @@
 #include <mach/system.h>
 #include <plat/prcm.h>
 
-void omap1_arch_reset(char mode, const char *cmd)
+void omap1_restart(char mode, const char *cmd)
 {
 	/*
 	 * Workaround for 5912/1611b bug mentioned in sprz209d.pdf p. 28

@@ -21,5 +21,3 @@ void omap1_arch_reset(char mode, const char *cmd)
 
 	omap_writew(1, ARM_RSTCT1);
 }
-
-void (*arch_reset)(char, const char *) = omap1_arch_reset;
arch/arm/mach-omap2/board-2430sdp.c +1 -0
index a17a6c4..2e73024 100644
@@ -303,4 +303,5 @@ MACHINE_START(OMAP_2430SDP, "OMAP2430 sdp2430 board")
 	.init_irq	= omap2_init_irq,
 	.init_machine	= omap_2430sdp_init,
 	.timer		= &omap2_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-3430sdp.c +1 -0
index 670919c..7111677 100644
@@ -730,4 +730,5 @@ MACHINE_START(OMAP_3430SDP, "OMAP3430 3430SDP board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap_3430sdp_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-3630sdp.c +1 -0
index 63f4b4f..a01d081 100644
@@ -217,4 +217,5 @@ MACHINE_START(OMAP_3630SDP, "OMAP 3630SDP board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap_sdp_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-4430sdp.c +1 -0
index cff2e32..8a46ad8 100644
@@ -985,4 +985,5 @@ MACHINE_START(OMAP_4430SDP, "OMAP4430 4430SDP board")
 	.init_irq	= gic_init_irq,
 	.init_machine	= omap_4430sdp_init,
 	.timer		= &omap4_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-am3517crane.c +1 -0
index 2570475..c1d6b63 100644
@@ -100,4 +100,5 @@ MACHINE_START(CRANEBOARD, "AM3517/05 CRANEBOARD")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= am3517_crane_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-am3517evm.c +1 -0
index 56ea011..18c0790 100644
@@ -493,4 +493,5 @@ MACHINE_START(OMAP3517EVM, "OMAP3517/AM3517 EVM")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= am3517_evm_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-apollon.c +1 -0
index 9aea158..75c731c 100644
@@ -356,4 +356,5 @@ MACHINE_START(OMAP_APOLLON, "OMAP24xx Apollon")
 	.init_irq	= omap2_init_irq,
 	.init_machine	= omap_apollon_init,
 	.timer		= &omap2_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-cm-t35.c +2 -0
index e1de33e..c3402cd 100644
@@ -636,6 +636,7 @@ MACHINE_START(CM_T35, "Compulab CM-T35")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= cm_t35_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 
 MACHINE_START(CM_T3730, "Compulab CM-T3730")

@@ -646,4 +647,5 @@ MACHINE_START(CM_T3730, "Compulab CM-T3730")
 	.init_irq       = omap3_init_irq,
 	.init_machine   = cm_t3730_init,
 	.timer          = &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-cm-t3517.c +1 -0
index 952df9b..0b06ac3 100644
@@ -301,4 +301,5 @@ MACHINE_START(CM_T3517, "Compulab CM-T3517")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= cm_t3517_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-devkit8000.c +1 -0
index 99e6e7a..519e5f9 100644
@@ -662,4 +662,5 @@ MACHINE_START(DEVKIT8000, "OMAP3 Devkit8000")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= devkit8000_init,
 	.timer		= &omap3_secure_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-generic.c +4 -0
index a89d723..f462d8c 100644
@@ -106,6 +106,7 @@ DT_MACHINE_START(OMAP242X_DT, "Generic OMAP2420 (Flattened Device Tree)")
 	.init_machine	= omap_generic_init,
 	.timer		= &omap2_timer,
 	.dt_compat	= omap242x_boards_compat,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 #endif
 

@@ -124,6 +125,7 @@ DT_MACHINE_START(OMAP243X_DT, "Generic OMAP2430 (Flattened Device Tree)")
 	.init_machine	= omap_generic_init,
 	.timer		= &omap2_timer,
 	.dt_compat	= omap243x_boards_compat,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 #endif
 

@@ -142,6 +144,7 @@ DT_MACHINE_START(OMAP3_DT, "Generic OMAP3 (Flattened Device Tree)")
 	.init_machine	= omap3_init,
 	.timer		= &omap3_timer,
 	.dt_compat	= omap3_boards_compat,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 #endif
 

@@ -160,5 +163,6 @@ DT_MACHINE_START(OMAP4_DT, "Generic OMAP4 (Flattened Device Tree)")
 	.init_machine	= omap4_init,
 	.timer		= &omap4_timer,
 	.dt_compat	= omap4_boards_compat,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 #endif
arch/arm/mach-omap2/board-h4.c +1 -0
index 199a174..34ccde4 100644
@@ -398,4 +398,5 @@ MACHINE_START(OMAP_H4, "OMAP2420 H4 board")
 	.init_irq	= omap2_init_irq,
 	.init_machine	= omap_h4_init,
 	.timer		= &omap2_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-igep0020.c +2 -0
index 6434bdc..e1850d5 100644
@@ -674,6 +674,7 @@ MACHINE_START(IGEP0020, "IGEP v2 board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= igep_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 
 MACHINE_START(IGEP0030, "IGEP OMAP3 module")

@@ -684,4 +685,5 @@ MACHINE_START(IGEP0030, "IGEP OMAP3 module")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= igep_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-ldp.c +1 -0
index e75102a..84bbdd6 100644
@@ -436,4 +436,5 @@ MACHINE_START(OMAP_LDP, "OMAP LDP board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap_ldp_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-n8x0.c +3 -0
index 7368614..cc1dd54 100644
@@ -691,6 +691,7 @@ MACHINE_START(NOKIA_N800, "Nokia N800")
 	.init_irq	= omap2_init_irq,
 	.init_machine	= n8x0_init_machine,
 	.timer		= &omap2_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 
 MACHINE_START(NOKIA_N810, "Nokia N810")

@@ -701,6 +702,7 @@ MACHINE_START(NOKIA_N810, "Nokia N810")
 	.init_irq	= omap2_init_irq,
 	.init_machine	= n8x0_init_machine,
 	.timer		= &omap2_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 
 MACHINE_START(NOKIA_N810_WIMAX, "Nokia N810 WiMAX")

@@ -711,4 +713,5 @@ MACHINE_START(NOKIA_N810_WIMAX, "Nokia N810 WiMAX")
 	.init_irq	= omap2_init_irq,
 	.init_machine	= n8x0_init_machine,
 	.timer		= &omap2_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-omap3beagle.c +1 -0
index 1843e14..bb6031f 100644
@@ -561,4 +561,5 @@ MACHINE_START(OMAP3_BEAGLE, "OMAP3 Beagle Board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap3_beagle_init,
 	.timer		= &omap3_secure_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-omap3evm.c +1 -0
index 1653d18..60912e4 100644
@@ -683,4 +683,5 @@ MACHINE_START(OMAP3EVM, "OMAP3 EVM")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap3_evm_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-omap3logic.c +2 -0
index 1b2a776..7ecf04a 100644
@@ -210,6 +210,7 @@ MACHINE_START(OMAP3_TORPEDO, "Logic OMAP3 Torpedo board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap3logic_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 
 MACHINE_START(OMAP3530_LV_SOM, "OMAP Logic 3530 LV SOM board")

@@ -219,4 +220,5 @@ MACHINE_START(OMAP3530_LV_SOM, "OMAP Logic 3530 LV SOM board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap3logic_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-omap3pandora.c +1 -0
index 6297e81..7071a24 100644
@@ -608,4 +608,5 @@ MACHINE_START(OMAP3_PANDORA, "Pandora Handheld Console")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap3pandora_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-omap3stalker.c +1 -0
index ab22647..6e47987 100644
@@ -456,4 +456,5 @@ MACHINE_START(SBC3530, "OMAP3 STALKER")
 	.init_irq		= omap3_init_irq,
 	.init_machine		= omap3_stalker_init,
 	.timer			= &omap3_secure_timer,
+	.restart		= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-omap3touchbook.c +1 -0
index 2741a34..5bb590a 100644
@@ -383,4 +383,5 @@ MACHINE_START(TOUCHBOOK, "OMAP3 touchbook Board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap3_touchbook_init,
 	.timer		= &omap3_secure_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-omap4panda.c +1 -0
index 7722d4d..955cbee 100644
@@ -578,4 +578,5 @@ MACHINE_START(OMAP4_PANDA, "OMAP4 Panda board")
 	.init_irq	= gic_init_irq,
 	.init_machine	= omap4_panda_init,
 	.timer		= &omap4_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-overo.c +1 -0
index 26c5cbb..c14d781 100644
@@ -564,4 +564,5 @@ MACHINE_START(OVERO, "Gumstix Overo")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= overo_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-rm680.c +1 -0
index 6ffb640..0c67ecc 100644
@@ -151,4 +151,5 @@ MACHINE_START(NOKIA_RM680, "Nokia RM-680 board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= rm680_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-rx51.c +1 -0
index 8477313..c3e716a 100644
@@ -129,4 +129,5 @@ MACHINE_START(NOKIA_RX51, "Nokia RX-51 board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= rx51_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-ti8168evm.c +1 -0
index 8402b39..74713e3 100644
@@ -48,4 +48,5 @@ MACHINE_START(TI8168EVM, "ti8168evm")
 	.init_irq	= ti816x_init_irq,
 	.timer		= &omap3_timer,
 	.init_machine	= ti8168_evm_init,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/board-zoom.c +2 -0
index bd58f92..68d6f1c 100644
@@ -137,6 +137,7 @@ MACHINE_START(OMAP_ZOOM2, "OMAP Zoom2 board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap_zoom_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
 
 MACHINE_START(OMAP_ZOOM3, "OMAP Zoom3 board")

@@ -147,4 +148,5 @@ MACHINE_START(OMAP_ZOOM3, "OMAP Zoom3 board")
 	.init_irq	= omap3_init_irq,
 	.init_machine	= omap_zoom_init,
 	.timer		= &omap3_timer,
+	.restart	= omap_prcm_restart,
 MACHINE_END
arch/arm/mach-omap2/common.h +1 -0
index 950b39d..1df1b39 100644
@@ -84,6 +84,7 @@ void omap3_init_early(void);	/* Do not use this one */
 void am35xx_init_early(void);
 void ti816x_init_early(void);
 void omap4430_init_early(void);
+void omap_prcm_restart(char, const char *);
 
 /*
  * IO bases for various OMAP processors
arch/arm/mach-omap2/prcm.c +1 -3
index c35e5ce..b6c8cb5 100644
@@ -59,7 +59,7 @@ u32 omap_prcm_get_reset_sources(void)
 EXPORT_SYMBOL(omap_prcm_get_reset_sources);
 
 /* Resets clock rates and reboots the system. Only called from system.h */
-static void omap_prcm_arch_reset(char mode, const char *cmd)
+void omap_prcm_restart(char mode, const char *cmd)
 {
 	s16 prcm_offs = 0;
 

@@ -110,8 +110,6 @@ static void omap_prcm_arch_reset(char mode, const char *cmd)
 	omap2_prm_read_mod_reg(prcm_offs, OMAP2_RM_RSTCTRL); /* OCP barrier */
 }
 
-void (*arch_reset)(char, const char *) = omap_prcm_arch_reset;
-
 /**
  * omap2_cm_wait_idlest - wait for IDLEST bit to indicate module readiness
  * @reg: physical address of module IDLEST register
arch/arm/plat-omap/include/plat/system.h +3 -1
index c5fa9e9..910f15f 100644
@@ -12,6 +12,8 @@ static inline void arch_idle(void)
 	cpu_do_idle();
 }
 
-extern void (*arch_reset)(char, const char *);
+static inline void arch_reset(char mode, const char *cmd)
+{
+}
 
 #endif
Signature · 1 line
1.7.4.4
maintainer
#8 lore raw

PATCH 1/1 ARM: OMAP: Introduce local common.h files

Quoted 9 lines · Russell King - ARM Linux
Quoted 5 lines · Tony Lindgren

* Russell King - ARM Linux <[email protected]> [111110 11:49]:

OK, a stable branch is needed badly for this.. If possible please publish some minimal stable base branch as soon as you can as pretty much all omap patches need to be updated for this one.

I want to give it something between a week and two before closing the window for acked-bys etc (amongst other reasons).

OK

Quoted 9 lines
Quoted 3 lines
Quoted 1 line

If you agree, could you put it in the patch system please? Thanks.

Sounds good to me, it there now as patch 7159/1.

Thanks, merged that into the series. The updated OMAP patch updated is below, which has been moved to part 2. Lastly, the final patch of part 2 has been updated to delete the empty arch_reset(), so OMAP is now entirely free of arch_reset() references. This leaves a total of 12 references left to nobble.

Great, good to hear.

Quoted 8 lines

8<---
From: Russell King - ARM Linux <[email protected]>
Subject: [PATCH] ARM: restart: omap: use new restart hook

Hook these platforms restart code into the new restart hook rather than using arch_reset().

Signed-off-by Russell King <[email protected]>
Acked-by Tony Lindgren <[email protected]>
author
#9 lore raw

PATCH 1/1 ARM: OMAP: Introduce local common.h files

Quoted 8 lines · Tony Lindgren
Quoted 5 lines · Russell King - ARM Linux

Thanks, merged that into the series. The updated OMAP patch updated is below, which has been moved to part 2. Lastly, the final patch of part 2 has been updated to delete the empty arch_reset(), so OMAP is now entirely free of arch_reset() references. This leaves a total of 12 references left to nobble.

Great, good to hear.

I've added this to the patch, as these no longer need to include this header.

arch/arm/mach-omap1/board-voiceblue.c +0 -1
index fb61434..f83a502d 100644
@@ -28,7 +28,6 @@
 #include <linux/export.h>
 
 #include <mach/hardware.h>
-#include <mach/system.h>
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
arch/arm/mach-omap1/reset.c +0 -1
index 8b1cc6e..91d199b 100644
@@ -5,7 +5,6 @@
 #include <linux/io.h>
 
 #include <mach/hardware.h>
-#include <mach/system.h>
 #include <plat/prcm.h>
 
 void omap1_restart(char mode, const char *cmd)
arch/arm/mach-omap2/prcm.c +0 -1
index b6c8cb5..626acfa 100644
@@ -25,7 +25,6 @@
 #include <linux/delay.h>
 #include <linux/export.h>
 
-#include <mach/system.h>
 #include "common.h"
 #include <plat/prcm.h>
 #include <plat/irqs.h>
maintainer
#10 lore raw

PATCH 1/1 ARM: OMAP: Introduce local common.h files

Quoted 8 lines · Russell King - ARM Linux
Quoted 7 lines · Tony Lindgren
Quoted 5 lines · Russell King - ARM Linux

Thanks, merged that into the series. The updated OMAP patch updated is below, which has been moved to part 2. Lastly, the final patch of part 2 has been updated to delete the empty arch_reset(), so OMAP is now entirely free of arch_reset() references. This leaves a total of 12 references left to nobble.

Quoted 4 lines
Quoted 1 line

Great, good to hear.

I've added this to the patch, as these no longer need to include this header.

OK thanks.

Tony

Quoted 37 lines
arch/arm/mach-omap1/board-voiceblue.c +0 -1
index fb61434..f83a502d 100644
@@ -28,7 +28,6 @@
 #include <linux/export.h>
 
 #include <mach/hardware.h>
-#include <mach/system.h>
 #include <asm/mach-types.h>
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
arch/arm/mach-omap1/reset.c +0 -1
index 8b1cc6e..91d199b 100644
@@ -5,7 +5,6 @@
 #include <linux/io.h>
 
 #include <mach/hardware.h>
-#include <mach/system.h>
 #include <plat/prcm.h>
 
 void omap1_restart(char mode, const char *cmd)
arch/arm/mach-omap2/prcm.c +0 -1
index b6c8cb5..626acfa 100644
@@ -25,7 +25,6 @@
 #include <linux/delay.h>
 #include <linux/export.h>
 
-#include <mach/system.h>
 #include "common.h"
 #include <plat/prcm.h>
 #include <plat/irqs.h>