Skip to contentSkip to conversation

ib_srpt: Update encode_wr_id() argument type

PATCH In review Bart Van Assche 2 participants 2 messages Nov 11, 2011 – Nov 12, 2011

Subsystems (2)
InfiniBand SCSI RDMA protocol (SRP) target
lore
Share & tools
lore

Bart Van Assche

author
#0 lore raw

PATCH 1/3 ib_srpt: Update encode_wr_id() argument type

Since commit 6b7227866 the first argument passed to encode_wr_id() is always of type enum srpt_opcode. Make this explicit by updating the function declaration. Also insert a blank line between function definitions as is done in the rest of the Linux kernel.

Signed-off-by Bart Van Assche <[email protected]>
Cc Nicholas Bellinger <[email protected]>
Cc Roland Dreier <[email protected]>
Cc Christoph Hellwig <[email protected]>
---
 drivers/infiniband/ulp/srpt/ib_srpt.h |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/infiniband/ulp/srpt/ib_srpt.h +3 -1
index fe9e81c..a484941 100644
@@ -138,14 +138,16 @@ enum srpt_opcode {
 	SRPT_RDMA_WRITE_LAST,
 };
 
-static inline u64 encode_wr_id(u8 opcode, u32 idx)
+static inline u64 encode_wr_id(enum srpt_opcode opcode, u32 idx)
 {
 	return ((u64)opcode << 32) | idx;
 }
+
 static inline enum srpt_opcode opcode_from_wr_id(u64 wr_id)
 {
 	return wr_id >> 32;
 }
+
 static inline u32 idx_from_wr_id(u64 wr_id)
 {
 	return (u32)wr_id;
Signature · 6 lines
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 9 lines · Bart Van Assche

Since commit 6b7227866 the first argument passed to encode_wr_id() is always of type enum srpt_opcode. Make this explicit by updating the function declaration. Also insert a blank line between function definitions as is done in the rest of the Linux kernel.

Signed-off-by Bart Van Assche <[email protected]>
Cc Nicholas Bellinger <[email protected]>
Cc Roland Dreier <[email protected]>
Cc Christoph Hellwig <[email protected]>

Series applied.

Thanks Bart!

--nab