Skip to contentSkip to conversation

Glamor update

DISCUSSION Zhigang Gong 3 participants 3 messages Nov 11, 2011 – Nov 14, 2011

lore
Share & tools
lore
#0 lore raw

Hi folks,

During the last discussion about glamor’s plan in this list, we got a conclusion that to extract glamor from xorg and

build a separate glamor library to be used by any possible DDX driver. And Eric suggested I can incrementally

merge glamor into Intel video driver. Now here is the update.

The separate glamor library is at :
git://people.freedesktop.org/~gongzg/glamor,it provides two interfaces:

1. glamor : Rendering library. All the rendering functions are
implemented in this package.

2. glamor-egl : EGL support library. This package provides functions
to create and initialize OpenGL/EGL context.

There are a little bit more details to introduce glamor in the README file.

The Intel video driver to merge glamor is at
git://people.freedesktop.org/~gongzg/xf86-video-intel’s “glamor” branch.

I just started the merging stage. Only finished 3 patches to enable glamor in UXA code path. Currently, only migrate

fillspans and polyfillrect to glamor. Will continue to migrate the rest functions.

I will submit the patches to intel-gfx mail list soon.

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

#1 lore raw

Hello!

Quoted 15 lines · Zhigang Gong

During the last discussion about glamor’s plan in this list, we got a conclusion that to extract glamor from xorg and build a separate glamor library to be used by any possible DDX driver. And Eric suggested I can incrementally merge glamor into Intel video driver. Now here is the update.

The separate glamor library is at :
git://people.freedesktop.org/~gongzg/glamor,it provides two interfaces:

1. glamor : Rendering library. All the rendering functions are
implemented in this package.

2. glamor-egl : EGL support library. This package provides functions
to create and initialize OpenGL/EGL context.

Quoted 8 lines

There are a little bit more details to introduce glamor in the README file.

The Intel video driver to merge glamor is at
git://people.freedesktop.org/~gongzg/xf86-video-intel’s “glamor” branch.

I just started the merging stage. Only finished 3 patches to enable glamor in UXA code path. Currently, only migrate fillspans and polyfillrect to glamor. Will continue to migrate the rest functions.

I've looked over all the source in your glamor repo, and your patches to the Intel driver. This work looks very promising! I'm eager to see more progress.

I don't speak for the Intel graphics team or anything, but I noticed a couple minor things you might clean up. In the "glamor: turn on glamor." commit, there's a patch hunk that just adds an empty ifdef:

-
+#ifdef GLAMOR
+#endif

You might want to remove that. Also, the call to intel_glamor_create_textured_pixmap in intel_uxa_create_pixmap is inconsistently indented; it should just be tabs, looks like.

Any chance you'll add some of the Xephyr/glamor functionality to xf86-video-nested, too? I think that should be easier to test and hack on.

Jamey

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

#2 lore raw
Quoted 45 lines

-----Original Message-----
From: Jamey Sharp [mailto:[email protected]]
Sent: Saturday, November 12, 2011 5:47 AM
To: Zhigang Gong
Cc: [email protected]; [email protected]
Subject: Re: Glamor update

Hello!

Quoted 8 lines · Zhigang Gong

During the last discussion about glamor’s plan in this list, we got a conclusion that to extract glamor from xorg and build a separate glamor library to be used by any possible DDX driver. And Eric suggested I can incrementally merge glamor into Intel video driver. Now here is the update.

The separate glamor library is at :
git://people.freedesktop.org/~gongzg/glamor,it provides two

interfaces:

Quoted 5 lines

1. glamor : Rendering library. All the rendering functions are
implemented in this package.

2. glamor-egl : EGL support library. This package provides

functions

Quoted 6 lines

to create and initialize OpenGL/EGL context.

There are a little bit more details to introduce glamor in the README file.

The Intel video driver to merge glamor is at
git://people.freedesktop.org/~gongzg/xf86-video-intel’s “glamor”

branch.

Quoted 4 lines

I just started the merging stage. Only finished 3 patches to enable glamor in UXA code path. Currently, only migrate fillspans and polyfillrect to glamor. Will continue to migrate the rest functions.

I've looked over all the source in your glamor repo, and your patches to the Intel driver. This work looks very promising! I'm eager to see more progress.

I don't speak for the Intel graphics team or anything, but I noticed a couple minor things you might clean up. In the "glamor: turn on glamor." commit, there's a patch hunk that just adds an empty ifdef:

Review

Quoted 3 lines
(quoted diff) +2 -1
-
+#ifdef GLAMOR
+#endif

Fixed.

Quoted 4 lines

You might want to remove that. Also, the call to intel_glamor_create_textured_pixmap in intel_uxa_create_pixmap is inconsistently indented; it should just be tabs, looks like.

Fixed.
I will submit the new version patch again latter. Thanks for your carefully reviewing.

Quoted 3 lines

Any chance you'll add some of the Xephyr/glamor functionality to xf86-video-nested, too? I think that should be easier to test and hack on.

Currently, we don't have enough bandwidth to do that. If anyone in the community want to do that, I'd be happy to provide help.

Quoted 2 lines

Jamey

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx