usb: serial: pl2303: rm id
Subsystems (2)
PATCH 1/1 usb: serial: pl2303: rm id
I get report from customer that his usb-serial converter doesn't work well,it sometimes work, but sometimes it doesn't.
The usb-serial converter's id:vendor_id product_id0x4348 0x5523
Then I search the usb-serial codes, and there are
two drivers announce support this device, pl2303
and ch341, commit 026dfaf1 cause it. Through many times to test, ch341 works well with this device,
and pl2303 doesn't work quite often(it just work quite little).
ch341 works well with this device, so we doesn't need pl2303 to support.I try to revert 026dfaf1 first, but it failed. So I prepare this patch by hand to revert it.
--- drivers/usb/serial/pl2303.c | 1 - drivers/usb/serial/pl2303.h | 4 ---- 2 files changed, 0 insertions(+), 5 deletions(-)
drivers/usb/serial/pl2303.c +0 -1
@@ -91,7 +91,6 @@ static const struct usb_device_id id_table[] = { { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) }, { USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) }, { USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) }, - { USB_DEVICE(WINCHIPHEAD_VENDOR_ID, WINCHIPHEAD_USBSER_PRODUCT_ID) }, { USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) }, { } /* Terminating entry */ };
drivers/usb/serial/pl2303.h +0 -4
@@ -145,10 +145,6 @@#define ADLINK_VENDOR_ID 0x0b63#define ADLINK_ND6530_PRODUCT_ID 0x6530 -/* WinChipHead USB->RS 232 adapter */ -#define WINCHIPHEAD_VENDOR_ID 0x4348 -#define WINCHIPHEAD_USBSER_PRODUCT_ID 0x5523 -/* SMART USB Serial Adapter */ #define SMART_VENDOR_ID 0x0b8c#define SMART_PRODUCT_ID 0x2303
Signature · 1 line
1.7.3.4
Quoted 54 lines · wangyanqing
I get report from customer that his usb-serial converter doesn't work well,it sometimes work, but sometimes it doesn't.
The usb-serial converter's id:
vendor_idproduct_id0x43480x5523Then I search the usb-serial codes, and there are
two drivers announce support this device, pl2303
and ch341, commit026dfaf1cause it. Through many times to test, ch341 works well with this device,
and pl2303 doesn't work quite often(it just work quite little).ch341 works well with this device, so we doesn't need pl2303 to support.I try to revert
026dfaf1first, but it failed. So I prepare this patch by hand to revert it.Signed-off-by Wang YanQing <[email protected]>--- drivers/usb/serial/pl2303.c | 1 - drivers/usb/serial/pl2303.h | 4 ---- 2 files changed, 0 insertions(+), 5 deletions(-)drivers/usb/serial/pl2303.c +0
-1@@ -91,7 +91,6 @@ static const struct usb_device_id id_table[] = { { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) }, { USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) }, { USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) }, - { USB_DEVICE(WINCHIPHEAD_VENDOR_ID, WINCHIPHEAD_USBSER_PRODUCT_ID) }, { USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) }, { } /* Terminating entry */ };drivers/usb/serial/pl2303.h +0
-4@@ -145,10 +145,6 @@#define ADLINK_VENDOR_ID 0x0b63#define ADLINK_ND6530_PRODUCT_ID 0x6530 -/* WinChipHead USB->RS 232 adapter */ -#define WINCHIPHEAD_VENDOR_ID 0x4348 -#define WINCHIPHEAD_USBSER_PRODUCT_ID 0x5523 -/* SMART USB Serial Adapter */ #define SMART_VENDOR_ID 0x0b8c#define SMART_PRODUCT_ID 0x2303Signature · 1 line
1.7.3.4
Hi all.
Maybe it should be noticed that not only one usb-serial converter base this chip have this issue, but there are about 50(even more) usb-serial coverter lines have the same issue, so we can't ignore it. Of course we can make all the drivers work well, but we should make it useful at the first.
Quoted 45 lines · wangyanqing
Quoted 44 lines · wangyanqing
I get report from customer that his usb-serial converter doesn't work well,it sometimes work, but sometimes it doesn't.
The usb-serial converter's id:
vendor_idproduct_id0x43480x5523Then I search the usb-serial codes, and there are
two drivers announce support this device, pl2303
and ch341, commit026dfaf1cause it. Through many times to test, ch341 works well with this device,
and pl2303 doesn't work quite often(it just work quite little).ch341 works well with this device, so we doesn't need pl2303 to support.I try to revert
026dfaf1first, but it failed. So I prepare this patch by hand to revert it.Signed-off-by Wang YanQing <[email protected]>--- drivers/usb/serial/pl2303.c | 1 - drivers/usb/serial/pl2303.h | 4 ---- 2 files changed, 0 insertions(+), 5 deletions(-)drivers/usb/serial/pl2303.c +0
-1@@ -91,7 +91,6 @@ static const struct usb_device_id id_table[] = { { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) }, { USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) }, { USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) }, - { USB_DEVICE(WINCHIPHEAD_VENDOR_ID, WINCHIPHEAD_USBSER_PRODUCT_ID) }, { USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) }, { } /* Terminating entry */ };drivers/usb/serial/pl2303.h +0
-0@@ -145,10 +145,6 @@#define ADLINK_VENDOR_ID 0x0b63#define ADLINK_ND6530_PRODUCT_ID 0x6530
Quoted 16 lines
Quoted 10 lines
drivers/usb/serial/pl2303.h +0
-4-/* WinChipHead USB->RS 232 adapter */ -#define WINCHIPHEAD_VENDOR_ID 0x4348 -#define WINCHIPHEAD_USBSER_PRODUCT_ID 0x5523 -/* SMART USB Serial Adapter */ #define SMART_VENDOR_ID 0x0b8c#define SMART_PRODUCT_ID 0x2303Signature · 1 line
1.7.3.4Hi all.
Maybe it should be noticed that not only one usb-serial converter base this chip have this issue, but there are about 50(even more) usb-serial coverter lines have the same issue, so we can't ignore it. Of course we can make all the drivers work well, but we should make it useful at the first.
Why not add the device id to the other driver at the same time, that would ensure that the device continues to work, right?
thanks,
greg k-h
Quoted 63 lines · Greg KH
Quoted 45 lines · wangyanqing
Quoted 44 lines · wangyanqing
I get report from customer that his usb-serial converter doesn't work well,it sometimes work, but sometimes it doesn't.
The usb-serial converter's id:
vendor_idproduct_id0x43480x5523Then I search the usb-serial codes, and there are
two drivers announce support this device, pl2303
and ch341, commit026dfaf1cause it. Through many times to test, ch341 works well with this device,
and pl2303 doesn't work quite often(it just work quite little).ch341 works well with this device, so we doesn't need pl2303 to support.I try to revert
026dfaf1first, but it failed. So I prepare this patch by hand to revert it.Signed-off-by Wang YanQing <[email protected]>--- drivers/usb/serial/pl2303.c | 1 - drivers/usb/serial/pl2303.h | 4 ---- 2 files changed, 0 insertions(+), 5 deletions(-)drivers/usb/serial/pl2303.c +0
-1@@ -91,7 +91,6 @@ static const struct usb_device_id id_table[] = { { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) }, { USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) }, { USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) }, - { USB_DEVICE(WINCHIPHEAD_VENDOR_ID, WINCHIPHEAD_USBSER_PRODUCT_ID) }, { USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) }, { } /* Terminating entry */ };drivers/usb/serial/pl2303.h +0
-0@@ -145,10 +145,6 @@#define ADLINK_VENDOR_ID 0x0b63#define ADLINK_ND6530_PRODUCT_ID 0x6530Quoted 16 lines
Quoted 10 lines
drivers/usb/serial/pl2303.h +0
-4-/* WinChipHead USB->RS 232 adapter */ -#define WINCHIPHEAD_VENDOR_ID 0x4348 -#define WINCHIPHEAD_USBSER_PRODUCT_ID 0x5523 -/* SMART USB Serial Adapter */ #define SMART_VENDOR_ID 0x0b8c#define SMART_PRODUCT_ID 0x2303Signature · 1 line
1.7.3.4Hi all.
Maybe it should be noticed that not only one usb-serial converter base this chip have this issue, but there are about 50(even more) usb-serial coverter lines have the same issue, so we can't ignore it. Of course we can make all the drivers work well, but we should make it useful at the first.
Quoted 6 lines
Why not add the device id to the other driver at the same time, that would ensure that the device continues to work, right?
thanks,
greg k-h
Ok greg, thanks for your reply!
But I means maybe I make a very very "bad" subject in the email at all! There are ch341 and pl2303 , two drivers announce to support this device, ch341 works well and pl2303 does't work always.
Maybe I should make the email "shorter" next time. This is the origin email.
https://lkml.org/lkml/2011/11/10/66
We don't need to add the device id to the other driver, ch341 have done it!! Please looks at ch341.c:76 line
"
{ USB_DEVICE(0x4348, 0x5523) }, "Thanks again.
Quoted 76 lines · wangyanqing
Quoted 63 lines · Greg KH
Quoted 45 lines · wangyanqing
Quoted 44 lines · wangyanqing
I get report from customer that his usb-serial converter doesn't work well,it sometimes work, but sometimes it doesn't.
The usb-serial converter's id:
vendor_idproduct_id0x43480x5523Then I search the usb-serial codes, and there are
two drivers announce support this device, pl2303
and ch341, commit026dfaf1cause it. Through many times to test, ch341 works well with this device,
and pl2303 doesn't work quite often(it just work quite little).ch341 works well with this device, so we doesn't need pl2303 to support.I try to revert
026dfaf1first, but it failed. So I prepare this patch by hand to revert it.Signed-off-by Wang YanQing <[email protected]>--- drivers/usb/serial/pl2303.c | 1 - drivers/usb/serial/pl2303.h | 4 ---- 2 files changed, 0 insertions(+), 5 deletions(-)drivers/usb/serial/pl2303.c +0
-1@@ -91,7 +91,6 @@ static const struct usb_device_id id_table[] = { { USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) }, { USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) }, { USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) }, - { USB_DEVICE(WINCHIPHEAD_VENDOR_ID, WINCHIPHEAD_USBSER_PRODUCT_ID) }, { USB_DEVICE(SMART_VENDOR_ID, SMART_PRODUCT_ID) }, { } /* Terminating entry */ };drivers/usb/serial/pl2303.h +0
-0@@ -145,10 +145,6 @@#define ADLINK_VENDOR_ID 0x0b63#define ADLINK_ND6530_PRODUCT_ID 0x6530Quoted 16 lines
Quoted 10 lines
drivers/usb/serial/pl2303.h +0
-4-/* WinChipHead USB->RS 232 adapter */ -#define WINCHIPHEAD_VENDOR_ID 0x4348 -#define WINCHIPHEAD_USBSER_PRODUCT_ID 0x5523 -/* SMART USB Serial Adapter */ #define SMART_VENDOR_ID 0x0b8c#define SMART_PRODUCT_ID 0x2303Signature · 1 line
1.7.3.4Hi all.
Maybe it should be noticed that not only one usb-serial converter base this chip have this issue, but there are about 50(even more) usb-serial coverter lines have the same issue, so we can't ignore it. Of course we can make all the drivers work well, but we should make it useful at the first.Quoted 6 lines
Why not add the device id to the other driver at the same time, that would ensure that the device continues to work, right?
thanks,
greg k-h
Ok greg, thanks for your reply!
But I means maybe I make a very very "bad" subject in the email at all! There are ch341 and pl2303 , two drivers announce to support this device, ch341 works well and pl2303 does't work always.
Quoted 8 lines
Maybe I should make the email "shorter" next time. This is the origin email.
https://lkml.org/lkml/2011/11/10/66We don't need to add the device id to the other driver, ch341 have done it!! Please looks at ch341.c:76 line
"{ USB_DEVICE(0x4348, 0x5523) }, "
Ah, sorry, I missed that, I'll go queue this patch up right now, sorry for the confusion.
greg k-h
Quoted 3 lines
Thanks again.