Skip to contentSkip to conversation

Build breakage in samsung-keypad driver

DISCUSSION Mark Brown 2 participants 5 messages Nov 15, 2011 HID

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

Hi Dmitry,

Your commit 5862c02 (Input: samsung-keypad - enable compiling on other platforms) breaks the build on any platform using the driver as you've moved the header defining the platform data without updating any of the users. Whenever doing updates to platform data you really need to grep the tree for users and make sure they're updated otherwise there will be build breakage.

I also can't see the patch on the list...

Thanks,
Mark

#1 lore raw

Hi Mark,

Quoted 8 lines · Mark Brown

Hi Dmitry,

Your commit 5862c02 (Input: samsung-keypad - enable compiling on other platforms) breaks the build on any platform using the driver as you've moved the header defining the platform data without updating any of the users. Whenever doing updates to platform data you really need to grep the tree for users and make sure they're updated otherwise there will be build breakage.

Hmm, I haven't removed the original header though, I had plat/keypad.h include the new linux/input/samsung-keypad.h so that it should be transparent for all existing users.

Could you tell me exactly what breaks?

Quoted 2 lines

I also can't see the patch on the list...

Admittedly was buried in a separate thread, but:

http://www.spinics.net/lists/linux-samsung-soc/msg06578.html

Thanks.

Signature · 1 line
Dmitry
author
#2 lore raw
Quoted 5 lines · Dmitry Torokhov

Hmm, I haven't removed the original header though, I had plat/keypad.h include the new linux/input/samsung-keypad.h so that it should be transparent for all existing users.

Could you tell me exactly what breaks?

You've not got the name of your new header correct:

arch/arm/plat-samsung/include/plat/keypad.h:16:11: error: unable to open 'linux/input/samsung_keypad.h'

#3 lore raw
Quoted 11 lines · Mark Brown
Quoted 5 lines · Dmitry Torokhov

Hmm, I haven't removed the original header though, I had plat/keypad.h include the new linux/input/samsung-keypad.h so that it should be transparent for all existing users.

Could you tell me exactly what breaks?

You've not got the name of your new header correct:

arch/arm/plat-samsung/include/plat/keypad.h:16:11: error: unable to open 'linux/input/samsung_keypad.h'

Ahh... that explains it. I'll fix it up, sorry for the trouble.

Signature · 1 line
Dmitry
author
#4 lore raw
Quoted 5 lines · Dmitry Torokhov
Quoted 1 line · Mark Brown

arch/arm/plat-samsung/include/plat/keypad.h:16:11: error: unable to open 'linux/input/samsung_keypad.h'

Ahh... that explains it. I'll fix it up, sorry for the trouble.

Thanks! I'd not actually checked what the error came from, I'd just reverted the patch.