remove unneeded vmx_load_host_state() calls.
PATCH 1/1 remove unneeded vmx_load_host_state() calls.
vmx_load_host_state() does not handle msrs switching (except MSR_KERNEL_GS_BASE) since commit 26bb0981b3f. Remove call to it where it is no longer make sense.
Signed-off-by Gleb Natapov <[email protected]>
arch/x86/kvm/vmx.c +0 -5
@@ -1747,7 +1747,6 @@ static void setup_msrs(struct vcpu_vmx *vmx)int save_nmsrs, index;unsigned long *msr_bitmap; -vmx_load_host_state (vmx); save_nmsrs =0 ;#ifdef CONFIG_X86_64 if (is_long_mode (&vmx->vcpu)) {
@@ -2143,12 +2142,10 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 *pdata)return 1 ;/* Otherwise falls through */ default : -vmx_load_host_state (to_vmx (vcpu));if (vmx_get_vmx_msr (vcpu, msr_index, pdata))return 0 ; msr =find_msr_entry (to_vmx (vcpu), msr_index);if (msr) { -vmx_load_host_state (to_vmx (vcpu)); data = msr->data;break ; }
@@ -2172,7 +2169,6 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 data)switch (msr_index) {case MSR_EFER : -vmx_load_host_state (vmx); ret =kvm_set_msr_common (vcpu, msr_index, data);break ;#ifdef CONFIG_X86_64
@@ -2221,7 +2217,6 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 data)break ; msr =find_msr_entry (vmx, msr_index);if (msr) { -vmx_load_host_state (vmx); msr->data = data;break ; }
--
Gleb.
Avi Kivity
AppliedQuoted 5 lines · Gleb Natapov
vmx_load_host_state()does not handle msrs switching (exceptMSR_KERNEL_GS_BASE) since commit26bb0981b3f. Remove call to it where it is no longer make sense.
Applied, thanks.
Signature · 1 line
error compiling committee.c: too many arguments to function