Skip to contentSkip to conversation

net: Armada100: Fix compilation warnings

PATCH New Ajay Bhargav 3 participants 3 messages Oct 31, 2011 – Nov 21, 2011 Network drivers

lore
Share & tools
lore

Ajay Bhargav

author
#0 lore raw

PATCH 1/1 net: Armada100: Fix compilation warnings

This patch fix compilation warnings for Armada100 FEC driver

Ref:
warning: dereferencing type-punned pointer will break strict-aliasing rules

Signed-off-by Ajay Bhargav <[email protected]>
---
 drivers/net/armada100_fec.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)
drivers/net/armada100_fec.c +10 -4
index fbf9763..1a54362 100644
@@ -440,6 +440,7 @@ static int armdfec_init(struct eth_device *dev, bd_t *bd)
 	struct armdfec_device *darmdfec = to_darmdfec(dev);
 	struct armdfec_reg *regs = darmdfec->regs;
 	int phy_adr;
+	u32 temp;
 
 	armdfec_init_rx_desc_ring(darmdfec);
 

@@ -479,9 +480,12 @@ static int armdfec_init(struct eth_device *dev, bd_t *bd)
 	update_hash_table_mac_address(darmdfec, NULL, dev->enetaddr);
 
 	/* Update TX and RX queue descriptor register */
-	writel((u32)darmdfec->p_txdesc, &regs->txcdp[TXQ]);
-	writel((u32)darmdfec->p_rxdesc, &regs->rxfdp[RXQ]);
-	writel((u32)darmdfec->p_rxdesc_curr, &regs->rxcdp[RXQ]);
+	temp = (u32)&regs->txcdp[TXQ];
+	writel((u32)darmdfec->p_txdesc, temp);
+	temp = (u32)&regs->rxfdp[RXQ];
+	writel((u32)darmdfec->p_rxdesc, temp);
+	temp = (u32)&regs->rxcdp[RXQ];
+	writel((u32)darmdfec->p_rxdesc_curr, temp);
 
 	/* Enable Interrupts */
 	writel(ALL_INTS, &regs->im);

@@ -614,6 +618,7 @@ static int armdfec_recv(struct eth_device *dev)
 	struct rx_desc *p_rxdesc_curr = darmdfec->p_rxdesc_curr;
 	u32 cmd_sts;
 	u32 timeout = 0;
+	u32 temp;
 
 	/* wait untill rx packet available or timeout */
 	do {

@@ -667,7 +672,8 @@ static int armdfec_recv(struct eth_device *dev)
 	p_rxdesc_curr->buf_size = PKTSIZE_ALIGN;
 	p_rxdesc_curr->byte_cnt = 0;
 
-	writel((u32)p_rxdesc_curr->nxtdesc_p, (u32)&darmdfec->p_rxdesc_curr);
+	temp = (u32)&darmdfec->p_rxdesc_curr;
+	writel((u32)p_rxdesc_curr->nxtdesc_p, temp);
 
 	return 0;
 }
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 net: Armada100: Fix compilation warnings

Hi Praffula,

Quoted 10 lines · On Mon, 31 Oct 2011 16:49:37 +0530 Ajay Bhargav <[email protected]>…

This patch fix compilation warnings for Armada100 FEC driver

Ref:
warning: dereferencing type-punned pointer will break strict-aliasing rules

Signed-off-by Ajay Bhargav <[email protected]>
---
 drivers/net/armada100_fec.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)
Acked-by Anatolij Gustschin <[email protected]>

Could you apply this patch and send a pull request?

Thanks,
Anatolij

#2 lore raw

PATCH 1/1 net: Armada100: Fix compilation warnings

Quoted 21 lines

-----Original Message-----
From: Anatolij Gustschin [mailto:agust at denx.de]
Sent: Sunday, November 20, 2011 3:39 AM
To: Prafulla Wadaskar
Cc: Ajay Bhargav; u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] net: Armada100: Fix compilation warnings

Hi Praffula,

Quoted 6 lines · On Mon, 31 Oct 2011 16:49:37 +0530 Ajay Bhargav <[email protected]>…

This patch fix compilation warnings for Armada100 FEC driver

Ref:
warning: dereferencing type-punned pointer will break strict-aliasing rules

Quoted 9 lines
Quoted 4 lines
Signed-off-by Ajay Bhargav <[email protected]>
---
 drivers/net/armada100_fec.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)
Acked-by Anatolij Gustschin <[email protected]>

Could you apply this patch and send a pull request?

Applied to u-boot-marvell.git master branch

Regards..
Prafulla . .