Skip to contentSkip to conversation

qnx4fs: Use kmemdup rather than duplicating its implementation

PATCH Applied Anders Larsen 2 participants 2 messages Nov 20, 2011 QNX4 filesystem

lore
Share & tools
lore

Anders Larsen

author maintainer
#0 lore raw

PATCH 1/1 qnx4fs: Use kmemdup rather than duplicating its implementation

From: Thomas Meyer <[email protected]>

The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.

Signed-off-by Thomas Meyer <[email protected]>
Signed-off-by Anders Larsen <[email protected]>

---

fs/qnx4/inode.c 2011-11-08 10:33:59.882543999 +0100 renamed from fs/qnx4/inode.c 2011-11-07 19:38:23.987165894 +0100 +4 -3
diff -u -p a/fs/qnx4/inode.c b/fs/qnx4/inode.c
@@ -199,12 +199,13 @@ static const char *qnx4_checkroot(struct
 					if (!strcmp(rootdir->di_fname,
 						    QNX4_BMNAME)) {
 						found = 1;
-						qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL );
+						qnx4_sb(sb)->BitMap = kmemdup(rootdir,
+									      sizeof(struct qnx4_inode_entry),
+									      GFP_KERNEL);
 						if (!qnx4_sb(sb)->BitMap) {
 							brelse (bh);
 							return "not enough memory for bitmap inode";
-						}
-						memcpy( qnx4_sb(sb)->BitMap, rootdir, sizeof( struct qnx4_inode_entry ) );	/* keep bitmap inode known */
+						}/* keep bitmap inode known */
 						break;
 					}
 				}