xfs: validate acl count
PATCH 1/1 xfs: validate acl count
This prevents in-memory corruption and possible panics if the on-disk ACL is badly corrupted.
Signed-off-by Christoph Hellwig <[email protected]>
fs/xfs/xfs_acl.c +2 -0
@@ -42,6 +42,8 @@ xfs_acl_from_disk(struct xfs_acl *aclp)int count, i; count =be32_to_cpu (aclp->acl_cnt); +if (count >XFS_ACL_MAX_ENTRIES ) +return ERR_PTR (-EFSCORRUPTED ); acl =posix_acl_alloc (count,GFP_KERNEL );if (!acl)
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 4 lines · Christoph Hellwig
This prevents in-memory corruption and possible panics if the on-disk ACL is badly corrupted.
Signed-off-by Christoph Hellwig <[email protected]>
Looks good.
Reviewed-by Ben Myers <[email protected]>
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs