linux-next: build failure after merge of the driver-core tree
Subsystems (2)
Hi Greg,
After merging the driver-core tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:
fs/debugfs/file.c: In function 'debugfs_print_regs32':fs/debugfs/file.c:560:7: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
Caused by commit 1a087c6ad975 ("debugfs: add tools to printk 32-bit registers"). To use readl(), linux/io.h should be included.
I have used the driver-core tree from next-20111118 for today.
Signature · 3 lines
Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
PATCH 1/1 debugfs: bugfix: include <linux/io.h> in file.c
The regs32 machinery uses readl. I forgot the mandatory include and the code was not compiling on all archs.
---
Quoted 6 lines
After merging the driver-core tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
fs/debugfs/file.c: In function 'debugfs_print_regs32':fs/debugfs/file.c:560:7: error: implicit declaration of function 'readl' [- Werror=implicit-function-declaration]
I'm learning the lesson. I'll be more careful next time. Sorry for your patience.
/alessandro
fs/debugfs/file.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
fs/debugfs/file.c +1 -0
@@ -19,6 +19,7 @@#include <linux/pagemap.h> #include <linux/namei.h> #include <linux/debugfs.h> +#include <linux/io.h> static ssize_t default_read_file (struct file *file,char __user *buf,size_t count,loff_t *ppos)
Signature · 1 line
1.6.0.2