Skip to contentSkip to conversation

Efika: Configure additional regulators for HDMI output

PATCH New Marek Vasut 3 participants 13 messages Sep 28, 2011 – Nov 21, 2011

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Signed-off-by Marek Vasut <[email protected]>
Cc Stefano Babic <[email protected]>
---
 board/efikamx/efikamx.c |   16 +++++++++++-----
 1 files changed, 11 insertions(+), 5 deletions(-)
board/efikamx/efikamx.c +11 -5
index 29fff72..276753c 100644
@@ -222,7 +222,7 @@ static void power_init(void)
 
 	/* Set core voltage to 1.1V */
 	val = pmic_reg_read(REG_SW_0);
-	val = (val & ~SWx_VOLT_MASK) | SWx_1_100V;
+	val = (val & ~SWx_VOLT_MASK) | SWx_1_200V;
 	pmic_reg_write(REG_SW_0, val);
 
 	/* Setup VCC (SW2) to 1.25 */

@@ -256,18 +256,24 @@ static void power_init(void)
 		(SWMODE_AUTO_AUTO << SWMODE4_SHIFT);
 	pmic_reg_write(REG_SW_5, val);
 
-	/* Set VDIG to 1.65V, VGEN3 to 1.8V, VCAM to 2.6V */
+	/* Set VDIG to 1.8V, VGEN3 to 1.8V, VCAM to 2.6V */
 	val = pmic_reg_read(REG_SETTING_0);
 	val &= ~(VCAM_MASK | VGEN3_MASK | VDIG_MASK);
-	val |= VDIG_1_65 | VGEN3_1_8 | VCAM_2_6;
+	val |= VDIG_1_8 | VGEN3_1_8 | VCAM_2_6;
 	pmic_reg_write(REG_SETTING_0, val);
 
+
 	/* Set VVIDEO to 2.775V, VAUDIO to 3V, VSD to 3.15V */
 	val = pmic_reg_read(REG_SETTING_1);
 	val &= ~(VVIDEO_MASK | VSD_MASK | VAUDIO_MASK);
-	val |= VSD_3_15 | VAUDIO_3_0 | VVIDEO_2_775;
+	val |= VSD_3_15 | VAUDIO_3_0 | VVIDEO_2_775 | VGEN1_1_2 | VGEN2_3_15;
 	pmic_reg_write(REG_SETTING_1, val);
 
+	/* Enable VGEN1, VGEN2, VDIG, VPLL */
+	val = pmic_reg_read(REG_MODE_0);
+	val |= VGEN1EN | VDIGEN | VGEN2EN | VPLLEN;
+	pmic_reg_write(REG_MODE_0, val);
+
 	/* Configure VGEN3 and VCAM regulators to use external PNP */
 	val = VGEN3CONFIG | VCAMCONFIG;
 	pmic_reg_write(REG_MODE_1, val);

@@ -275,7 +281,7 @@ static void power_init(void)
 
 	/* Enable VGEN3, VCAM, VAUDIO, VVIDEO, VSD regulators */
 	val = VGEN3EN | VGEN3CONFIG | VCAMEN | VCAMCONFIG |
-		VVIDEOEN | VAUDIOEN  | VSDEN;
+		VVIDEOEN | VAUDIOEN | VSDEN;
 	pmic_reg_write(REG_MODE_1, val);
 
 	val = pmic_reg_read(REG_POWER_CTL2);
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

board/efikamx/efikamx.c static void power_init(void) · line 222

Quoted 12 lines · Marek Vasut
Signed-off-by Marek Vasut<[email protected]>
Cc Stefano Babic<[email protected]>
---
  board/efikamx/efikamx.c |   16 +++++++++++-----
  1 files changed, 11 insertions(+), 5 deletions(-)
board/efikamx/efikamx.c +0 -0
index 29fff72..276753c 100644
@@ -222,7 +222,7 @@ static void power_init(void)

Hi Marek,

sorry, I missed this patch - I rebased myself on the actual u-boot-imx, and I applied it. Can you take a look at it to check if it is still ok ?

Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
author
#2 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Quoted 16 lines · Marek Vasut

board/efikamx/efikamx.c static void power_init(void)

Quoted 12 lines
Signed-off-by Marek Vasut<[email protected]>
Cc Stefano Babic<[email protected]>

---

  board/efikamx/efikamx.c |   16 +++++++++++-----
  1 files changed, 11 insertions(+), 5 deletions(-)
board/efikamx/efikamx.c +0 -0
index 29fff72..276753c 100644
@@ -222,7 +222,7 @@ static void power_init(void)

Hi Marek,

Quoted 6 lines

sorry, I missed this patch - I rebased myself on the actual u-boot-imx, and I applied it. Can you take a look at it to check if it is still ok ?

Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic

Jana, you have efikamx and I can get you HDMI cable. Can you recheck tomorrow ?

M

#3 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

2011/11/17 Marek Vasut <[email protected]>

Quoted 6 lines

Jana, you have efikamx and I can get you HDMI cable. Can you recheck tomorrow ?

M

Ok, I can.

author
#4 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Quoted 8 lines

2011/11/17 Marek Vasut <[email protected]>

Quoted 4 lines

Jana, you have efikamx and I can get you HDMI cable. Can you recheck tomorrow ?

M

Ok, I can.

So any updates?

#5 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

2011/11/19 Marek Vasut <[email protected]>

Quoted 11 lines
Quoted 8 lines

2011/11/17 Marek Vasut <[email protected]>

Quoted 4 lines

Jana, you have efikamx and I can get you HDMI cable. Can you recheck tomorrow ?

M

Ok, I can.

So any updates?

HDMI output doesn't work with current u-boot-imx tree (no LCD output after
'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.

Regards,
Jana Rapava

author
#6 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Quoted 11 lines

2011/11/19 Marek Vasut <[email protected]>

Quoted 9 lines
Quoted 8 lines

2011/11/17 Marek Vasut <[email protected]>

Quoted 4 lines

Jana, you have efikamx and I can get you HDMI cable. Can you recheck tomorrow ?

M

Ok, I can.

Quoted 8 lines
Quoted 1 line

So any updates?

HDMI output doesn't work with current u-boot-imx tree (no LCD output after
'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.

Regards,
Jana Rapava

Ok, so are you debugging it or not ?

#7 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

2011/11/20 Marek Vasut <[email protected]>

Quoted 9 lines
Quoted 2 lines

HDMI output doesn't work with current u-boot-imx tree (no LCD output

after

Quoted 3 lines

'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.

Ok, so are you debugging it or not ?

No, I thought that if it works with u-boot-marex/efikasb, it's only a question of
getting some more patches into u-boot-imx.

author
#8 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Quoted 6 lines

2011/11/20 Marek Vasut <[email protected]>

Quoted 4 lines
Quoted 1 line

HDMI output doesn't work with current u-boot-imx tree (no LCD output

after

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.

Ok, so are you debugging it or not ?

No, I thought that if it works with u-boot-marex/efikasb, it's only a question of
getting some more patches into u-boot-imx.

Ok, I'll debug it myself later this week.

author
#9 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

In reply to Jana Rapava
Quoted 6 lines

2011/11/20 Marek Vasut <[email protected]>

Quoted 4 lines
Quoted 1 line

HDMI output doesn't work with current u-boot-imx tree (no LCD output

after

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.

Ok, so are you debugging it or not ?

No, I thought that if it works with u-boot-marex/efikasb, it's only a question of
getting some more patches into u-boot-imx.

Ah ok, nevermind, it seems it can't work yet -- I'll have to recheck.

M

#10 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Quoted 9 lines · Marek Vasut
Quoted 9 lines

2011/11/20 Marek Vasut <[email protected]>

Quoted 7 lines
Quoted 1 line

HDMI output doesn't work with current u-boot-imx tree (no LCD output

after

Quoted 2 lines

'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Ok, so are you debugging it or not ?

No, I thought that if it works with u-boot-marex/efikasb, it's only a question of
getting some more patches into u-boot-imx.

Ah ok, nevermind, it seems it can't work yet -- I'll have to recheck.

Ok - then I'll drop the patch from u-boot-imx, because it is not working (or it is not enough)

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================
author
#11 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Quoted 12 lines · Marek Vasut
Quoted 11 lines
Quoted 11 lines

2011/11/20 Marek Vasut <[email protected]>

Quoted 8 lines
Quoted 1 line

HDMI output doesn't work with current u-boot-imx tree (no LCD output

after

Quoted 2 lines

'setenv stdout lcd'),
but works with current u-boot-marex/efikasb tree.

Ok, so are you debugging it or not ?

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

No, I thought that if it works with u-boot-marex/efikasb, it's only a question of
getting some more patches into u-boot-imx.

Ah ok, nevermind, it seems it can't work yet -- I'll have to recheck.

Ok - then I'll drop the patch from u-boot-imx, because it is not working (or it is not enough)

No, you don't understand. This patch is important, leave it there!

The code which registers the ipuv3 is still missing, that's the point.

M

#12 lore raw

PATCH 1/1 Efika: Configure additional regulators for HDMI output

Quoted 5 lines · Marek Vasut
Quoted 3 lines

Ok - then I'll drop the patch from u-boot-imx, because it is not working (or it is not enough)

No, you don't understand. This patch is important, leave it there!

Ok, the patch does not hurt at all....

Quoted 2 lines

The code which registers the ipuv3 is still missing, that's the point.

...no surprise it does not work...

Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================